Closed
Bug 1353722
Opened 7 years ago
Closed 7 years ago
Handle broken hiddenColumns preference
Categories
(DevTools :: Netmonitor, defect, P1)
DevTools
Netmonitor
Tracking
(firefox55 verified)
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | verified |
People
(Reporter: ntim, Assigned: hey+mozilla)
References
Details
(Keywords: good-first-bug, Whiteboard: [netmonitor-reserve])
Attachments
(1 file)
Currently, if you manually set devtools.netmonitor.hiddenColumns to a broken value, the netmonitor fails to start. It should be as simple as adding a try catch in create-store.js
|
||
Updated•7 years ago
|
Flags: qe-verify?
Whiteboard: [netmonitor][triage]
|
|
||
Updated•7 years ago
|
Blocks: netmonitor-phaseII
|
|
||
Updated•7 years ago
|
Flags: qe-verify? → qe-verify+
Priority: -- → P3
Whiteboard: [netmonitor][triage] → [netmonitor-reserve]
|
||
Comment 1•7 years ago
|
||
ntim, do you think we can cover error handling for all prefs [1] which are used in netmonitor? [1] https://searchfox.org/mozilla-central/source/devtools/client/preferences/devtools.js#147-164
|
||
Updated•7 years ago
|
QA Contact: ciprian.georgiu
| Comment hidden (mozreview-request) |
|
Reporter | |
Updated•7 years ago
|
Attachment #8860685 -
Flags: review?(rchien)
|
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8860685 [details] Bug 1353722 - Catch errors when parsing preferences from filters and hiddenColumns https://reviewboard.mozilla.org/r/132632/#review135512 LGTM
Attachment #8860685 -
Flags: review?(rchien) → review+
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/b198ed331cc8 Catch errors when parsing preferences from filters and hiddenColumns r=rickychien
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b198ed331cc8
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
|
||
Updated•7 years ago
|
Assignee: nobody → ruben.schmidmeister
Iteration: --- → 55.4 - May 1
Priority: P3 → P1
|
||
Comment 6•7 years ago
|
||
I've managed to reproduce this issue using STR from comment 0, on an old Nightly build. I can no longer reproduce it on latest Nightly 55.0a1 (2017-05-04) on the following OSes: Windows 10 x64, Mac OS X 10.11.5 and Ubuntu 16.04 LTS x64.
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•