Add the ability to show/hide more columns in the network panel

VERIFIED FIXED in Firefox 55

Status

()

Firefox
Developer Tools: Netmonitor
P1
normal
VERIFIED FIXED
5 years ago
a year ago

People

(Reporter: st3fan, Assigned: ntim)

Tracking

(Blocks: 2 bugs, {dev-doc-needed})

18 Branch
Firefox 55
dev-doc-needed
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [netmonitor-reserve] [firebug-gap])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Right now it is not easy to see whether a request is on HTTP or HTTPS. Which is very valuable information while debugging or auditing.
It may also be nice to show other things too, like request type, local and remote IP, protocol etc. All columns should be able to be hidden or shown via a settings menu or context menu.
Summary: Please add an (optional) protocol column to the network panel → Add the ability to show more columns in the network panel
OS: Mac OS X → All
Hardware: x86 → All
Priority: -- → P3
Summary: Add the ability to show more columns in the network panel → Add the ability to show/hide more columns in the network panel
Dane MacMillan says in bug 927052:

"A very useful bit of information per request is the status code (200, 404, etc). The only way to view this information is by clicking the request. The color of the orbs only hint at the actual status code (green for 2xx, red for 4xx)."

See this short discussion:

https://hacks.mozilla.org/2013/06/network-monitor-now-in-firefox-beta/comment-page-1/#comment-2151474
Duplicate of this bug: 927052
Blocks: 991806
Whiteboard: [netmonitor-reserve][firebug-gap]
Blocks: 1307743
Flags: qe-verify?
Flags: qe-verify? → qe-verify+
QA Contact: ciprian.georgiu
Blocks: 1348737
No longer blocks: 1307743
Priority: P3 → P2
Whiteboard: [netmonitor-reserve][firebug-gap] → [netmonitor] [firebug-gap]
(Assignee)

Updated

a year ago
Assignee: nobody → ntim.bugs
Comment hidden (mozreview-request)
Status: NEW → ASSIGNED
Priority: P2 → P3
Whiteboard: [netmonitor] [firebug-gap] → [netmonitor-reserve] [firebug-gap]
Thanks for working on this!

I am having trouble to apply the patch.

patching file devtools/client/netmonitor/src/components/request-list-content.js
Hunk #1 FAILED at 214
Hunk #2 succeeded at 237 with fuzz 1 (offset 3 lines).
1 out of 3 hunks FAILED -- saving rejects to file devtools/client/netmonitor/src/components/request-list-content.js.rej
patching file devtools/client/netmonitor/src/components/request-list-item.js
Hunk #2 FAILED at 57
Hunk #3 succeeded at 78 with fuzz 1 (offset -1 lines).
Hunk #4 FAILED at 124
2 out of 4 hunks FAILED -- saving rejects to file devtools/client/netmonitor/src/components/request-list-item.js.rej

Honza
Note: the attached patch is based on a patch from bug 1350234

Honza
Created attachment 8853969 [details]
header-context-menu.png

Thanks for the patch Tim!

Couple of comments:

* The context menu doesn't use check-box to indicate what column is currently visible (see the screenshot).
* If I remove all columns there is no way to get them back since the are with no col label doesn't support the context-menu.
* I think that it shouldn't be possible to remove the last column (the related item in the context menu should be disabled).

Honza
Comment hidden (mozreview-request)
(Assignee)

Comment 9

a year ago
(In reply to Jan Honza Odvarko [:Honza] from comment #7)
> Created attachment 8853969 [details]
> header-context-menu.png
> 
> Thanks for the patch Tim!
> 
> Couple of comments:
> 
> * The context menu doesn't use check-box to indicate what column is
> currently visible (see the screenshot).
> * If I remove all columns there is no way to get them back since the are
> with no col label doesn't support the context-menu.
> * I think that it shouldn't be possible to remove the last column (the
> related item in the context menu should be disabled).
> 
> Honza

I've addressed all your comments, can you check if everything looks alright ?

Thanks!
Flags: needinfo?(odvarko)

Comment 10

a year ago
mozreview-review
Comment on attachment 8853655 [details]
Bug 862855 - Add the ability to show/hide more columns in the network panel.

https://reviewboard.mozilla.org/r/125756/#review128816

Very well done, just a couple of nits.

All points from my comment #7 fixed nicely!

Feedback+

Honza

::: devtools/client/locales/en-US/netmonitor.properties:530
(Diff revision 2)
>  # in the network toolbar for the performance analysis button.
>  netmonitor.toolbar.perf=Toggle performance analysis…
>  
> +# LOCALIZATION NOTE (netmonitor.toolbar.resetColumns): This is the label
> +# displayed in the network table header context menu.
> +netmonitor.toolbar.resetColumns=Reset columns

I think we should capitalize the second word too => "Reset Columns"

::: devtools/client/netmonitor/src/middleware/prefs.js:18
(Diff revision 2)
>  const { Prefs } = require("../utils/prefs");
>  const { getRequestFilterTypes } = require("../selectors/index");
>  
>  /**
>    * Whenever the User clicks on a filter in the network monitor, save the new
>    * filters for future tabs

Please update this comment.

::: devtools/client/netmonitor/src/request-list-header-context-menu.js:43
(Diff revision 2)
> +        label: L10N.getStr(`netmonitor.toolbar.${stringMap[column] || column}`),
> +        type: "checkbox",
> +        checked: shown,
> +        click: () => this.toggleColumn(column),
> +
> +        // We don't want to allow disabling the last visible column

nit: we don't want to allow hiding the last visible column.
Flags: needinfo?(odvarko)
Comment hidden (mozreview-request)

Comment 12

a year ago
mozreview-review
Comment on attachment 8853655 [details]
Bug 862855 - Add the ability to show/hide more columns in the network panel.

https://reviewboard.mozilla.org/r/125756/#review128854

Looks great!

R+ assuming Try is green

Thanks Tim!

Honza
Attachment #8853655 - Flags: review?(odvarko) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 15

a year ago
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/287de7a0ca04
Add the ability to show/hide more columns in the network panel. r=Honza
(Assignee)

Updated

a year ago
Depends on: 1353380
(Assignee)

Updated

a year ago
Keywords: dev-doc-needed
See Also: → bug 1041895

Comment 16

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/287de7a0ca04
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
(Assignee)

Updated

a year ago
Depends on: 1353716
(Assignee)

Updated

a year ago
Depends on: 1353722
Iteration: --- → 55.3 - Apr 17
Priority: P3 → P1
Blocks: 1354446
I can verify that it's working as expected in latest Nightly 55.0a1 (2017-04-06).

Sebastian
Status: RESOLVED → VERIFIED
Flags: qe-verify+
(Assignee)

Updated

a year ago
Duplicate of this bug: 1136248
You need to log in before you can comment on or make changes to this bug.