It is not very convenience when I click "Manage Search Engines..." from SearchBar

VERIFIED FIXED in Firefox 55

Status

()

defect
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: alice0775, Assigned: jaws)

Tracking

55 Branch
Firefox 55
x86
Windows 10
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 verified)

Details

Attachments

(2 attachments)

Reporter

Description

2 years ago
After landing Bug 1335907, There are many irrelevant groups displayed when I clicked "Manage Search Engines..." from SearchBar.
I did not know which "Search Engine Management" falls under.

And It is necessary to scroll the page a lot.

I think irrelevant groups should be hide in this case.
Reporter

Comment 1

2 years ago
Posted image bug.png
Depends on: 1335905
No longer depends on: 1335905
Depends on: 1353832
The patch in bug 1353805 adds support for a simple fix for this.
Blocks: 1353805
Assignee: nobody → jaws
Status: NEW → ASSIGNED

Comment 4

2 years ago
mozreview-review
Comment on attachment 8855149 [details]
Bug 1353808 - Only show the 'Search' preferences when the Manage Search Engines button is clicked.

https://reviewboard.mozilla.org/r/127044/#review131522

::: browser/components/search/content/search.xml:1423
(Diff revision 1)
>        </method>
>  
>        <method name="showSettings">
>          <body><![CDATA[
>            BrowserUITelemetry.countSearchSettingsEvent(this.telemetryOrigin);
> -          openPreferences("paneGeneral");
> +          openPreferences("general-search");

Can you add a quick test for this too?
Attachment #8855149 - Flags: review?(mconley) → review-
Comment hidden (mozreview-request)

Comment 6

2 years ago
mozreview-review
Comment on attachment 8855149 [details]
Bug 1353808 - Only show the 'Search' preferences when the Manage Search Engines button is clicked.

https://reviewboard.mozilla.org/r/127044/#review131674

Great, thanks!
Attachment #8855149 - Flags: review?(mconley) → review+

Comment 7

2 years ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9929b37fea68
Only show the 'Search' preferences when the Manage Search Engines button is clicked. r=mconley

Updated

2 years ago
Blocks: 1335454

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9929b37fea68
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
I have reproduced this bug with Nightly 55.0a1 (2017-04-05) (64-bit) on Ubuntu 16.04 LTS!

This bug's fix is verified with latest Nightly! 


Build ID   : 20170419100228
User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170419]
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.