Closed
Bug 1353808
Opened 9 years ago
Closed 9 years ago
It is not very convenience when I click "Manage Search Engines..." from SearchBar
Categories
(Firefox :: Settings UI, defect)
Tracking
()
VERIFIED
FIXED
Firefox 55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | verified |
People
(Reporter: alice0775, Assigned: jaws)
References
Details
Attachments
(2 files)
bug.png
After landing Bug 1335907, There are many irrelevant groups displayed when I clicked "Manage Search Engines..." from SearchBar.
I did not know which "Search Engine Management" falls under.
And It is necessary to scroll the page a lot.
I think irrelevant groups should be hide in this case.
|
Reporter | |
Comment 1•9 years ago
|
||
|
Assignee | |
Comment 2•9 years ago
|
||
The patch in bug 1353805 adds support for a simple fix for this.
Blocks: 1353805
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
| Comment hidden (mozreview-request) |
|
||
Comment 4•9 years ago
|
||
| mozreview-review | ||
Comment on attachment 8855149 [details]
Bug 1353808 - Only show the 'Search' preferences when the Manage Search Engines button is clicked.
https://reviewboard.mozilla.org/r/127044/#review131522
::: browser/components/search/content/search.xml:1423
(Diff revision 1)
> </method>
>
> <method name="showSettings">
> <body><![CDATA[
> BrowserUITelemetry.countSearchSettingsEvent(this.telemetryOrigin);
> - openPreferences("paneGeneral");
> + openPreferences("general-search");
Can you add a quick test for this too?
Attachment #8855149 -
Flags: review?(mconley) → review-
| Comment hidden (mozreview-request) |
|
|
||
Comment 6•9 years ago
|
||
| mozreview-review | ||
Comment on attachment 8855149 [details]
Bug 1353808 - Only show the 'Search' preferences when the Manage Search Engines button is clicked.
https://reviewboard.mozilla.org/r/127044/#review131674
Great, thanks!
Attachment #8855149 -
Flags: review?(mconley) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9929b37fea68
Only show the 'Search' preferences when the Manage Search Engines button is clicked. r=mconley
|
||
Comment 8•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
||
Comment 9•8 years ago
|
||
I have reproduced this bug with Nightly 55.0a1 (2017-04-05) (64-bit) on Ubuntu 16.04 LTS!
This bug's fix is verified with latest Nightly!
Build ID : 20170419100228
User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0
[bugday-20170419]
|
|
Assignee | |
Updated•8 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•