1353826 - Move common Fennec theme to GeckoView

Status: RESOLVED FIXED

(GeckoView :: General, enhancement)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Now that we have a Fennec omni.ja and a GeckoView omni.ja, we should move the subset of Fennec theme that's common to GeckoView to the GeckoView omni.ja, things like form input styling.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1353826 - Move common Fennec theme to GeckoView;

Move Fennec theme files that are common to GeckoView into geckoview.jar,
and place them under chrome://geckoview/. These include content
stylesheets, accessible-caret images, and video-control images. Update
previous URIs to point to the new location.
---
 .../android/components/MobileComponents.manifest   |   2 +-
 .../components/geckoview/GeckoView.manifest        |   3 ++
 mobile/android/moz.build                           |   1 +
 mobile/android/themes/core/aboutAddons.css         |   2 +-
 mobile/android/themes/core/defines.css             |  11 -------
 mobile/android/themes/core/jar.mn                  |  24 --------------
 mobile/android/themes/core/netError.css            |   4 +--
 .../android/themes/{core => geckoview}/content.css |  26 +++++++--------
 mobile/android/themes/geckoview/defines.css        |  12 +++++++
 .../images/accessiblecaret-normal-hdpi.png         | Bin
 .../images/accessiblecaret-normal-xhdpi.png        | Bin
 .../images/accessiblecaret-normal-xxhdpi.png       | Bin
 .../images/accessiblecaret-tilt-left-hdpi.png      | Bin
 .../images/accessiblecaret-tilt-left-xhdpi.png     | Bin
 .../images/accessiblecaret-tilt-left-xxhdpi.png    | Bin
 .../images/accessiblecaret-tilt-right-hdpi.png     | Bin
 .../images/accessiblecaret-tilt-right-xhdpi.png    | Bin
 .../images/accessiblecaret-tilt-right-xxhdpi.png   | Bin
 .../images/dropmarker-right.svg                    |   0
 .../{core => geckoview}/images/dropmarker.svg      |   0
 .../images/videocontrols-cast-active.svg}          |   0
 .../images/videocontrols-cast-ready.svg}           |   0
 .../images/videocontrols-exitfullscreen.svg}       |   0
 .../images/videocontrols-fullscreen.svg}           |   0
 .../images/videocontrols-mute.svg}                 |   0
 .../images/videocontrols-pause.svg}                |   0
 .../images/videocontrols-play.svg}                 |   0
 .../images/videocontrols-scrubber.svg}             |   0
 .../images/videocontrols-unmute.svg}               |   0
 mobile/android/themes/geckoview/jar.mn             |  35 +++++++++++++++++++++
 mobile/android/themes/geckoview/moz.build          |   7 +++++
 .../themes/{core => geckoview}/scrollbar-apz.css   |   0
 .../videocontrols.css}                             |  18 +++++------
 33 files changed, 84 insertions(+), 61 deletions(-)
 rename mobile/android/themes/{core => geckoview}/content.css (90%)
 create mode 100644 mobile/android/themes/geckoview/defines.css
 rename mobile/android/themes/{core => geckoview}/images/accessiblecaret-normal-hdpi.png (100%)
 rename mobile/android/themes/{core => geckoview}/images/accessiblecaret-normal-xhdpi.png (100%)
 rename mobile/android/themes/{core => geckoview}/images/accessiblecaret-normal-xxhdpi.png (100%)
 rename mobile/android/themes/{core => geckoview}/images/accessiblecaret-tilt-left-hdpi.png (100%)
 rename mobile/android/themes/{core => geckoview}/images/accessiblecaret-tilt-left-xhdpi.png (100%)
 rename mobile/android/themes/{core => geckoview}/images/accessiblecaret-tilt-left-xxhdpi.png (100%)
 rename mobile/android/themes/{core => geckoview}/images/accessiblecaret-tilt-right-hdpi.png (100%)
 rename mobile/android/themes/{core => geckoview}/images/accessiblecaret-tilt-right-xhdpi.png (100%)
 rename mobile/android/themes/{core => geckoview}/images/accessiblecaret-tilt-right-xxhdpi.png (100%)
 rename mobile/android/themes/{core => geckoview}/images/dropmarker-right.svg (100%)
 rename mobile/android/themes/{core => geckoview}/images/dropmarker.svg (100%)
 rename mobile/android/themes/{core/images/cast-active.svg => geckoview/images/videocontrols-cast-active.svg} (100%)
 rename mobile/android/themes/{core/images/cast-ready.svg => geckoview/images/videocontrols-cast-ready.svg} (100%)
 rename mobile/android/themes/{core/images/exitfullscreen.svg => geckoview/images/videocontrols-exitfullscreen.svg} (100%)
 rename mobile/android/themes/{core/images/fullscreen.svg => geckoview/images/videocontrols-fullscreen.svg} (100%)
 rename mobile/android/themes/{core/images/mute.svg => geckoview/images/videocontrols-mute.svg} (100%)
 rename mobile/android/themes/{core/images/pause.svg => geckoview/images/videocontrols-pause.svg} (100%)
 rename mobile/android/themes/{core/images/play.svg => geckoview/images/videocontrols-play.svg} (100%)
 rename mobile/android/themes/{core/images/scrubber.svg => geckoview/images/videocontrols-scrubber.svg} (100%)
 rename mobile/android/themes/{core/images/unmute.svg => geckoview/images/videocontrols-unmute.svg} (100%)
 create mode 100644 mobile/android/themes/geckoview/jar.mn
 create mode 100644 mobile/android/themes/geckoview/moz.build
 rename mobile/android/themes/{core => geckoview}/scrollbar-apz.css (100%)
 rename mobile/android/themes/{core/touchcontrols.css => geckoview/videocontrols.css} (84%)

Review commit: https://reviewboard.mozilla.org/r/140778/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140778/

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8869149 [details]
Bug 1353826 - Move common Fennec theme to GeckoView;

https://reviewboard.mozilla.org/r/140778/#review144304

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/57661b1bb49c
Move common Fennec theme to GeckoView; r=snorp

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/57661b1bb49c

Comment 6

[Mike Conley (:mconley) (:⚙️)]

https://hg.mozilla.org/projects/cedar/rev/57661b1bb49c6b9dd5d33871c5645c168e055697
Bug 1353826 - Move common Fennec theme to GeckoView; r=snorp