1353934 - Remove the warning about system addons having no updates property

Status: RESOLVED DUPLICATE of bug 1521418

(Toolkit :: Add-ons Manager, enhancement, P5)

Description

[Andy McKay]

Because I run Firefox with stdout a bit I get this message a bunch of times in my output, once for each system add-on.

1491404425867	addons.update-checker	WARN	Update manifest for [e-mail] did not contain an updates property

Would be nice if we could suppress that somehow.

Comment 1

[Robert Helmer [:rhelmer]]

Pretty sure we don't use this for anything anyway, except maybe checking for compatibility updates.

Really we should probably just enforce that system add-ons *don't* have an updates property, and not bother showing the warning if addon.isSystem

Comment 4

[R P Herrold]

This continues to show on stderr with FF 52 ESR

1500907360847	addons.update-checker	WARN	Update manifest for [e-mail] did not contain an updates property

Comment 6

[Robert Helmer [:rhelmer]]

I don't have time to work on this but happy to mentor someone who does.

Comment 7

[pollet]

Hello, I'm Pollet Obuya from Kenya applying for the outreachy internship. I would love to work on this please.

Comment 8

[pollet]

(In reply to Robert Helmer [:rhelmer] from comment #6)

Hello Robert. I would like to be mentored on this. Have you worked on it previously? And if so where did you reach?

Comment 9

[Robert Helmer [:rhelmer]]

(In reply to pollet from comment #8)

(In reply to Robert Helmer [:rhelmer] from comment #6)

Hello Robert. I would like to be mentored on this. Have you worked on it previously? And if so where did you reach?

Thanks for taking this on! If this is your first contribution, please see our onboarding guide: https://wiki.mozilla.org/WebExtensions/Contribution_Onramp

I've just tested this and looks like the log message is a little different now but same basic problem:

onUpdateCheckComplete failed to parse update manifest: (...)

To test this yourself locally, try toggling extensions.logging.enabled in about:config to true, then run this in the Browser Console (Menu -> Web Developer -> Browser Console), then initiate a background update like this:

ChromeUtils.import("resource://gre/modules/AddonManager.jsm"); AddonManagerPrivate.backgroundUpdateCheck();

You should see the warning messages here.

The warning is coming from:
https://searchfox.org/mozilla-central/rev/00f3836a87b844b5e4bc82f698c559b9966e4be2/toolkit/mozapps/extensions/internal/AddonUpdateChecker.jsm#292

This warning can safely be suppressed if isSystem for the Addon object being checked. It looks like the Addon object itself is not passed into the AddonUpdateChecker.checkForUpdates function above, so I'd take a look at the callers (you can use the Searchfox tool linked above to do this) and see if you can find a good place there to check .isSystem.

Thanks again!

Comment 10

[Robert Helmer [:rhelmer]]

Oops sorry turned out this was recently fixed in bug 1521418.

You can find more good-first-bugs in these queries:

https://mzl.la/2yq1XA8
https://mzl.la/2T2lCQA

Comment 11

[pollet]

Okay. Thank you. i'll take a look at those