1521418 - Unnecessary duplicate update check for system addons

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement, P5)

Description

[Trishul]

While performing backgroundUpdateCheck for normal extensions, the function also checks updates for system addon ie, fetches update URL
https://searchfox.org/mozilla-central/source/toolkit/mozapps/extensions/AddonManager.jsm#1286

which eventually it do not install because of
https://searchfox.org/mozilla-central/source/toolkit/mozapps/extensions/AddonManager.jsm#1294

The system addons are updated only by updateSystemAddons method
https://searchfox.org/mozilla-central/source/toolkit/mozapps/extensions/AddonManager.jsm#1315

So this results in unnecessary request to update URLs of system addons.

Comment 1

[Andrew Swan [:aswan]]

We never actually get to checking for the CAN_UPGRADE permission since system addons don't have update URLs. We have a separate bug about avoiding warning about that (bug 1353934)

Comment 2

[Trishul]

Hi @aswan,

Thanks for your review.
I think I may not have been able to explain correctly.

There are GET request to versioncheck-bg.addons.mozilla.org for system addons (due to update check), which is of no use as we update system addons with different process and eventually leads to warnings mentioned in #1353934.

Please see the attachment. There are Requests to update system addons for example.

https://versioncheck-bg.addons.mozilla.org/update/VersionCheck.php?reqVersion=2&id=[e-mail]&version=1.1.0&maxAppVersion=null&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=66.0a1&appOS=Darwin&appABI=x86_64-gcc3&locale=en-US&currentAppVersion=66.0a1&updateType=112&compatMode=normal

Since there is no update URL in [e-mail] it request update from URL in extensions.update.background.url pref.
This return a blank object and hence the warning is generated as mentioned in #1353934.

The fix for this would be as simple as adding
if (addon.signedState === AddonManager.SIGNEDSTATE_SYSTEM) continue;
just when loop starts at https://searchfox.org/mozilla-central/source/toolkit/mozapps/extensions/AddonManager.jsm#1286

Comment 3

[Trishul]

Attachment: Screen Shot 2019-01-21 at 06.31.01.png

Comment 4

[Andrew Swan [:aswan]]

Thanks for the clarification

Comment 5

[Trishul]

Attachment: Bug 1521418 - Remove system addons from update check of normal extensions. r=aswan

Remove system addons from update check of notmal addons

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bca8ef2bc43f
Remove system addons from update check of normal extensions. r=aswan

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/bca8ef2bc43f