1354083 - Add a pref to show a static hamburger menu when enabled

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, enhancement, P1)

Description

[Mike de Boer [:mikedeboer]]

The pref name would be something along the lines of 'browser.photon.menusRefresh' --> 'true'.

When `true`, it'll show the new, static version of the menu panel when the hamburger button is clicked.

NB: we will be using the same pref for the new overflow menu, Library button, Action menu, sidebars refresh and the Customize mode refresh. This bug will _not_ implement the behavior for these UI areas.

Comment 1

[:Gijs (out for now; he/him)]

Attachment: Bug 1354083 - create a photon structure pref and a panel for photon hamburger menu use,

Review commit: https://reviewboard.mozilla.org/r/128578/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128578/

Comment 2

[:Gijs (out for now; he/him)]

Please bikeshed naming for the popup and the pref. :-)

Comment 3

[:Gijs (out for now; he/him)]

Comment on attachment 8856644 [details]
Bug 1354083 - create a photon structure pref and a panel for photon hamburger menu use,

https://reviewboard.mozilla.org/r/128578/#review130984

::: browser/components/customizableui/content/panelUI.inc.xul:490
(Diff revision 1)
> +       role="group"
> +       type="arrow"
> +       hidden="true"
> +       flip="slide"
> +       position="bottomcenter topright"
> +       noautofocus="true">

I copied all of these from the existing panel. They seem to make sense to me. :-)

Comment 4

[Mike de Boer [:mikedeboer]]

Comment on attachment 8856644 [details]
Bug 1354083 - create a photon structure pref and a panel for photon hamburger menu use,

https://reviewboard.mozilla.org/r/128578/#review131314

LGTM, time to get this train moving!

::: browser/components/customizableui/content/panelUI.js:17
(Diff revision 1)
>                                    "resource://gre/modules/AppConstants.jsm");
>  
> +XPCOMUtils.defineLazyPreferenceGetter(this, "gPhotonStructure",
> +  "browser.photon.structure.enabled", false);
> +XPCOMUtils.defineLazyGetter(this, "gPanelPopupId", function() {
> +  return gPhotonStructure ? "PanelUI-photon-popup" : "PanelUI-popup";

I don't see us re-using this getter, so I don't think there's a reason to make it a global.

Can you put this in below? `panel: gPhotonStructure ? "PanelUI-photon-popup" : "PanelUI-popup",`

Comment 5

[:Gijs (out for now; he/him)]

Comment on attachment 8856644 [details]
Bug 1354083 - create a photon structure pref and a panel for photon hamburger menu use,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/128578/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a66839ef4655
create a photon structure pref and a panel for photon hamburger menu use, r=mikedeboer

Comment 7

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/a66839ef4655

Comment 8

[Saddam Hossain]

I have reproduced this Bug on Nightly 55.0a1 (2017-04-06) on Windows 10, 64 Bit!

The bug's fix is now verified on latest  Beta 55.0b2

Build ID    :	20170615063713
User Agent  : 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170614]