Closed Bug 1354128 Opened 3 years ago Closed 3 years ago

Add 'Web Developer' button to static hamburger menu

Categories

(Firefox :: Toolbars and Customization, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 55
Iteration:
55.6 - May 29
Tracking Status
firefox55 --- verified

People

(Reporter: mikedeboer, Assigned: mikedeboer)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [photon-structure])

Attachments

(1 file)

This button opens a subview when clicked, which contains the same items as the current 'Developer' subiew widget.

The title of the subview reads 'Web Developer', the same as the button label.
The button should be placed right below the 'More' button.
No longer depends on: 1354119
Flags: qe-verify+
Priority: -- → P2
QA Contact: gwimberly
Whiteboard: [photon] → [photon-structure]
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Iteration: --- → 55.5 - May 15
Priority: P2 → P1
Comment on attachment 8866882 [details]
Bug 1354128 - Add Web Developer button to the photon app menu.

https://reviewboard.mozilla.org/r/138480/#review142084

::: browser/components/customizableui/PanelMultiView.jsm:398
(Diff revision 1)
> +          if (custWidget.onBeforeCreated)
> +            custWidget.onBeforeCreated(document);

Hrm. onBeforeCreated normally is used when we create the widget (ie toolbarbutton) in the document. Now it might be called twice for a given document.

Can we refactor this differently, maybe by giving the widget an onViewShowing method and/or ensuring that calls some other method on its definition that guards against being called multiple times?

::: browser/components/customizableui/content/panelUI.inc.xul:584
(Diff revision 1)
>          <toolbarbutton id="appMenu-more-button"
>                         class="subviewbutton subviewbutton-nav"
>                         label="&moreMenu.label;"
>                         closemenu="none"
>                         oncommand="PanelUI.showSubView('appMenu-moreView', this)"/>
> +        <toolbarbutton id="appMenu-more-button"

The ID is wrong here. :-)
Attachment #8866882 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8866882 [details]
Bug 1354128 - Add Web Developer button to the photon app menu.

https://reviewboard.mozilla.org/r/138480/#review142748
Attachment #8866882 - Flags: review?(gijskruitbosch+bugs) → review+
Thanks, and sorry for the delay. I'll try to get to the other reviews tomorrow.
Iteration: 55.5 - May 15 → 55.6 - May 29
Pushed by mdeboer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5f44d08bfcb9
Add Web Developer button to the photon app menu. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/5f44d08bfcb9
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Verified on Windows, Mac, and Ubuntu.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Blocks: 1387512
You need to log in before you can comment on or make changes to this bug.