Add 'Web Developer' button to static hamburger menu

VERIFIED FIXED in Firefox 55

Status

()

Firefox
Toolbars and Customization
P1
normal
VERIFIED FIXED
8 months ago
4 months ago

People

(Reporter: mikedeboer, Assigned: mikedeboer)

Tracking

(Blocks: 2 bugs)

Trunk
Firefox 55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 verified)

Details

(Whiteboard: [photon-structure], URL)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

This button opens a subview when clicked, which contains the same items as the current 'Developer' subiew widget.

The title of the subview reads 'Web Developer', the same as the button label.
The button should be placed right below the 'More' button.

Updated

8 months ago
No longer depends on: 1354119

Updated

8 months ago
Flags: qe-verify+
Priority: -- → P2
QA Contact: gwimberly
Whiteboard: [photon] → [photon-structure]
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED

Updated

7 months ago
Iteration: --- → 55.5 - May 15
Priority: P2 → P1
Comment hidden (mozreview-request)

Comment 2

7 months ago
mozreview-review
Comment on attachment 8866882 [details]
Bug 1354128 - Add Web Developer button to the photon app menu.

https://reviewboard.mozilla.org/r/138480/#review142084

::: browser/components/customizableui/PanelMultiView.jsm:398
(Diff revision 1)
> +          if (custWidget.onBeforeCreated)
> +            custWidget.onBeforeCreated(document);

Hrm. onBeforeCreated normally is used when we create the widget (ie toolbarbutton) in the document. Now it might be called twice for a given document.

Can we refactor this differently, maybe by giving the widget an onViewShowing method and/or ensuring that calls some other method on its definition that guards against being called multiple times?

::: browser/components/customizableui/content/panelUI.inc.xul:584
(Diff revision 1)
>          <toolbarbutton id="appMenu-more-button"
>                         class="subviewbutton subviewbutton-nav"
>                         label="&moreMenu.label;"
>                         closemenu="none"
>                         oncommand="PanelUI.showSubView('appMenu-moreView', this)"/>
> +        <toolbarbutton id="appMenu-more-button"

The ID is wrong here. :-)
Attachment #8866882 - Flags: review?(gijskruitbosch+bugs)
Comment hidden (mozreview-request)

Comment 4

7 months ago
mozreview-review
Comment on attachment 8866882 [details]
Bug 1354128 - Add Web Developer button to the photon app menu.

https://reviewboard.mozilla.org/r/138480/#review142748
Attachment #8866882 - Flags: review?(gijskruitbosch+bugs) → review+

Comment 5

7 months ago
Thanks, and sorry for the delay. I'll try to get to the other reviews tomorrow.

Updated

7 months ago
Iteration: 55.5 - May 15 → 55.6 - May 29

Comment 6

7 months ago
Pushed by mdeboer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5f44d08bfcb9
Add Web Developer button to the photon app menu. r=Gijs

Comment 7

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5f44d08bfcb9
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Verified on Windows, Mac, and Ubuntu.
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
Flags: qe-verify+
Blocks: 1387512
You need to log in before you can comment on or make changes to this bug.