1354128 - Add 'Web Developer' button to static hamburger menu

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, enhancement, P1)

Description

[Mike de Boer [:mikedeboer]]

This button opens a subview when clicked, which contains the same items as the current 'Developer' subiew widget.

The title of the subview reads 'Web Developer', the same as the button label.
The button should be placed right below the 'More' button.

Comment 1

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1354128 - Add Web Developer button to the photon app menu.

Review commit: https://reviewboard.mozilla.org/r/138480/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/138480/

Comment 2

[:Gijs (out for now; he/him)]

Comment on attachment 8866882 [details]
Bug 1354128 - Add Web Developer button to the photon app menu.

https://reviewboard.mozilla.org/r/138480/#review142084

::: browser/components/customizableui/PanelMultiView.jsm:398
(Diff revision 1)
> +          if (custWidget.onBeforeCreated)
> +            custWidget.onBeforeCreated(document);

Hrm. onBeforeCreated normally is used when we create the widget (ie toolbarbutton) in the document. Now it might be called twice for a given document.

Can we refactor this differently, maybe by giving the widget an onViewShowing method and/or ensuring that calls some other method on its definition that guards against being called multiple times?

::: browser/components/customizableui/content/panelUI.inc.xul:584
(Diff revision 1)
>          <toolbarbutton id="appMenu-more-button"
>                         class="subviewbutton subviewbutton-nav"
>                         label="&moreMenu.label;"
>                         closemenu="none"
>                         oncommand="PanelUI.showSubView('appMenu-moreView', this)"/>
> +        <toolbarbutton id="appMenu-more-button"

The ID is wrong here. :-)

Comment 3

[Mike de Boer [:mikedeboer]]

Comment on attachment 8866882 [details]
Bug 1354128 - Add Web Developer button to the photon app menu.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/138480/diff/1-2/

Comment 4

[:Gijs (out for now; he/him)]

Comment on attachment 8866882 [details]
Bug 1354128 - Add Web Developer button to the photon app menu.

https://reviewboard.mozilla.org/r/138480/#review142748

Comment 5

[:Gijs (out for now; he/him)]

Thanks, and sorry for the delay. I'll try to get to the other reviews tomorrow.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f44d08bfcb9
Add Web Developer button to the photon app menu. r=Gijs

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5f44d08bfcb9

Comment 8

[u554753]

Verified on Windows, Mac, and Ubuntu.