1354146 - Allow keyboard navigation using accesskeys in panelmultiview subviews

Status: REOPENED

(Firefox :: Toolbars and Customization, enhancement, P5)

Description

[Mike de Boer [:mikedeboer]]

It should be possible to use the access keys to directly select a specific item from the list of menu items inside the subview that's currently active.

In other words: when an item contains the attribute 'accesskey', it'll work exactly the same as its usage in other (sub-)menus. This also means that the keyboard navigation in bookmark folder sub-menus should also be supported.

Please take IME input modes into account.

Comment 1

[Mike de Boer [:mikedeboer]]

Note: explicitly defined accesskeys usually impact the appearance of menu item labels, displaying the character as underlined.

Comment 2

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1354146 - add support for keyboard navigation inside panel views.

Review commit: https://reviewboard.mozilla.org/r/138960/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/138960/

Comment 3

[Mike de Boer [:mikedeboer]]

This is more like a feedback request, because it at least needs tests. Just curious to know what you think of this approach.

Comment 4

[Mike de Boer [:mikedeboer]]

Comment on attachment 8867422 [details]
Bug 1354146 - add support for keyboard navigation inside panel views.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/138960/diff/1-2/

Comment 5

[Mike de Boer [:mikedeboer]]

Hmm, looks like my patches here do what I describe in bug 1354146. I think I should've posted the patches in that bug instead. :/

Comment 6

[Mike de Boer [:mikedeboer]]

I meant bug 1354144.

Comment 9

[:Gijs (he/him)]

Oops, the other bug is about the toolbar, and this is about the panel, so I guess we should keep this open.