[e10s] The text does not show in <select> options

RESOLVED FIXED in Firefox 54

Status

()

Core
Layout: Form Controls
RESOLVED FIXED
8 months ago
10 days ago

People

(Reporter: blinky, Assigned: jaws)

Tracking

(Depends on: 1 bug, Blocks: 1 bug, {regression})

55 Branch
mozilla55
x86_64
Windows 7
regression
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox52 unaffected, firefox-esr52 unaffected, firefox53 unaffected, firefox54 fixed, firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

8 months ago
Steps to reproduce:

1. Download and extracts the archive https://onedrive.live.com/download?cid=F96BA52A2AF70D03&resid=F96BA52A2AF70D03%211221&authkey=AITkrKeTDOkSYTM.
2. Open index.htm
3. Open the <select> element.


Actual results:

The text does not show in <select> options.

Screenshot https://1drv.ms/i/s!AgMN9yoqpWv5iUY-ejyVFOQIbJaC
Flags: needinfo?(jaws)
(Reporter)

Comment 1

8 months ago
Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d66ec372454c676e487da5ba47167a79dcfea001&tochange=d02ab1fb2cbc43b425c2858d3b70f9ade88cfd65

Regressed by: bug 1335483
Blocks: 1335483
Keywords: regression

Updated

8 months ago
Blocks: 1154677

Updated

8 months ago
status-firefox52: --- → unaffected
status-firefox53: --- → unaffected
status-firefox54: --- → affected
status-firefox55: --- → affected
This data URI reproduces the bug:
data:text/html,<style>select { color: rgba(0, 0, 0, 0); text-shadow: 0 0 0 black; }</style><select><option>test<option>test<option>test<option>test

The problem here is that we display the text as transparent but we don't display the text-shadow. This data URI also has the same issue on Chrome.

The testcase attached from a real site only applies this style for Firefox (using `@-moz-document url-prefix()`). On Chrome they just use a set `color`.

We can't simply remove the alpha component of the color, and effectively treat rgba(0,0,0,0) as rgb(0,0,0). The site will not be expecting black instead of transparent and the black text may be unreadable too.

One solution here would be to forward the text-shadow property, though I'm wary of the ever-expanding set of CSS properties we will need to support.

The other solution would be to let the site find that it no longer works and then they can update their site to remove the special Firefox styling. Though there could be a long tail of sites that will be broken and either won't update timely or will never update.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(jaws)
(Assignee)

Updated

8 months ago
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Comment 4

8 months ago
mozreview-review
Comment on attachment 8856679 [details]
Bug 1354196 - Forward the text-shadow CSS property to the select popup for styling.

https://reviewboard.mozilla.org/r/128620/#review131654
Attachment #8856679 - Flags: review?(dtownsend) → review+

Comment 5

8 months ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7545a6eab53b
Forward the text-shadow CSS property to the select popup for styling. r=mossop

Comment 6

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7545a6eab53b
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
status-firefox-esr52: --- → unaffected
Please request Aurora approval on this when you get a chance.
Flags: needinfo?(jaws)

Comment 8

7 months ago
Please request beta approval because FF 54 is beta now.
Comment on attachment 8856679 [details]
Bug 1354196 - Forward the text-shadow CSS property to the select popup for styling.

Approval Request Comment
[Feature/Bug causing the regression]: regression from bug 910022
[User impact if declined]: some <select> popups on websites may be unreadable
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no, automated test covers this
[List of other uplifts needed for the feature/fix]: yes, bug 1355078 should also be included in uplift
[Is the change risky?]: not expected
[Why is the change risky/not risky?]: The change is focused specifically on select dropdowns and is a very specific/focused fix.
[String changes made/needed]:
Flags: needinfo?(jaws)
Attachment #8856679 - Flags: approval-mozilla-beta?
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #9)
> [String changes made/needed]: none
Comment on attachment 8856679 [details]
Bug 1354196 - Forward the text-shadow CSS property to the select popup for styling.

Fix a select dropdown issue and include test. Beta54+. Should be in 54 beta 3.
Attachment #8856679 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 12

7 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/a50aaf501b39
status-firefox54: affected → fixed
(In reply to (Away 3 May - 5 May) Jared Wein [:jaws] (please needinfo? me) from comment #9)
> [Is this code covered by automated tests?]: yes
> [Has the fix been verified in Nightly?]: no
> [Needs manual test from QE? If yes, steps to reproduce]: no, automated test
> covers this

Setting qe-verify- based on Jared's assessment on manual testing needs and the fact that this fix has automated coverage.
Flags: qe-verify-
(Reporter)

Updated

10 days ago
Depends on: 1416733
You need to log in before you can comment on or make changes to this bug.