1355078 - [e10s] Open drop-down list leads to scroll to top the menu

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[blinky]

Steps to reproduce:

1. Go to https://onedrive.live.com/download?cid=F96BA52A2AF70D03&resid=F96BA52A2AF70D03%211230&authkey=APV6opUddR6eXic.
2. Open the <select> element.


Actual results:

Open drop-down list leads to scroll to top the menu.

Screenshot https://1drv.ms/i/s!AgMN9yoqpWv5iU8UcwBfI4uhku3i

Comment 1

[blinky]

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b35e46dc0604&tochange=cf051de0d37b

Regressed by: bug 1352963

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

This reduced testcase reproduces the problem,
data:text/html,<style>select { transition: all .2s linear; } select:focus { color: purple; }</style><select><option>test<option>test<option>test<option>test<option>test<option>test<option>test<option>test<option>test<option>test<option>test<option>test<option>test<option>test<option>test<option>test<option>test<option>test<option>test<option>test<option>test<option>test<option>test<option>test<option>test<option>test<option>test<option>test<option>test<option>test<option>test<option>test<option>test<option>test<option selected="true">test

It looks like the call to _update is not maintaining the scroll position.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1355078 - Restore scroll position after updating select popup.

Review commit: https://reviewboard.mozilla.org/r/128744/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128744/

Comment 4

[Marcia Knous [:marcia]]

Tracking 55+ for this form controls regression.

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 8856820 [details]
Bug 1355078 - Restore scroll position after updating select popup.

https://reviewboard.mozilla.org/r/128744/#review131650

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64ba6efd9722
Restore scroll position after updating select popup. r=mossop

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/64ba6efd9722

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8856820 [details]
Bug 1355078 - Restore scroll position after updating select popup.

Approval Request Comment
[Feature/Bug causing the regression]: regression from bug 910022
[User impact if declined]: long popups on websites will scroll away from the selected option on opening
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no, automated test covers this
[List of other uplifts needed for the feature/fix]: yes, bug 1354196 should also be included in uplift (this patch should apply on top of the patch from bug 1354196)
[Is the change risky?]: not expected
[Why is the change risky/not risky?]: The change is focused specifically on select dropdowns and is a very specific/focused fix.
[String changes made/needed]:

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #8)
> [String changes made/needed]: none

Comment 10

[Gerry Chang [:gchang]]

Comment on attachment 8856820 [details]
Bug 1355078 - Restore scroll position after updating select popup.

Fix a select dropdown issue and include test. Beta54+. Should be in 54 beta 3.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/db1d45543c1b

Comment 12

[Andrei Vaida [:avaida]]

(In reply to (Away 3 May - 5 May) Jared Wein [:jaws] (please needinfo? me) from comment #8)
> [Is this code covered by automated tests?]: yes
> [Has the fix been verified in Nightly?]: no
> [Needs manual test from QE? If yes, steps to reproduce]: no, automated test
> covers this

Setting qe-verify- based on Jared's assessment on manual testing needs and the fact that this fix has automated coverage.