Crash in mozilla::ipc::IPCResult::Fail

RESOLVED FIXED in Firefox 55

Status

()

--
critical
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: marcia, Assigned: sotaro)

Tracking

(Depends on: 1 bug, Blocks: 1 bug, {crash})

55 Branch
mozilla55
Unspecified
Windows 8
crash
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox53 unaffected, firefox54 unaffected, firefox55 fixed)

Details

(crash signature)

Attachments

(1 attachment)

This bug was filed from the Socorro interface and is 
report bp-b4bed85c-59c4-4786-882e-244162170324.
=============================================================

Seen while looking at crash stats - crashes started using 20170324030205 build: http://bit.ly/2nOSOrd

Possible regression range based on Build ID: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7513b3f42058e9bcf9950d4acf4647d4ad2240f0&tochange=01d1dedf400d4be413b1a0d48090dca7acf29637
This happens sometimes if I close tabs with Ctrl+W when webrender is enabled. Can't tell precise STR yet :/
(Assignee)

Updated

a year ago
Assignee: nobody → sotaro.ikeda.g
(Assignee)

Comment 2

a year ago
I could reproduce the crash with the following STR on my laptop.
[1] Open Many Tabs
[2] Close Tabs in sequence.
(Assignee)

Comment 3

a year ago
Implementation of WebRenderBridgeParent::RecvShutdown() seems wrong. IPC_FAIL_NO_REASON(this) is called after Send__delete__(this), but the  Send__delete__(this) could make this pointer invalid.
(Assignee)

Comment 4

a year ago
It seems better to change WebRenderBridgeParent::RecvShutdown() like LayerTransactionParent::RecvShutdown().
(Assignee)

Comment 5

a year ago
Created attachment 8868033 [details] [diff] [review]
patch - Fix WebRenderBridgeParent::RecvShutdown()
(Assignee)

Comment 6

a year ago
attachment 8868033 [details] [diff] [review] addressed the problem for me.
(Assignee)

Updated

a year ago
Blocks: 1311790
Depends on: 1360701
(Assignee)

Updated

a year ago
Attachment #8868033 - Attachment description: patch - WebRenderBridgeParent::RecvShutdown() → patch - Fix WebRenderBridgeParent::RecvShutdown()
(Assignee)

Updated

a year ago
Attachment #8868033 - Flags: review?(sotaro.ikeda.g)
(Assignee)

Updated

a year ago
Attachment #8868033 - Flags: review?(sotaro.ikeda.g) → review?(nical.bugzilla)
Comment on attachment 8868033 [details] [diff] [review]
patch - Fix WebRenderBridgeParent::RecvShutdown()

Review of attachment 8868033 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense.
Attachment #8868033 - Flags: review?(nical.bugzilla) → review+

Comment 8

a year ago
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/04109e4818e5
Fix WebRenderBridgeParent::RecvShutdown() r=nical
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
status-firefox53: --- → unaffected
status-firefox54: --- → unaffected
status-firefox55: affected → fixed
status-firefox-esr52: --- → unaffected
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.