1354198 - Crash in mozilla::ipc::IPCResult::Fail

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is 
report bp-b4bed85c-59c4-4786-882e-244162170324.
=============================================================

Seen while looking at crash stats - crashes started using 20170324030205 build: http://bit.ly/2nOSOrd

Possible regression range based on Build ID: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7513b3f42058e9bcf9950d4acf4647d4ad2240f0&tochange=01d1dedf400d4be413b1a0d48090dca7acf29637

Comment 1

[Darkspirit]

This happens sometimes if I close tabs with Ctrl+W when webrender is enabled. Can't tell precise STR yet :/

Comment 2

[Sotaro Ikeda [:sotaro]]

I could reproduce the crash with the following STR on my laptop.
[1] Open Many Tabs
[2] Close Tabs in sequence.

Comment 3

[Sotaro Ikeda [:sotaro]]

Implementation of WebRenderBridgeParent::RecvShutdown() seems wrong. IPC_FAIL_NO_REASON(this) is called after Send__delete__(this), but the  Send__delete__(this) could make this pointer invalid.

Comment 4

[Sotaro Ikeda [:sotaro]]

It seems better to change WebRenderBridgeParent::RecvShutdown() like LayerTransactionParent::RecvShutdown().

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fix WebRenderBridgeParent::RecvShutdown()

Comment 6

[Sotaro Ikeda [:sotaro]]

attachment 8868033 [details] [diff] [review] addressed the problem for me.

Comment 7

[Nicolas Silva [:nical]]

Comment on attachment 8868033 [details] [diff] [review]
patch - Fix WebRenderBridgeParent::RecvShutdown()

Review of attachment 8868033 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/04109e4818e5
Fix WebRenderBridgeParent::RecvShutdown() r=nical

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/04109e4818e5