Closed
Bug 1354409
Opened 7 years ago
Closed 7 years ago
Add new telemetry probe for stats about racing results distribution
Categories
(Core :: Networking: Cache, enhancement)
Core
Networking: Cache
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: CuveeHsu, Assigned: valentin)
References
(Blocks 1 open bug)
Details
(Whiteboard: [necko-active])
Attachments
(2 files)
To evaluate rcwn algorithm, we need new probe for a chart including - how many times network was faster when we raced immediately - how many times network was faster when we raced with a delay - how many times network was slower when we raced immediately - how many times network was slower when we raced with a delay
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8859415 [details] Bug 1354409 - Make sure nsHttpChannel::mRacingNetAndCache is only true when we are actually racing https://reviewboard.mozilla.org/r/131444/#review134124 ::: netwerk/protocol/http/nsHttpChannel.cpp:8854 (Diff revision 1) > LOG(("nsHttpChannel::MaybeRaceNetworkWithCache [this=%p]\n", this)); > + > + if (!mOnCacheAvailableCalled) { > + // If the network was triggered before onCacheEntryAvailable was > + // called, we are either racing network and cache, or the load is > + // bypassing the cache. This comment as well as the comment in header file need to be changed.
Attachment #8859415 -
Flags: review?(michal.novotny)
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
||
Comment 8•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8859415 [details] Bug 1354409 - Make sure nsHttpChannel::mRacingNetAndCache is only true when we are actually racing https://reviewboard.mozilla.org/r/131444/#review136904
Attachment #8859415 -
Flags: review?(michal.novotny) → review+
|
|
||
Comment 9•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8859414 [details] Bug 1354409 - Add telemetry for how often we race network and cache https://reviewboard.mozilla.org/r/131442/#review138040
Attachment #8859414 -
Flags: review?(michal.novotny) → review+
|
||
Comment 10•7 years ago
|
||
Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/f15be762532c Add telemetry for how often we race network and cache r=michal https://hg.mozilla.org/integration/autoland/rev/d08698232edf Make sure nsHttpChannel::mRacingNetAndCache is only true when we are actually racing r=michal
|
|
||
Comment 11•7 years ago
|
||
This will report kDidNotRaceUsedNetwork and kDidNotRaceUsedCache even if racing is disabled, but we should report the values only when racing is enabled. Could you please fix it here or file a follow up bug?
Flags: needinfo?(valentin.gosu)
|
||
Comment 12•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f15be762532c https://hg.mozilla.org/mozilla-central/rev/d08698232edf
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
Reporter | |
Comment 13•7 years ago
|
||
(In reply to Michal Novotny (:michal) from comment #11) > This will report kDidNotRaceUsedNetwork and kDidNotRaceUsedCache even if > racing is disabled, but we should report the values only when racing is > enabled. Could you please fix it here or file a follow up bug? I think I can fix it in bug 1354405 together.
|
Assignee | |
Comment 14•7 years ago
|
||
(In reply to Junior[:junior][ooo 5/11-16] from comment #13) > > enabled. Could you please fix it here or file a follow up bug? > I think I can fix it in bug 1354405 together. Thanks, Junior!
Flags: needinfo?(valentin.gosu)
You need to log in
before you can comment on or make changes to this bug.
Description
•