1354464 - Fix the size of webrender mask layer

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Ethan Lin[:ethlin]]

Currently we apply layer's transform to stacking context in WRXXXLayer, but the size of mask layer is transformed already. So the mask layer will be transformed twice.

Comment 1

[Ethan Lin[:ethlin]]

Attachment: fix mask size

I apply the inverse layer transform to mask. The patch will fix these reftests when enabling 'layers.advanced.canvas-background-color' or 'layers.advanced.image-layers':
layout/reftests/border-radius/clipping-4-image.html
layout/reftests/border-radius/clipping-5-image.html
layout/reftests/border-radius/clipping-5-refi.html
layout/reftests/border-radius/intersecting-clipping-1-image.html

Comment 2

[Ethan Lin[:ethlin]]

(In reply to Ethan Lin[:ethlin] from comment #1)
> Created attachment 8855703 [details] [diff] [review]
> fix mask size
> 
> I apply the inverse layer transform to mask. The patch will fix these
> reftests when enabling 'layers.advanced.canvas-background-color' or
> 'layers.advanced.image-layers':
> layout/reftests/border-radius/clipping-4-image.html
> layout/reftests/border-radius/clipping-5-image.html
> layout/reftests/border-radius/clipping-5-refi.html
> layout/reftests/border-radius/intersecting-clipping-1-image.html

This is the original result of these reftests: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/T6UmOnqKQyq2Z5vJ9-YosA/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

Comment 3

[Mason Chang [Inactive] [:mchang]]

Comment on attachment 8855703 [details] [diff] [review]
fix mask size

Review of attachment 8855703 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/wr/WebRenderLayerManager.cpp
@@ +112,5 @@
>  {
>    if (GetLayer()->GetMaskLayer()) {
>      WebRenderLayer* maskLayer = ToWebRenderLayer(GetLayer()->GetMaskLayer());
> +    gfx::Matrix4x4 transform = GetWrBoundTransform();
> +    return maskLayer->RenderMaskLayer(transform.Inverse());

nit: Instead of passing in the transform here. Can't we just do this in RenderMaskLayer instead?

Also add a comment explaining why we have to inverse this.

Comment 4

[Ethan Lin[:ethlin]]

(In reply to Mason Chang [:mchang] from comment #3)
> Comment on attachment 8855703 [details] [diff] [review]
> fix mask size
> 
> Review of attachment 8855703 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: gfx/layers/wr/WebRenderLayerManager.cpp
> @@ +112,5 @@
> >  {
> >    if (GetLayer()->GetMaskLayer()) {
> >      WebRenderLayer* maskLayer = ToWebRenderLayer(GetLayer()->GetMaskLayer());
> > +    gfx::Matrix4x4 transform = GetWrBoundTransform();
> > +    return maskLayer->RenderMaskLayer(transform.Inverse());
> 
> nit: Instead of passing in the transform here. Can't we just do this in
> RenderMaskLayer instead?
> 

Because I need the inverse transform of the original layer, but not the mask layer's transform. Or should I pass the original layer into RenderMaskLayer?

> Also add a comment explaining why we have to inverse this.

Okay, I will add a comment here.

Comment 5

[Ethan Lin[:ethlin]]

try result looks good:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b6b9f0e2f4116b01994e7e2c57dfe233b0c6a507

I would like to push the patch first. Bug 1355012 is about mask layer in WebRenderDisplayItemLayer and I may change the interface of WebRenderLayer::BuildWrMaskLayer in the bug.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/09534c0cda7c
Fix the size of webrender mask layer. r=mchang

Comment 7

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/09534c0cda7c