Closed
Bug 1354463
Opened 7 years ago
Closed 6 years ago
Enable 'layers.advanced.canvas-background-color' by default
Categories
(Core :: Graphics: WebRender, enhancement)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: ethlin, Assigned: mtseng)
References
Details
(Keywords: correctness)
Attachments
(4 files)
Current try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0d060b0e71ab0af490af736af2d4f6f2792aba30&selectedJob=89434187.
|
Reporter | |
Updated•7 years ago
|
Blocks: 1342343
Keywords: correctness
|
Assignee | |
Comment 1•7 years ago
|
||
Latest try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8646adc9d3fe3442755290d586cc3f808ed7a5a5
|
|
Reporter | |
Comment 2•6 years ago
|
||
current try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=847d2b8969d3edf2dda1449f2b773d35620c668b&selectedJob=100832168
Assignee: ethlin → mtseng
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 6•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6cbe0e10343ee535d02dca933f6a32f19a56bb1f
|
||
Comment 7•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8874773 [details] Bug 1354463 - Add fuzzy-if for tests. https://reviewboard.mozilla.org/r/146146/#review150126 Please change all of these fuzzy annotations to be ranges, e.g. fuzzy-if(webrender,15-15,1000-1000) so that if the fuzziness level drops we will find out and can tighten the bounds.
Attachment #8874773 -
Flags: review?(bugmail) → review+
|
|
||
Comment 8•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8874772 [details] Bug 1354463 - Set fails-if for opaque layer check fail. https://reviewboard.mozilla.org/r/146144/#review150130 Please make sure to update the webrender reftest spreadsheet with these and mark them as WONTFIX since the failures are expected.
Attachment #8874772 -
Flags: review?(bugmail) → review+
|
|
||
Comment 9•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8874771 [details] Bug 1354463 - Enable layers.advanced.canvas-background-color if webrender is enabled. https://reviewboard.mozilla.org/r/146142/#review150132
Attachment #8874771 -
Flags: review?(bugmail) → review+
|
|
||
Comment 10•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8874771 [details] Bug 1354463 - Enable layers.advanced.canvas-background-color if webrender is enabled. https://reviewboard.mozilla.org/r/146142/#review150134 Typo in commit message: first "is" should be "if"
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 14•6 years ago
|
||
Thanks for review. Try looks good. Here is try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bf54341ace7793a56239a0500836c7bc073ee343&group_state=expanded
|
||
Comment 15•6 years ago
|
||
Pushed by mtseng@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4ac4ad3ba687 Enable layers.advanced.canvas-background-color if webrender is enabled. r=kats https://hg.mozilla.org/integration/autoland/rev/16d73b417ed5 Set fails-if for opaque layer check fail. r=kats https://hg.mozilla.org/integration/autoland/rev/b884346aefbe Add fuzzy-if for tests. r=kats
|
|
||
Comment 16•6 years ago
|
||
Is there a reason you used ranges like 950-1000 instead of a more precise range? Also in some cases you had ranges starting at 0, like "fuzzy-if(webrender,0-1,0-600)" - is this an intermittent? The only reason we should have ranges like this is if the tests are nondeterministic, and if that's the case that worries me.
|
|
Assignee | |
Comment 17•6 years ago
|
||
Yap, I think precise range is better. I'll attach a patch for fixing this. And about fuzzy-if(webrender,0-1,0-600), it seems the different result in different configurations such as e10s v.s. non-e10s, debug v.s. opt...
|
|
Assignee | |
Comment 18•6 years ago
|
||
MozReview-Commit-ID: Cf0d2ZjCMHb
Attachment #8875586 -
Flags: review?(bugmail)
|
|
Assignee | |
Comment 19•6 years ago
|
||
Latest try. https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d75ed9ee81add1f764bb2e9c7a5c3ce0d1d50c9&selectedJob=105379180
|
|
Assignee | |
Comment 20•6 years ago
|
||
leave the bug open until follow-up patch landed.
Keywords: leave-open
|
|
||
Comment 21•6 years ago
|
||
Comment on attachment 8875586 [details] [diff] [review] Use precise range for fuzzy-if. Review of attachment 8875586 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, this is an improvement. I guess debug vs opt and e10s vs non-e10s is a valid reason to have a wider range. As long as we don't have a given configuration producing different values on each run (i.e. non-deterministic results)
Attachment #8875586 -
Flags: review?(bugmail) → review+
|
||
Comment 22•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4ac4ad3ba687 https://hg.mozilla.org/mozilla-central/rev/16d73b417ed5 https://hg.mozilla.org/mozilla-central/rev/b884346aefbe
|
|
||
Comment 23•6 years ago
|
||
Pushed by mtseng@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ad1958745d3f Use precise range for fuzzy-if. r=kats
|
|
Assignee | |
Updated•6 years ago
|
Keywords: leave-open
|
|
||
Comment 24•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ad1958745d3f
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•