Enable 'layers.advanced.canvas-background-color' by default

RESOLVED FIXED in Firefox 55

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ethlin, Assigned: mtseng)

Tracking

({correctness})

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(4 attachments)

Blocks: 1342343
Keywords: correctness
Depends on: 1354464
Depends on: 1355012
Depends on: 1357003
Depends on: 1365185
Depends on: 1367332
Depends on: 1367631
Comment on attachment 8874773 [details]
Bug 1354463 - Add fuzzy-if for tests.

https://reviewboard.mozilla.org/r/146146/#review150126

Please change all of these fuzzy annotations to be ranges, e.g. fuzzy-if(webrender,15-15,1000-1000) so that if the fuzziness level drops we will find out and can tighten the bounds.
Attachment #8874773 - Flags: review?(bugmail) → review+
Comment on attachment 8874772 [details]
Bug 1354463 - Set fails-if for opaque layer check fail.

https://reviewboard.mozilla.org/r/146144/#review150130

Please make sure to update the webrender reftest spreadsheet with these and mark them as WONTFIX since the failures are expected.
Attachment #8874772 - Flags: review?(bugmail) → review+
Comment on attachment 8874771 [details]
Bug 1354463 - Enable layers.advanced.canvas-background-color if webrender is enabled.

https://reviewboard.mozilla.org/r/146142/#review150132
Attachment #8874771 - Flags: review?(bugmail) → review+
Comment on attachment 8874771 [details]
Bug 1354463 - Enable layers.advanced.canvas-background-color if webrender is enabled.

https://reviewboard.mozilla.org/r/146142/#review150134

Typo in commit message: first "is" should be "if"
Pushed by mtseng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ac4ad3ba687
Enable layers.advanced.canvas-background-color if webrender is enabled. r=kats
https://hg.mozilla.org/integration/autoland/rev/16d73b417ed5
Set fails-if for opaque layer check fail. r=kats
https://hg.mozilla.org/integration/autoland/rev/b884346aefbe
Add fuzzy-if for tests. r=kats
Is there a reason you used ranges like 950-1000 instead of a more precise range? Also in some cases you had ranges starting at 0, like "fuzzy-if(webrender,0-1,0-600)" - is this an intermittent? The only reason we should have ranges like this is if the tests are nondeterministic, and if that's the case that worries me.
Yap, I think precise range is better. I'll attach a patch for fixing this. And about fuzzy-if(webrender,0-1,0-600), it seems the different result in different configurations such as e10s v.s. non-e10s, debug v.s. opt...
MozReview-Commit-ID: Cf0d2ZjCMHb
Attachment #8875586 - Flags: review?(bugmail)
leave the bug open until follow-up patch landed.
Keywords: leave-open
Comment on attachment 8875586 [details] [diff] [review]
Use precise range for fuzzy-if.

Review of attachment 8875586 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this is an improvement. I guess debug vs opt and e10s vs non-e10s is a valid reason to have a wider range. As long as we don't have a given configuration producing different values on each run (i.e. non-deterministic results)
Attachment #8875586 - Flags: review?(bugmail) → review+
https://hg.mozilla.org/mozilla-central/rev/ad1958745d3f
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.