1354512 - De-duplicate already ESLint recommended rules in browser/components/migration/.eslintrc.js

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Mark Banner (:standard8)]

We now have a recommend set of rules for ESLint in Mozilla, I'd like for us to tidy up duplicates, so that it is easier to see where modules/different areas are different.

This bug is to tidy up browser/components/migration/.eslintrc.js.

I'm happy to mentor this.

Recommended rules: https://dxr.mozilla.org/mozilla-central/source/tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js

What needs doing (all in the file browser/components/migration/.eslintrc.js):

- Remove the extends section, as this is unnecessary (ESLint inherits rules through the directory tree).
- For the rules, globals and env sections, go through each one and compare to the recommended, then:
-- If it is the same (with the same parameters), remove the rule
-- If it is commented, remove it
-- If it is different, leave it in.
- Finally check ESLint still runs correctly (./mach eslint) and passes with no errors (warnings are ok if they are the same as previous).

Once that's done, attach a patch and request review from me (Standard8)

Comment 1

[Dan Banner]

Attachment: Bug 1354512 - De-duplicate already ESLint recommended rules in browser/components/migration/.

Review commit: https://reviewboard.mozilla.org/r/129928/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129928/

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8857892 [details]
Bug 1354512 - De-duplicate already ESLint recommended rules in browser/components/migration/.

https://reviewboard.mozilla.org/r/129928/#review132514

Looking good, but there's a couple more items that can be cleaned up as well.

::: browser/components/migration/.eslintrc.js:5
(Diff revision 1)
> -  "extends": [
> -    "../../.eslintrc.js"
> -  ],
> -
>    "globals": {
>      "Components": true,

Components can also be removed.

::: browser/components/migration/.eslintrc.js:22
(Diff revision 1)
> -    "no-dupe-keys": "error",
> -    "no-duplicate-case": "error",
> -    "no-else-return": "error",
>      "no-eval": "error",
>      "no-extend-native": "error",
> -    // "no-extra-bind": "error",
> +    "no-extra-semi": "error",

"no-extra-semi" can also be removed.

Comment 3

[Dan Banner]

Comment on attachment 8857892 [details]
Bug 1354512 - De-duplicate already ESLint recommended rules in browser/components/migration/.

https://reviewboard.mozilla.org/r/129928/#review132514

finished

Comment 4

[Dan Banner]

Comment on attachment 8857892 [details]
Bug 1354512 - De-duplicate already ESLint recommended rules in browser/components/migration/.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129928/diff/1-2/

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8857892 [details]
Bug 1354512 - De-duplicate already ESLint recommended rules in browser/components/migration/.

https://reviewboard.mozilla.org/r/129928/#review132526

Looks great, thank you!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f03074fed187
De-duplicate already ESLint recommended rules in browser/components/migration/. r=standard8

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f03074fed187