Closed
Bug 1354715
Opened 6 years ago
Closed 5 years ago
Titlebar turns gray after dictionary lookup, if we're not drawing tabs in the title bar
Categories
(Core :: Widget: Cocoa, defect, P3)
Tracking
()
VERIFIED
FIXED
mozilla61
People
(Reporter: mstange, Assigned: mstange)
References
Details
(Keywords: regression, Whiteboard: tpi:+)
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
spohl
:
review+
gchang
:
approval-mozilla-aurora+
|
Details |
Steps to reproduce: 1. Enable the titlebar for the browser window by clicking the hamburger button, choosing Customize, and clicking the Title Bar button in the bottom left corner. 2. Go to a regular website with text. 3. Use three-finger-tap on your touchpad in order to show the dictionary. This makes the titlebar turn light gray.
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8855957 [details] Bug 1354715 - Restore the right background color. https://reviewboard.mozilla.org/r/127832/#review130696
Attachment #8855957 -
Flags: review?(spohl.mozilla.bugs) → review+
Updated•6 years ago
|
Priority: -- → P2
Whiteboard: tpi:+
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/43db947ee2fe Restore the right background color. r=spohl
![]() |
||
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/43db947ee2fe
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Comment 5•6 years ago
|
||
Seems like a pretty minor glitch. On the other hand, it's a one-liner. I guess we could consider backporting to 54?
status-firefox52:
--- → wontfix
status-firefox53:
--- → wontfix
status-firefox54:
--- → affected
status-firefox-esr52:
--- → wontfix
Flags: needinfo?(mstange)
Version: Trunk → 49 Branch
Assignee | ||
Comment 6•6 years ago
|
||
Comment on attachment 8855957 [details] Bug 1354715 - Restore the right background color. Absolutely. This code hasn't change since 49, so this patch should apply cleanly. Approval Request Comment [Feature/Bug causing the regression]: bug 1212527 [User impact if declined]: small visual glitch in a certain UI interaction [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: yes [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: n/a [Is the change risky?]: no [Why is the change risky/not risky?]: one-liner [String changes made/needed]: none
Flags: needinfo?(mstange)
Attachment #8855957 -
Flags: approval-mozilla-aurora?
Updated•6 years ago
|
Flags: qe-verify+
Comment 7•6 years ago
|
||
Comment on attachment 8855957 [details] Bug 1354715 - Restore the right background color. Fix a regression. Aurora54+.
Attachment #8855957 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment hidden (obsolete) |
Assignee | ||
Comment 9•6 years ago
|
||
This patch broke the dictionary popup completely. I don't know how I missed that.
Comment 10•6 years ago
|
||
backout |
Backed out for causing bug 1361103. https://hg.mozilla.org/integration/mozilla-inbound/rev/fa7165dda224 https://hg.mozilla.org/releases/mozilla-beta/rev/8b2286529068
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla55 → ---
Updated•6 years ago
|
status-firefox56:
--- → wontfix
status-firefox57:
--- → fix-optional
Comment 11•5 years ago
|
||
Moving to p3 because no activity for at least 1 year(s). See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information
Priority: P2 → P3
Assignee | ||
Comment 12•5 years ago
|
||
This was fixed by bug 1335191.
Status: REOPENED → RESOLVED
Closed: 6 years ago → 5 years ago
Depends on: 1335191
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•5 years ago
|
Updated•5 years ago
|
status-firefox-esr60:
--- → wontfix
Comment 13•5 years ago
|
||
Verified and the bug is not reproducible on latest FF 64.0.2 and latest Nightly 66.0a1(01.11.2019) on Mac OS X 10.13.
Status: RESOLVED → VERIFIED
status-firefox64:
--- → verified
status-firefox66:
--- → verified
Flags: qe-verify+
Updated•5 years ago
|
status-firefox65:
--- → ?
You need to log in
before you can comment on or make changes to this bug.
Description
•