1354715 - Titlebar turns gray after dictionary lookup, if we're not drawing tabs in the title bar

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect, P3)

Description

[Markus Stange [:mstange]]

Steps to reproduce:
 1. Enable the titlebar for the browser window by clicking the hamburger button, choosing Customize, and clicking the Title Bar button in the bottom left corner.
 2. Go to a regular website with text.
 3. Use three-finger-tap on your touchpad in order to show the dictionary.

This makes the titlebar turn light gray.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1354715 - Restore the right background color.

Review commit: https://reviewboard.mozilla.org/r/127832/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/127832/

Comment 2

[Stephen A Pohl [:spohl]]

Comment on attachment 8855957 [details]
Bug 1354715 - Restore the right background color.

https://reviewboard.mozilla.org/r/127832/#review130696

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/43db947ee2fe
Restore the right background color. r=spohl

Comment 4

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/43db947ee2fe

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Seems like a pretty minor glitch. On the other hand, it's a one-liner. I guess we could consider backporting to 54?

Comment 6

[Markus Stange [:mstange]]

Comment on attachment 8855957 [details]
Bug 1354715 - Restore the right background color.

Absolutely. This code hasn't change since 49, so this patch should apply cleanly.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1212527
[User impact if declined]: small visual glitch in a certain UI interaction
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: n/a
[Is the change risky?]: no
[Why is the change risky/not risky?]: one-liner
[String changes made/needed]: none

Comment 7

[Gerry Chang [:gchang]]

Comment on attachment 8855957 [details]
Bug 1354715 - Restore the right background color.

Fix a regression. Aurora54+.

Comment 8

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/105e456d811b

Comment 9

[Markus Stange [:mstange]]

This patch broke the dictionary popup completely. I don't know how I missed that.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Backed out for causing bug 1361103.

https://hg.mozilla.org/integration/mozilla-inbound/rev/fa7165dda224
https://hg.mozilla.org/releases/mozilla-beta/rev/8b2286529068

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 12

[Markus Stange [:mstange]]

This was fixed by bug 1335191.

Comment 13

[Brindusa Tot[:brindusat]]

Verified and the bug is not reproducible on latest FF 64.0.2 and latest Nightly 66.0a1(01.11.2019) on Mac OS X 10.13.