stylo: Properly support generated content for display: contents.

NEW
Unassigned

Status

()

Core
CSS Parsing and Computation
P2
normal
2 months ago
2 months ago

People

(Reporter: emilio, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 months ago
This is needed to pass layout/reftests/css-display/display-contents-generated-content.html
(Reporter)

Comment 1

2 months ago
Created attachment 8856220 [details]
test.html

Also, we don't force inline display for display: contents pseudo-elements, which means we get to this assertion[1] pretty easily. Testcase attached.

[1]: http://searchfox.org/mozilla-central/rev/c4fdb67bca7889e59af9dd99c604651a49c4aafa/layout/base/nsCSSFrameConstructor.cpp#4880
(Reporter)

Comment 2

2 months ago
(Note that we should respect display: contents in that case, I'll file a spec issue, but that's another matter)
(Reporter)

Comment 3

2 months ago
(In reply to Emilio Cobos Álvarez [:emilio] from comment #2)
> Note that we should respect display: contents in that case

 * IMO

Here's the display fixup that makes Gecko not hit the assert: http://searchfox.org/mozilla-central/rev/c4fdb67bca7889e59af9dd99c604651a49c4aafa/layout/style/nsRuleNode.cpp#6361
Priority: -- → P2
Blocks: 1243581
You need to log in before you can comment on or make changes to this bug.