Closed Bug 1354911 Opened 6 years ago Closed 6 years ago
Crash in java
.lang .Null Pointer Exception: Attempt to invoke interface method ''java .lang .String java .lang .Char Sequence .to String()'' on a null object reference at org .mozilla .gecko .Browser App .update Addon Menu Item(Browser App .java)
This bug was filed from the Socorro interface and is report bp-3b106b53-c0b6-4358-9bee-034482170408. ============================================================= This came from calixte's startup crash report - there was a spike detected in this signature as well as java.lang.NullPointerException: at org.mozilla.gecko.BrowserApp.updateAddonMenuItem(BrowserApp.java): http://bit.ly/2oVL8of Crashes were first seen using: 20170407075218 Possible regression ranged based on Build ID: https://hg.mozilla.org/releases/mozilla-aurora/pushloghtml?fromchange=f09f78db26a594b76139cee19a2487f9509d92ee&tochange=92ba21762445f89ae0691c4eab0746ca1cb819c2 This report from a user running a Nexus 6P has a comment which says: After recent version updates open loop crash upon open ni on snorp for help
-> timdream for frontend assignee Jim, do you think this is fallout from the event dispatcher changes?
Looks like it's the "Bluhell Firewall" addon that's causing the crash, because it uses an invalid name when adding a menu item, which we ignored previously.
(In reply to Jim Chen [:jchen] [:darchons] from comment #2) > Looks like it's the "Bluhell Firewall" addon that's causing the crash, > because it uses an invalid name when adding a menu item, which we ignored > previously. Based on the range and this comment, sounds like a fallout from your patch? Will you be able to get to it? Thanks.
Flags: needinfo?(timdream) → needinfo?(nchen)
Assignee: nobody → nchen
Status: NEW → ASSIGNED
This also affects beta and may turn out to be a bad issue on release. What patch do you think caused the problem? Must be something we uplifted for beta 11.
I only see this crash coming from installations with the "Bluhell Firewall" addon, which uses an invalid menu item name, so the impact should not be widespread. This simple patch fixes the issue.
Attachment #8858080 - Flags: review?(s.kaspari)
Tracking to keep an eye on this after 53 release. I'm not considering it a release blocker though.
Attachment #8858080 - Flags: review?(s.kaspari) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d64ffb5d7192 Guard against null menu item names; r=sebastian
Can we request uplift to beta 54 and release 53 ASAP? also, QA verification would be good
Comment on attachment 8858080 [details] [diff] [review] Guard again null menu item names (v1) Approval Request Comment [Feature/Bug causing the regression]: Bug 1321418 [User impact if declined]: Crash when using "Bluhell Firewall" add-on (and possibly other add-ons). [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: Small patch that only serves to avoid the crash. [String changes made/needed]: None
Attachment #8858080 - Flags: approval-mozilla-aurora? → approval-mozilla-release?
Comment on attachment 8858080 [details] [diff] [review] Guard again null menu item names (v1) Fix a crash. Beta54+. Should be in 54 beta 1.
Attachment #8858080 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
pushed: https://hg.mozilla.org/releases/mozilla-beta/rev/9a10a8b7cf4f - Jim Chen - Bug 1354911 - Guard against null menu item names; r=sebastian. a=gchang
30K crashes in Firefox 53 last week with this signature. We should uplift this to release in preparation for a dot release.
Comment on attachment 8858080 [details] [diff] [review] Guard again null menu item names (v1) Let's land this on m-r and verify it there too.
Attachment #8858080 - Flags: approval-mozilla-release? → approval-mozilla-release+
Devices: - LG G4 (Android 5.1.1); - Honor 8 (Android 6.0); - HTC 10 (Android 7.0); - Asus ZenPad 8 (Android 6.0.1). Build: 53.0.1 (Build 2) Based on Comment 2, I've verified this issue by disabling/enabling, opening and closing Firefox with the BluHell addon installed and everything seems to be fine, Firefox did not crash when initially installing the addon, all of the pages load correctly and none of the devices I've tested on have crashed.
You need to log in before you can comment on or make changes to this bug.