Minor string change in updateRestart.header.message

RESOLVED FIXED in Firefox 55

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bram, Assigned: dthayer)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

2 years ago
As a followup to bug 893505 comment 214, we’d like to change the string of updateRestart.header.message slightly.

From:
"Restart &brandShorterName; to apply update."

To:
"Restart &brandShorterName; to apply the update."

Thanks :flod for pointing out this issue!
Feel free to land the change without updating the string ID. The meaning is clear enough for anyone who localized the original landing.
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings
Comment hidden (mozreview-request)
Comment on attachment 8856614 [details]
Bug 1354949 - Add 'the' to updateRestart message

https://reviewboard.mozilla.org/r/128570/#review130980
Attachment #8856614 - Flags: review?(robert.strong.bugs) → review+

Comment 4

2 years ago
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/28813897761c
Add 'the' to updateRestart message r=rstrong
Assignee

Updated

2 years ago
Assignee: nobody → dothayer

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/28813897761c
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Assignee

Comment 6

2 years ago
I just encountered this in the wild and realized it sounded a little weird. "Restart &brandShorterName; to apply _the_ update" makes it sound like I've already been told about this update, which I haven't. I think this should probably be "Restart &brandShorterName; to apply _an_ update".

Thoughts Bram?
Flags: needinfo?(bram)
Reporter

Comment 7

2 years ago
(In reply to Doug Thayer [:dthayer] from comment #6)
> I just encountered this in the wild and realized it sounded a little weird.
> "Restart &brandShorterName; to apply _the_ update" makes it sound like I've
> already been told about this update, which I haven't. I think this should
> probably be "Restart &brandShorterName; to apply _an_ update".
> 
> Thoughts Bram?

Sorry I had missed responding to this request.

What about “Restart &brandShorterName; to finish updating”?
Flags: needinfo?(bram)
Reporter

Updated

2 years ago
Flags: needinfo?(dothayer)
Would “Restart &brandShorterName; to update”? Some locales can have long strings and this would be less likely to extend beyond one line.
Reporter

Comment 9

2 years ago
(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #8)
> Would “Restart &brandShorterName; to update”?

Yes. Shorter would be better.

Just a small reordering of word will make this a bit clearer: “Restart to update &brandShorterName”.

We also have a button label on “About Firefox” that says “Restart &brandShorterName to update”. When we’re updating our string on the doorhanger, we should also update the button label on this window, so it stays consistent.

What do you think?
Doug, if you think the above would be a good change please file a new bug. Since some locales have likely already localized please use new names for the entities.
Assignee

Comment 12

2 years ago
Created Bug 1359128
Flags: needinfo?(dothayer)
You need to log in before you can comment on or make changes to this bug.