1354949 - Minor string change in updateRestart.header.message

Status: RESOLVED FIXED

(Toolkit :: Application Update, enhancement)

Description

[Bram Pitoyo [:bram]]

As a followup to bug 893505 comment 214, we’d like to change the string of updateRestart.header.message slightly.

From:
"Restart &brandShorterName; to apply update."

To:
"Restart &brandShorterName; to apply the update."

Thanks :flod for pointing out this issue!

Comment 1

[Francesco Lodolo [:flod]]

Feel free to land the change without updating the string ID. The meaning is clear enough for anyone who localized the original landing.
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings

Comment 2

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1354949 - Add 'the' to updateRestart message

Review commit: https://reviewboard.mozilla.org/r/128570/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128570/

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 8856614 [details]
Bug 1354949 - Add 'the' to updateRestart message

https://reviewboard.mozilla.org/r/128570/#review130980

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28813897761c
Add 'the' to updateRestart message r=rstrong

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/28813897761c

Comment 6

[Alex Thayer [:alexical] (she/her)]

I just encountered this in the wild and realized it sounded a little weird. "Restart &brandShorterName; to apply _the_ update" makes it sound like I've already been told about this update, which I haven't. I think this should probably be "Restart &brandShorterName; to apply _an_ update".

Thoughts Bram?

Comment 7

[Bram Pitoyo [:bram]]

(In reply to Doug Thayer [:dthayer] from comment #6)
> I just encountered this in the wild and realized it sounded a little weird.
> "Restart &brandShorterName; to apply _the_ update" makes it sound like I've
> already been told about this update, which I haven't. I think this should
> probably be "Restart &brandShorterName; to apply _an_ update".
> 
> Thoughts Bram?

Sorry I had missed responding to this request.

What about “Restart &brandShorterName; to finish updating”?

Comment 8

[Robert Strong (they/them - no direct email)]

Would “Restart &brandShorterName; to update”? Some locales can have long strings and this would be less likely to extend beyond one line.

Comment 9

[Bram Pitoyo [:bram]]

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #8)
> Would “Restart &brandShorterName; to update”?

Yes. Shorter would be better.

Just a small reordering of word will make this a bit clearer: “Restart to update &brandShorterName”.

We also have a button label on “About Firefox” that says “Restart &brandShorterName to update”. When we’re updating our string on the doorhanger, we should also update the button label on this window, so it stays consistent.

What do you think?

Comment 10

[Robert Strong (they/them - no direct email)]

That sounds fine to me and thanks!

Comment 11

[Robert Strong (they/them - no direct email)]

Doug, if you think the above would be a good change please file a new bug. Since some locales have likely already localized please use new names for the entities.

Comment 12

[Alex Thayer [:alexical] (she/her)]

Created Bug 1359128