See https://bugzilla.mozilla.org/show_bug.cgi?id=1354949#c9 "Restart &brandShorterName; to apply the update" should be changed to "Restart to update &brandShorterName;". This should also adjust the restart copy in the About Firefox page.
2 years ago
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
I had to do a merge to oak anyways so I pushed this to oak https://treeherder.mozilla.org/#/jobs?repo=oak&tochange=abfd5166beb682704e28b8a35eb0c5031c8d9e2f&fromchange=abfd5166beb682704e28b8a35eb0c5031c8d9e2f
Comment on attachment 8861181 [details] [diff] [review] patch rev1 Had a typo
Attachment #8861181 - Attachment is obsolete: true
Also pushed to oak - changeset 211c85c0c2fa https://treeherder.mozilla.org/#/jobs?repo=oak
Comment on attachment 8861194 [details] [diff] [review] patch rev2 Gijs, could I get you to review this string change? Thanks!
Attachment #8861194 - Flags: review?(gijskruitbosch+bugs)
2 years ago
Attachment #8861194 - Flags: review?(gijskruitbosch+bugs) → review+
Changed the about dialog to use brandShorterName which I didn't know had been added. Carrying forward review
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/75df1d888f8b Change restart string in new app update UI and in the about window to 'Restart to update &brandShorterName;'. r=Gijs
Hrmpf, should have noticed this in review, but wasn't this also supposed to update the notification at the top of the hamburger panel? That's been kept the same so now that is still: <!ENTITY updateRestart.panelUI.label "Restart &brandShorterName; to apply the update">
Agreed, I'll file a new bug later today.
(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #9) > Agreed, I'll file a new bug later today. I think this fell through the cracks, and this is related to other work I'm doing ( bug 1355020) so I filed bug 1361358 myself just now.
You need to log in before you can comment on or make changes to this bug.