Closed Bug 1359128 Opened 6 years ago Closed 6 years ago

Change restart copy in new UI to "Restart to update &brandShorterName;"

Categories

(Toolkit :: Application Update, defect)

Product:
Toolkit
Component:
Application Update
Version:
55 Branch
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: dthayer, Assigned: robert.strong.bugs)

References

Details

Attachments

(1 file, 2 obsolete files)

patch for landing
5.32 KB, patch
robert.strong.bugs
: review+
Details | Diff | Splinter Review 
See https://bugzilla.mozilla.org/show_bug.cgi?id=1354949#c9

"Restart &brandShorterName; to apply the update" should be changed to "Restart to update &brandShorterName;".

This should also adjust the restart copy in the About Firefox page.
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
Comment on attachment 8861181 [details] [diff] [review]
patch rev1

Had a typo
Attachment #8861181 - Attachment is obsolete: true
Attached patch patch rev2 (obsolete) — — Splinter Review 
Also pushed to oak - changeset 211c85c0c2fa
https://treeherder.mozilla.org/#/jobs?repo=oak
Comment on attachment 8861194 [details] [diff] [review]
patch rev2

Gijs, could I get you to review this string change? Thanks!
Attachment #8861194 - Flags: review?(gijskruitbosch+bugs)
Attachment #8861194 - Flags: review?(gijskruitbosch+bugs) → review+
Changed the about dialog to use brandShorterName which I didn't know had been added. Carrying forward review
Attachment #8861194 - Attachment is obsolete: true
Attachment #8861619 - Flags: review+
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/75df1d888f8b
Change restart string in new app update UI and in the about window to 'Restart to update &brandShorterName;'. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/75df1d888f8b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Hrmpf, should have noticed this in review, but wasn't this also supposed to update the notification at the top of the hamburger panel? That's been kept the same so now that is still:

<!ENTITY updateRestart.panelUI.label "Restart &brandShorterName; to apply the update">
Flags: needinfo?(robert.strong.bugs)
Agreed, I'll file a new bug later today.
Flags: needinfo?(robert.strong.bugs)
Blocks: 1361358
(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #9)
> Agreed, I'll file a new bug later today.

I think this fell through the cracks, and this is related to other work I'm doing ( bug 1355020) so I filed bug 1361358 myself just now.
You need to log in before you can comment on or make changes to this bug.