Closed Bug 1354975 Opened 3 years ago Closed 3 years ago

stylo: Calling nsIFrame::AttributeChanged() in ServoRestyleManager::AttributeChanged()

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

References

Details

Attachments

(1 file)

GeckoRestyleManager::AttributeChanged() calls nsIFrame::AttributeChanged() in [1], but ServoRestyleManager doesn't do the same.  By doing so, we can fix some tests in stylo [2].

This also help fixes the scrollbar (bug 1321769) because nsSliderFrame::AttributeChanged() need to do some work.

[1] http://searchfox.org/mozilla-central/source/layout/base/GeckoRestyleManager.cpp#315
[2] https://treeherder.mozilla.org/#/jobs?repo=try&revision=22ee541973d49a13077a9e4d970179372499d202
Summary: Calling nsIFrame::AttributeChanged() in ServoRestyleManager::AttributeChanged() → stylo: Calling nsIFrame::AttributeChanged() in ServoRestyleManager::AttributeChanged()
Comment on attachment 8856342 [details]
Bug 1354975 - Let the frame handles attribute change in ServoRestyleManager::AttributeChanged().

https://reviewboard.mozilla.org/r/128248/#review130774

Nice find!  I see that GeckoRestyleManager::AttributeChanged also does some checking for themed widget stuff, just before where it calls nsIFrame::AttributeChanged.  We probably need to do that -- can you file a bug for that?
Attachment #8856342 - Flags: review?(cam) → review+
Pushed by tlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/be9680762d61
Let the frame handles attribute change in ServoRestyleManager::AttributeChanged(). r=heycam
Re comment 2:

> Nice find!  I see that GeckoRestyleManager::AttributeChanged also does some
> checking for themed widget stuff, just before where it calls
> nsIFrame::AttributeChanged.  We probably need to do that -- can you file a
> bug for that?

Filed bug 1354990.

For the record, this is the try run of the patch on the mozreview.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac8e5597e6912ceb6f10921b63176016961eaa8b
https://hg.mozilla.org/mozilla-central/rev/be9680762d61
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.