1354996 - Completely empty line + empty quotation line added below quotation

Status: RESOLVED DUPLICATE of bug 1354862

(SeaMonkey :: Composer, defect)

Description

[Rainer Bielefeld]

Steps how to reproduce  NOT reproducible REPRODUCIBLE with unzipped installer of  official  en-US SeaMonkey 2.52a1 (NT 6.1; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0 Build 20170406002917  (Default Classic Theme) on German WIN7 64bit:

0. Launch SM Email client → For account if necessary change 'Edit → 
   Preferences → Mail & NG → Composition - Default composition format =
   Paragraph (Enter key creates new paragraph)'
1. 'Edit → Mail & NG Preferences → Select your account - Composition 
    and Adressing →  Uncheck "Compose HTML" (if necessary) - Check 
    "Quote automatically, start my reply belos quote"'
2. In NG "mozilla.test" in Thread Paned select _first_  posting of 
   "Rainer Bielefeld" with summary "Empty lines disappear" →  [Reply]
   » Quotation appears, Caret flashes behine "Rainer"
   Bug: Below text of quoted message an additional line which is
       completely empty and an additional line  only with 
       Quotation "> " have been added

a) first observation of this effect I read in
   "Bug 1354931 - inconsistencies with cursor and new lines in reply 
   window" #2

Comment 1

[Rainer Bielefeld]

b) I did not find obvious DUPs in <https://bugzilla.mozilla.org/buglist.cgi?cmdtype=dorem&remaction=run&namedcmd=DUPs1354996&sharer_id=41036>

Comment 2

[Rainer Bielefeld]

c) There is a variant of this issue:
   If you Reply to my posting 4/9/17, 6:34 PM +0200 which only contains word
   "Hello" below quotet contents, you will only see a completely empty line
   above quoted "Hello"

Comment 3

[Rainer Bielefeld]

d) This one seems to have appeared with the same code change (or at least nearby
   simultaneously with "Bug 1354862 - Port bug 1353326: Do not insert leading
   blank lines before Quotation if Signature is added automatically to Reply"
d1) But this one is not related to "Automatically add Signature", so I do
    not think that this one is 100% DUP

@Hartmut:
Can you confirm behavior and version range?

Comment 4

[K Chayka]

I reported bug 1354931 and I'm not certain the sig itself is related. In either case, the compose window does not insert (either the sig or a blank line) following the last line of quoted text, but between the last 2 lines, i.e.:

> quoted text| ← insert point at the |
> last line of quoted text (may be a blank line or not)

The cursor placement IS different depending on whether there is a sig or not.

Without a sig, the flashing cursor can be seen at the insert point indicated, but type any character and it shows on the blank line that was inserted between the last 2 lines of quoted text.

With a sig, there is no flashing cursor at all, but the cursor is at the top of the compose window, where 2 extra blank lines were added unexpectedly. Type any character and it is placed in the first position of the first line in the compose window.

Comment 5

[Hartmut Figge]

There is another step required in the STR.

1.b. Make sure that no signature is attached

The regression range is the same as for Bug 1354862
Last good: 2017-04-03 20:53:00 PDT   c-c:754fbc931bbb m-c:b5d8b27a7537
First bad: 2017-04-04 17:37:00 PDT   c-c:b08dc613a3d2 m-c:b043233ec04f

The problem does not appear in a Build with the proposed patch try1 of Bug 1354862. It's reasonable to assume that's the same bug.

Comment 6

[Rainer Bielefeld]

Attachment: Screenshot shows Reply to Posting with signature

(In reply to Hartmut Figge from comment #5)
> 1.b. Make sure that no signature is attached

I am not sure whether I understand that objection.

I tried with a Posting with Signature: mozilla.test, WaltS78, "Re: Empty lines disappear", 1/10/17, 8:09 AM -0500 (contains "Visit Pittsburgh" Sig.). 
With my STR I see the reported problem, and it does not matter whether my reply becomes attached a sig. (from a text file).

Possibly additional conditions?

Comment 7

[Rainer Bielefeld]

Reproducible due to Comment 5, but still possibly unknown dependencies?

Comment 8

[Hartmut Figge]

(In reply to Rainer Bielefeld from comment #6)
> Created attachment 8856590 [details]
> Screenshot shows Reply to Posting with signature
> 
> (In reply to Hartmut Figge from comment #5)
> > 1.b. Make sure that no signature is attached
> 
> I am not sure whether I understand that objection.

It doesn't matter if the posting you replies to has a signature. But it *does* matter if your own signature is appended to your reply. You only get

| Quotation appears, Caret flashes behine "Rainer"

if you have no own signature. Can be set under the condition in step 1. of your STR. Hence my 1.b. :)

Your screenshot shows that for this reply you used an own signature. Can be seen by the two leading empty lines in the compose window. Corresponds to my own STR for Bug 1354862.

As for the regression range, there doesn't exist official Nightlys to determine them. They stem from the archive of my own builds.

Comment 9

[Rainer Bielefeld]

Comment 5 makes me sure that this one is a DUP of "Bug 1354862 - Port bug 1353326: Do not insert leading blank lines before Quotation if Signature is added automatically to Reply"