1354862 - Port bug 1353326: Do not insert leading blank lines before Quotation if Signature is added automatically to Reply

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Composition, defect)

Description

[Hartmut Figge]

After experiencing highly irritationg behaviour while replying, in the compose window and in the result after sending, I had to look for the reason. It was

The first bad revision is:
changeset:   351159:21eac8bd0645
user:        Aryeh Gregor <[e-mail]>
date:        Wed Aug 24 16:34:14 2016 +0300
summary:     Bug 1297414 - Change default paragraph separator to <div>; r=masayuki

TB apparently solved the issue in Bug 1353326 by modifying mail/components/compose/content/MsgComposeCommands.js. SM probably should port that to suite/mailnews/compose/MsgComposeCommands.js.

The files differ too much for me even to try to do so. Until a patch is available I will backout 21eac8bd0645 for my own private builds.

Comment 1

[Rainer Bielefeld]

What is the problem (visible fur users) behind the reported issue?

Comment 2

[Hartmut Figge]

When replying to a message, sometimes there are empty lines where there should be none. Sometimes you have to press Enter twice to get an empty line. When you are satisfied with the text in the compose window, after sending you most probably get a nasty surprise.

Missing empty lines or getting more of them. :-) I would have waited for a solution, but I couldn't bear it any longer.

Comment 3

[WaltS48 [:walts48]]

I made a couple test posts in the mozilla.test group using my SeaMonkey 2.46.

https://groups.google.com/forum/?fromgroups#!topic/mozilla.test/6SB8MKeLrNs

Comment 4

[Rainer Bielefeld]

(In reply to WaltS48 from comment #3)
Tells me nothing. Please tell the visible problem here in the public bug tracking system, at least link to a single posting containing a description of the problem. The other linked Bugs also only contain developer-gibbering, which can't be understood by a user. 

Is the report concerning the empty lines below quotation disappear "Bug 1329724 - In Reply empty lines below cut off quote in email body disappear"?

Comment 5

[WaltS48 [:walts48]]

Message text using plain text in my SeaMonkey 2.46 on Ubuntu 16.04 LTS

Hartmut Figge wrote:
> Hartmut Figge:
>> Hartmut Figge:
>
>>> Hartmut, yet hesitating hunting new bugs. They could go away by itself. :)
>>
>> Hmpf. This time I thought I had made sure there would be an empty line
>> before the quotation. Oh well.
>
> https://bugzilla.mozilla.org/show_bug.cgi?id=1354862
>
> Hartmut
>
Line spacing test. No attempt made to provide an empty line.

Link to post. https://groups.google.com/d/msg/mozilla.test/6SB8MKeLrNs/YcIN46zVBQAJ

You may have to click the "Hide Quoted text" link.

Comment 6

[Rainer Bielefeld]

(In reply to WaltS48 from comment #5)
This tells nothing without step by step instruction how to reproduce the bug.

Comment 7

[Hartmut Figge]

STR:

1) Get the latest available SM-Nightly. For Linux x86_64 the one from 20170405 suffices. It is just above the regression window.

2) Create a text file with a single line. In my case a file which contains only the word Hartmut.

3) Set this file as signature for the account to be tested, e.g. news.mozilla.org.

4) Try to reply to message, e.g. one from mozilla.test

You will see two leading empty lines in the compose window

Comment 8

[Hartmut Figge]

Attachment: try1

That is C&P of the fix from bug 1353326. Works also for my SM. Don't know why, though. ;)

Comment 9

[Hartmut Figge]

Comment on attachment 8856357 [details] [diff] [review]
try1

>diff -pru8 src/suite/mailnews/compose/MsgComposeCommands.js /home/hafi/moz-work/src/suite/mailnews/compose/MsgComposeCommands.js
>--- src/suite/mailnews/compose/MsgComposeCommands.js	2017-03-22 00:06:42.518971088 +0100
>+++ /home/hafi/moz-work/src/suite/mailnews/compose/MsgComposeCommands.js	2017-04-10 07:33:33.349222774 +0200
>@@ -3085,16 +3085,19 @@ function InitEditor(editor)
>   var eEditorMailMask = Components.interfaces.nsIPlaintextEditor.eEditorMailMask;
>   editor.flags |= eEditorMailMask;
>   GetMsgSubjectElement().editor.flags |= eEditorMailMask;
> 
>   // Control insertion of line breaks.
>   editor.returnInParagraphCreatesNewParagraph =
>     Services.prefs.getBoolPref("mail.compose.default_to_paragraph") ||
>     Services.prefs.getBoolPref("editor.CR_creates_new_p");
>+  // Traditionally we want <br> elements for newlines, unless we're
>+  // splitting a paragraph (which is not affected by this setting).
>+  editor.document.execCommand("defaultparagraphseparator", false, "br");
> 
>   gMsgCompose.initEditor(editor, window.content);
>   InlineSpellCheckerUI.init(editor);
>   EnableInlineSpellCheck(getPref("mail.spellcheck.inline"));
>   document.getElementById("menu_inlineSpellCheck").setAttribute("disabled", !InlineSpellCheckerUI.canSpellCheck);
> 
>   // Listen for spellchecker changes, set the document language to the
>   // dictionary picked by the user via the right-click menu in the editor.

Comment 10

[Hartmut Figge]

What a mess. Forget about Comment 9. That is the result of trying to change text/x-patch to a real patch. Sorry.

Comment 12

[Frank-Rainer Grahl (:frg)]

Could you do a proper patch including header with comment and ask me for review. I wanted to test if this works in SeaMonkey over the weekend but you already put up a bug and did so no need :)

Comment 13

[Hartmut Figge]

(In reply to Frank-Rainer Grahl from comment #12)
> Could you do a proper patch including header with comment and ask me for
> review. I wanted to test if this works in SeaMonkey over the weekend but you
> already put up a bug and did so no need :)

Um. Proper patch, meaning a hg-patch. Well, *if* I use Mercurial then 'hg export' to generate a proper patch usable for me. *g* So I'm not familiar enough with Mercurial to generate a hg-patch.

I propose we handle this in same way it was done for former patches of me. I request a review for my patch and the someone who does the checkin does so with a proper formated hg-version.

Comment 14

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8856357 [details] [diff] [review]
try1

r+ but it would be nice if you could set up hg correctly. Doesn't take much to do it and just mail me if you have problems with it.
I or any reviewer can spend the time for reformatting better on something else.

Comment 15

[Frank-Rainer Grahl (:frg)]

Attachment: 1354862-blanks.patch

Reformatted patch for reference only.

Comment 16

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/comm-central/rev/b70577e40f7dd1fe5ec6657164c560ea6b3af0f4

Comment 17

[Rainer Bielefeld]

VERIFIED (forWIN7) due to NG "mozilla.test", Subject "Test for 'Bug 1354862 - Port bug 1353326: Do not insert leading blank lines before Quotation if Signature is added automatically to Reply' (was: Re: Empty lines disappear)"" by Rainer Bielefeld 2017-04-25 9:05 AM +0200