1354998 - stylo: Implement glue for contain property

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P1)

Description

[Xidorn Quan [:xidorn] UTC+10]

contain property parsing and serialization has been implemented in Servo, but the glue code has not.

Also, contain needs to be an early property in cascading, because it may affect display property.

Comment 1

[Bobby Holley (:bholley)]

Nazim can you take this one?

Comment 2

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Sure!

Comment 3

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Opened: https://github.com/servo/servo/pull/16467

Comment 4

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1354998 - stylo: Update test expectations for contain property

Review commit: https://reviewboard.mozilla.org/r/132636/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132636/

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8860688 [details]
Bug 1354998 - stylo: Update test expectations for contain property

https://reviewboard.mozilla.org/r/132636/#review135484

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9b43cca451c
stylo: Update test expectations for contain property r=emilio

Comment 7

[Hiroyuki Ikezoe (:hiro)]

After landing Emilio's fix [1] three tests still have failed. We should skip them until bug 1321769. I will prepare to push modifications for it.
 
[1] https://hg.mozilla.org/integration/autoland/rev/8a931bd418b78ac6d341279ae6301d258de41d55

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/733cc845ad0f
Update reftest expectations for contain property. r=me

Comment 9

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/a9b43cca451c
https://hg.mozilla.org/mozilla-central/rev/733cc845ad0f