1355005 - stylo: Support -moz-box-orient: {block,inline}-axis

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P1)

Description

[Xidorn Quan [:xidorn] UTC+10]

Currently only horizontal and vertical are implemented, however it should also support {block,inline}-axis (and actually inline-axis is the initial value).

Related file is https://github.com/servo/servo/blob/master/components/style/properties/longhand/xul.mako.rs

Comment 1

[Chih-Hsuan Kuo [:tommykuo]]

In layout/style/nsCSSProps.cpp, we only have StyleBoxOrient::Horizontal and StyleBoxOrient::Vertical. Gecko maps inline-axis to Horizontal and block-axis to Vertical.
```
{ eCSSKeyword_horizontal, StyleBoxOrient::Horizontal },
{ eCSSKeyword_vertical, StyleBoxOrient::Vertical },
{ eCSSKeyword_inline_axis, StyleBoxOrient::Horizontal },
{ eCSSKeyword_block_axis, StyleBoxOrient::Vertical },
```

Is there similar way to map two keywords to the same value in servo?

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

You probably would not be able to use the single_keyword helper, and have to expand it to helpers::longhand. You may just use define_css_keyword_enum macro twice for ComputedValue and SpecifiedValue separately.

Comment 3

[Chih-Hsuan Kuo [:tommykuo]]

Attachment: Bug 1355005 - Add `inline-axis` and `block-axis` aliases for `-moz-box-orient`.

In Gecko, `inline-axis` and `horizonral` are both mapping to
`StyleBoxOrient::Horizontal`. And `block-axis` and `vertical` are both
mapping to `StyleBoxOrient::Vertical`. helpers.single_keyword() cannot
map two values to one value. So, we expand helpers.single_keyword()
to helpers.longhand() and implement the glue by manually.

Review commit: https://reviewboard.mozilla.org/r/131474/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131474/

Comment 4

[Chih-Hsuan Kuo [:tommykuo]]

Attachment: Bug 1355005 - Remove the failures mark of `box-orient` in stylo-failures.md.

Review commit: https://reviewboard.mozilla.org/r/131476/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131476/

Comment 5

[Chih-Hsuan Kuo [:tommykuo]]

Comment on attachment 8859437 [details]
Bug 1355005 - Add `inline-axis` and `block-axis` aliases for `-moz-box-orient`.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131474/diff/1-2/

Comment 6

[Chih-Hsuan Kuo [:tommykuo]]

Comment on attachment 8859438 [details]
Bug 1355005 - Remove the failures mark of `box-orient` in stylo-failures.md.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131476/diff/1-2/

Comment 7

[Chih-Hsuan Kuo [:tommykuo]]

Comment on attachment 8859437 [details]
Bug 1355005 - Add `inline-axis` and `block-axis` aliases for `-moz-box-orient`.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131474/diff/2-3/

Comment 8

[Chih-Hsuan Kuo [:tommykuo]]

Comment on attachment 8859438 [details]
Bug 1355005 - Remove the failures mark of `box-orient` in stylo-failures.md.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131476/diff/2-3/

Comment 9

[Chih-Hsuan Kuo [:tommykuo]]

Comment on attachment 8859437 [details]
Bug 1355005 - Add `inline-axis` and `block-axis` aliases for `-moz-box-orient`.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131474/diff/3-4/

Comment 10

[Chih-Hsuan Kuo [:tommykuo]]

Comment on attachment 8859438 [details]
Bug 1355005 - Remove the failures mark of `box-orient` in stylo-failures.md.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131476/diff/3-4/

Comment 11

[Chih-Hsuan Kuo [:tommykuo]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ce502d8408e55cc5008cc478d8423c8fb316622

Comment 12

[Chih-Hsuan Kuo [:tommykuo]]

Comment on attachment 8859437 [details]
Bug 1355005 - Add `inline-axis` and `block-axis` aliases for `-moz-box-orient`.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131474/diff/4-5/

Comment 13

[Chih-Hsuan Kuo [:tommykuo]]

Comment on attachment 8859438 [details]
Bug 1355005 - Remove the failures mark of `box-orient` in stylo-failures.md.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131476/diff/4-5/

Comment 14

[Chih-Hsuan Kuo [:tommykuo]]

heycam, you can review the patches now! I already updated with `extra_gecko_alias`.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1121f2f16a5724e11d2fc6afa22a4eeeddc9545d

Comment 15

[Cameron McCormack (:heycam)]

Comment on attachment 8859437 [details]
Bug 1355005 - Add `inline-axis` and `block-axis` aliases for `-moz-box-orient`.

https://reviewboard.mozilla.org/r/131474/#review134362

Nice, saves a lot of code!

Comment 16

[Cameron McCormack (:heycam)]

Comment on attachment 8859438 [details]
Bug 1355005 - Remove the failures mark of `box-orient` in stylo-failures.md.

https://reviewboard.mozilla.org/r/131476/#review134364

Comment 17

[Chih-Hsuan Kuo [:tommykuo]]

Comment on attachment 8859438 [details]
Bug 1355005 - Remove the failures mark of `box-orient` in stylo-failures.md.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131476/diff/5-6/

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/488534f69bf5
Remove the failures mark of `box-orient` in stylo-failures.md. r=heycam

Comment 19

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/488534f69bf5