Closed
Bug 1355005
Opened 7 years ago
Closed 7 years ago
stylo: Support -moz-box-orient: {block,inline}-axis
Categories
(Core :: CSS Parsing and Computation, enhancement, P1)
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: xidorn, Assigned: kuoe0.tw)
References
Details
Attachments
(1 file, 1 obsolete file)
Currently only horizontal and vertical are implemented, however it should also support {block,inline}-axis (and actually inline-axis is the initial value).
Related file is https://github.com/servo/servo/blob/master/components/style/properties/longhand/xul.mako.rs
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → kuoe0
|
|
Assignee | |
Comment 1•7 years ago
|
||
In layout/style/nsCSSProps.cpp, we only have StyleBoxOrient::Horizontal and StyleBoxOrient::Vertical. Gecko maps inline-axis to Horizontal and block-axis to Vertical.
```
{ eCSSKeyword_horizontal, StyleBoxOrient::Horizontal },
{ eCSSKeyword_vertical, StyleBoxOrient::Vertical },
{ eCSSKeyword_inline_axis, StyleBoxOrient::Horizontal },
{ eCSSKeyword_block_axis, StyleBoxOrient::Vertical },
```
Is there similar way to map two keywords to the same value in servo?Flags: needinfo?(xidorn+moz)
|
Reporter | |
Comment 2•7 years ago
|
||
You probably would not be able to use the single_keyword helper, and have to expand it to helpers::longhand. You may just use define_css_keyword_enum macro twice for ComputedValue and SpecifiedValue separately.
Flags: needinfo?(xidorn+moz)
|
||
Updated•7 years ago
|
Priority: -- → P1
|
||
Updated•7 years ago
|
Status: NEW → ASSIGNED
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8859437 -
Flags: review?(cam)
Attachment #8859438 -
Flags: review?(cam)
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 11•7 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ce502d8408e55cc5008cc478d8423c8fb316622
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 14•7 years ago
|
||
heycam, you can review the patches now! I already updated with `extra_gecko_alias`. try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1121f2f16a5724e11d2fc6afa22a4eeeddc9545d
Flags: needinfo?(cam)
|
||
Comment 15•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8859437 [details] Bug 1355005 - Add `inline-axis` and `block-axis` aliases for `-moz-box-orient`. https://reviewboard.mozilla.org/r/131474/#review134362 Nice, saves a lot of code!
Attachment #8859437 -
Flags: review?(cam) → review+
|
|
||
Comment 16•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8859438 [details] Bug 1355005 - Remove the failures mark of `box-orient` in stylo-failures.md. https://reviewboard.mozilla.org/r/131476/#review134364
Attachment #8859438 -
Flags: review?(cam) → review+
|
|
||
Updated•7 years ago
|
Flags: needinfo?(cam)
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8859437 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
|
||
Comment 18•7 years ago
|
||
Pushed by tlin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/488534f69bf5 Remove the failures mark of `box-orient` in stylo-failures.md. r=heycam
Keywords: checkin-needed
|
||
Comment 19•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/488534f69bf5
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•