135507 - "Subscribe" button is not working for imap subfolders

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Karen Huang]

Used 0404-06-trunk build

Subscribe IMAP Shared folder UI: Click Subscribe button for IMAP Shared Folder 
generating same folder on the bottom.

1) After setup IMAP Shared folder from one account (e.g.Act1)
2) Go to the other user's account (Act2) to subscribe the shared folder.
3) From the Subscribe dialog, click the "Subscribe" button instead of using    
the "check" for subscription.
4) Actual Results: Additional same subscribed folder will be displaying on the   
   bottom of the Subscribe Dialog UI. (Will attach a screen shot as following)

Expected results: Shouldn't dispaly additional same folder name on the bottom of 
the Subscribe Dialog UI after click the "Subscribe" button of the Subscribe 
Dialog UI.

Comment 1

[Karen Huang]

Attachment: attach the screen shot for the additional folder generated for the IMAP Shared Fodlers

Comment 2

[Karen Huang]

Nominating nsbeta1 since clisck subscribe button shouldn't generate the same 
shared folder again on the bottom of the Subscribe dialog

Comment 3

[Karen Huang]

Ccing David as well.
David, should this bug assign to you? Or Seth can work on Subscribe UI for IMAP 
Shared folders?

Comment 4

[David :Bienvenu]

taking from Seth.

Karen, your reasons for nominating this are basically just repeating the bug
(you could do that for every bug in the system!) - that's not really grounds for
making this nsbeta1. Does anything bad happen?

Comment 5

[David :Bienvenu]

I tried this a bunch of times and was not able to reproduce it.

Comment 6

[Karen Huang]

This bug now is not only the UI problem since after I click the "subscribe" 
button. It is not subscribing the IMAP Shared Folder...
Subscribe IMAP Shared Folder functionality is not implementating for the 
"Subscribe" button (it's only working when "checking the boxes" for subscribing 
IMAP Shared Folders), and furthermore it generated the same folder on the bottom 
of the subscribe dialog...

I am updating the summary to:
Subscribe IMAP Shared Folder functionality is not implementating for the 
"Subscribe" button of the Subscribe dialog

Comment 7

[Karen Huang]

I can reporduce this problem.
This problem is occurring when you try to subscribe "Account 2" folder which has 
been setup read privilege from "Account1" for "Account 2".....

Comment 8

[David :Bienvenu]

does the folder get subscribed or not?

Comment 9

[Karen Huang]

No. If you click the "Subscribe" button instead of checking from the boxes of 
the subscribe dialog.

Comment 10

[Karen Huang]

David, check the other user's account and try to subscribe from that account 
and you will see this problem.
This problem cannot be reproduced on the personal folders (which is Acct1) and 
it can be reproduced on other users' folders (which is Act2).....

Comment 11

[Karen Huang]

Changing the summary again to specify problem is occurring for IMAP Other User's 
Folders after shared:
"Subscribe" button is not working for IMAP Other User's Folders after shared

Comment 12

[Michael Buckland]

Discussed in Mail News bug mtg with Engineering QA and PjM.  Decided to ADT3 and
plus this bug.

Comment 13

[David :Bienvenu]

This has nothing to do with shared folders - it has to do with the Subscribe
command - it doesn't work at all for imap sub folders, or top level folders with
folder names that include things like spaces. The subscribe command is only
trying to subscribe to the leaf name (e.g. if you subscribe to parent/subfolder,
it tries to subscribe to "subfolder").

Comment 14

[David :Bienvenu]

Attachment: proposed fix

use the same code as clicking on the subscribe column does to get the name of
the folder to subscribe to.

Comment 15

[David :Bienvenu]

Navin, can you r=? thx.

Comment 16

[Navin Gupta]

Comment on attachment 78776 [details] [diff] [review]
proposed fix

r=naving

Comment 17

[(not reading, please use [e-mail] instead)]

Comment on attachment 78776 [details] [diff] [review]
proposed fix

sr=sspitzer

Comment 18

[(not reading, please use [e-mail] instead)]

does subscribe / unsubscribe to non-ASCII newsgroups still work?

Comment 19

[David :Bienvenu]

*** Bug 137219 has been marked as a duplicate of this bug. ***

Comment 20

[David :Bienvenu]

fixed on trunk.

Comment 21

[scottputterman]

Karen, can you verify this on the trunk?

Comment 22

[Karen Huang]

Verified this has been fixed on 05-21-08-trunk build

Comment 23

[Jaime Rodriguez, Jr.]

Mass removing adt1.0.0, and adding adt1.0.1 because, we are now on 1.0.1.

Comment 24

[(not reading, please use [e-mail] instead)]

note, this fix has landed on the mozilla 1.0 branch (for 1.0.1 and netscape 7.0 
rtm).

Comment 25

[scottputterman]

FYI, this landed without adt approval which requires an adt1.0.1+.

Comment 26

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 151457 has been marked as a duplicate of this bug. ***

Comment 27

[Karen Huang]

Verified on branch builds for all the platforms:
Windows 06-19-08-1.0
Linux 06-19-12-1.0
Mac 06-19-05-1.0
Subscribe button is working for IMAP subfolders on branch builds.
Marking as verified and changing keywords from "fixed1.0.1" to "verified1.0.1".