Closed
Bug 1355141
Opened 7 years ago
Closed 7 years ago
Bugfiler failing with "Unknown provider: crashSignaturesProvider"
Categories
(Tree Management :: Treeherder, defect)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: aryx, Assigned: KWierso)
References
Details
(Keywords: regression)
Attachments
(1 file)
Clicking the bug button in the autoclassification UI for the stylo Rs4 does nothing: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=be41d5b2663f132cb2bb661cea9f74d2b9c18c9d&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=90133522 From "Error: [$injector:unpr] Unknown provider: crashSignaturesProvider <- crashSignatures <- BugFilerCtrl <- BugFilerCtrl <- BugFilerCtrl http://errors.angularjs.org/1.5.8/$injector/unpr?p0=crashSignaturesProvider%20%3C-%20crashSignatures%20%3C-%20BugFilerCtrl%20%3C-%20BugFilerCtrl%20%3C-%20BugFilerCtrl le/<@https://treeherder.mozilla.org/vendor.bba5b7b37606e532a173.bundle.js:35:238060 Sn/Hl.$injector<@https://treeherder.mozilla.org/vendor.bba5b7b37606e532a173.bundle.js:35:258260 Ql@https://treeherder.mozilla.org/vendor.bba5b7b37606e532a173.bundle.js:35:256802 Sn/Gl<@https://treeherder.mozilla.org/vendor.bba5b7b37606e532a173.bundle.js:35:258351 Ql@https://treeherder.mozilla.org/vendor.bba5b7b37606e532a173.bundle.js:35:256802 Zl@https://treeherder.mozilla.org/vendor.bba5b7b37606e532a173.bundle.js:35:257138 ql/<.invoke@https://treeherder.mozilla.org/vendor.bba5b7b37606e532a173.bundle.js:35:257337 Vn/this.$get</</Fl<@https://treeherder.mozilla.org/vendor.bba5b7b37606e532a173.bundle.js:35:287095 oe.$get</me.open/ge<@https://treeherder.mozilla.org/vendor.bba5b7b37606e532a173.bundle.js:35:171324 Nl@https://treeherder.mozilla.org/vendor.bba5b7b37606e532a173.bundle.js:35:311329 Dl/<@https://treeherder.mozilla.org/vendor.bba5b7b37606e532a173.bundle.js:35:311519 Za/this.$get</jl.prototype.$eval@https://treeherder.mozilla.org/vendor.bba5b7b37606e532a173.bundle.js:35:319995 Za/this.$get</jl.prototype.$digest@https://treeherder.mozilla.org/vendor.bba5b7b37606e532a173.bundle.js:35:318311 Za/this.$get</jl.prototype.$apply@https://treeherder.mozilla.org/vendor.bba5b7b37606e532a173.bundle.js:35:320304 xd[El]</<.compile/</<@https://treeherder.mozilla.org/vendor.bba5b7b37606e532a173.bundle.js:35:396007 bt.event.dispatch@https://treeherder.mozilla.org/vendor.bba5b7b37606e532a173.bundle.js:13:63618 bt.event.add/Ta.handle@https://treeherder.mozilla.org/vendor.bba5b7b37606e532a173.bundle.js:13:60013 " vendor.bba5b7b37606e532a173.bundle.js:35:303319 Nl/< https://treeherder.mozilla.org/vendor.bba5b7b37606e532a173.bundle.js:35:303319 Gn/this.$get</< https://treeherder.mozilla.org/vendor.bba5b7b37606e532a173.bundle.js:35:287428 Nl https://treeherder.mozilla.org/vendor.bba5b7b37606e532a173.bundle.js:35:311422 Dl/< https://treeherder.mozilla.org/vendor.bba5b7b37606e532a173.bundle.js:35:311519 Za/this.$get</jl.prototype.$eval https://treeherder.mozilla.org/vendor.bba5b7b37606e532a173.bundle.js:35:319995 Za/this.$get</jl.prototype.$digest https://treeherder.mozilla.org/vendor.bba5b7b37606e532a173.bundle.js:35:318311 Za/this.$get</jl.prototype.$apply https://treeherder.mozilla.org/vendor.bba5b7b37606e532a173.bundle.js:35:320304 xd[El]</<.compile/</< https://treeherder.mozilla.org/vendor.bba5b7b37606e532a173.bundle.js:35:396007 bt.event.dispatch https://treeherder.mozilla.org/vendor.bba5b7b37606e532a173.bundle.js:13:63618 bt.event.add/Ta.handle https://treeherder.mozilla.org/vendor.bba5b7b37606e532a173.bundle.js:13:60013
Comment 1•7 years ago
|
||
A regression from bug 1289333?
Blocks: 1289333
Flags: needinfo?(wkocher)
Summary: Bugfiler broken → Bugfiler failing with "Unknown provider: crashSignaturesProvider"
Assignee | ||
Comment 2•7 years ago
|
||
Probably just need to pass in the crash signatures from https://github.com/mozilla/treeherder/blob/3fb5362ef6aefb2bf079ec42f2e148533f7554b1/ui/plugins/auto_classification/controller.js#L152 like I do in https://github.com/mozilla/treeherder/blob/87bb54f94b1221d10012fce3369cb9f4a8d0ce77/ui/plugins/failure_summary/controller.js#L96
Assignee: nobody → wkocher
Flags: needinfo?(wkocher)
Comment 3•7 years ago
|
||
Assignee | ||
Comment 4•7 years ago
|
||
Comment on attachment 8856642 [details] [review] [treeherder] KWierso:b1355141 > mozilla:master So this gets rid of the error and lets it find the crash signature for the currently selected line. There is a bit of a difference between parts of autoclassify's and failure_summary's setup for the bugfiler: or the failure_summary implementation, allFailures is an array of every failure line for the entire job, not just the currently selected failure line. And from that, crashSignatures is an array of all crash signatures from all failure lines in the selected job, not just the currently selected failure line. I'm unsure how hard it'd be to get autoclassify's version to match up with the failure_summary version.
Attachment #8856642 -
Flags: review?(james)
Assignee | ||
Comment 5•7 years ago
|
||
s/ or the failure_summary/For the failure_summary/
Comment 6•7 years ago
|
||
Comment on attachment 8856642 [details] [review] [treeherder] KWierso:b1355141 > mozilla:master Could have lived without the "check that the empty array doesn't already contain this entry" part, but this is fine.
Attachment #8856642 -
Flags: review?(james) → review+
Comment 7•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/aa2a9f7da5a798ab0554e11aadce0d816f4e45e7 Bug 1355141 - Make autoclassify's bugfiler work again (#2332)
Assignee | ||
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•7 years ago
|
||
(In reply to James Graham [:jgraham] from comment #6) > Could have lived without the "check that the empty array doesn't already > contain this entry" part, but this is fine. As mentioned in comment 4, the non-autoclassify version of the bug filer is sent all of the lines in the failed job, and all of the crash signatures from all of those lines, not just the currently selected line.
Assignee | ||
Comment 9•7 years ago
|
||
(In reply to Wes Kocher (:KWierso) from comment #8) > (In reply to James Graham [:jgraham] from comment #6) > As mentioned in comment 4, the non-autoclassify version of the bug filer is > sent all of the lines in the failed job, and all of the crash signatures > from all of those lines, not just the currently selected line. Which bug 1356483 is changing to match autoclassify's implementation because it was taking too many bogus crash signatures, so we're done here. :)
Assignee | ||
Comment 10•7 years ago
|
||
(In reply to Wes Kocher (:KWierso) from comment #9) > (In reply to Wes Kocher (:KWierso) from comment #8) > > (In reply to James Graham [:jgraham] from comment #6) > > As mentioned in comment 4, the non-autoclassify version of the bug filer is > > sent all of the lines in the failed job, and all of the crash signatures > > from all of those lines, not just the currently selected line. > > Which bug 1356483 is changing to match autoclassify's implementation because > it was taking too many bogus crash signatures, so we're done here. :) Though only for the crash signatures. It still sends in all unrelated failure lines so the bug summary can be modified as needed with extra information.
You need to log in
before you can comment on or make changes to this bug.
Description
•