1289333 - Bugfiler should set the right bug priorities, keywords and crash signature for crashes

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P4)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

To handle crash bugs correctly the appropriate flags have to be set. Those include:

* Keyword: crash
* Severity: critical
* Crash Signature: [@ foobar(foo, bar)]

Comment 2

[GitHub Autolander Bot]

Attachment: [treeherder] KWierso:crashsigs > mozilla:master

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8851299 [details] [review]
[treeherder] KWierso:crashsigs > mozilla:master

With this patch, if any of the failure lines for a failed job contain a crash signature, the bug filer will show an extra field, pre-filled with the crash signature(s). 

When you submit a bug with a crash signature, the bug's severity will be set to "critical" and the "crash" keyword will be added to the list of keywords in the bug.

I think I might need to make one or more changes before this can work, though. Right now, the keywords are submitted as a comma-separated string, but the Bugzilla REST API docs say the 'keywords' parameter should be an array of keywords. I'm not sure what will happen with a comma separated list. It might break, or it might just take the first keyword in the list.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Wes Kocher (:KWierso) from comment #3)
> I think I might need to make one or more changes before this can work,
> though. Right now, the keywords are submitted as a comma-separated string,
> but the Bugzilla REST API docs say the 'keywords' parameter should be an
> array of keywords. I'm not sure what will happen with a comma separated
> list. It might break, or it might just take the first keyword in the list.

Switched it to an array. Lets see how it goes.

Comment 5

[Cameron Dawson [:camd]]

Comment on attachment 8851299 [details] [review]
[treeherder] KWierso:crashsigs > mozilla:master

I put in a few review requests.  I'm waiting to have some data locally to try testing this.  :)

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8851299 [details] [review]
[treeherder] KWierso:crashsigs > mozilla:master

Fixed up the things you brought up. It still works for me. I don't need to ingest data, just point the UI to the prod server's data.

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/87bb54f94b1221d10012fce3369cb9f4a8d0ce77
Bug 1289333 - Set crash signature and related fields (#2294) r=camd

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Can anyone please tell when this is going live on production?

Comment 9

[Ed Morley [:emorley]]

A production deploy was performed on Monday (http://logs.glob.uno/?c=mozilla%23treeherder&s=3+Apr+2017&e=3+Apr+2017#c133550), which this was part of, but rolled back due to the unrelated bug 1353066. We'll likely do another prod push within the next 24-48 hours.