Closed
Bug 1355150
Opened 8 years ago
Closed 7 years ago
Support headless mode on Windows
Categories
(Firefox :: Headless, enhancement)
Firefox
Headless
Tracking
()
RESOLVED
FIXED
Firefox 56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: bdahl, Assigned: bdahl)
References
Details
(Keywords: dev-doc-complete)
Attachments
(6 files)
1.98 KB,
patch
|
automatedtester
:
review+
|
Details | Diff | Splinter Review |
987 bytes,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
1.28 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
2.73 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
5.57 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
1.05 KB,
patch
|
automatedtester
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Blocks: 1355047
Depends on: 1357381
Assignee | ||
Updated•8 years ago
|
Component: General → Headless
Assignee | ||
Comment 1•7 years ago
|
||
Try run (with all patches applied) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c868bfc33b070e8e2312b7a696fd6dc07178cbc4
Attachment #8876943 -
Flags: review?(dburns)
Assignee | ||
Comment 2•7 years ago
|
||
This is the first part of the actual work. Overall, most of the patches are really small as most of the work was done already for linux.
Attachment #8876945 -
Flags: review?(jmuizelaar)
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8876946 -
Flags: review?(jmuizelaar)
Assignee | ||
Comment 4•7 years ago
|
||
Attachment #8876947 -
Flags: review?(jmuizelaar)
Assignee | ||
Comment 5•7 years ago
|
||
Attachment #8876948 -
Flags: review?(jmuizelaar)
Assignee | ||
Comment 6•7 years ago
|
||
This test is inconsistent across platforms, so I'm going to disable for now on headless. I filed bug 1356681 to re-enable and also see https://bugzilla.mozilla.org/show_bug.cgi?id=1335457#c1
Attachment #8876949 -
Flags: review?(dburns)
Updated•7 years ago
|
Attachment #8876943 -
Flags: review?(dburns) → review+
Updated•7 years ago
|
Attachment #8876949 -
Flags: review?(dburns) → review+
Updated•7 years ago
|
Attachment #8876945 -
Flags: review?(jmuizelaar) → review+
Updated•7 years ago
|
Attachment #8876946 -
Flags: review?(jmuizelaar) → review+
Updated•7 years ago
|
Attachment #8876947 -
Flags: review?(jmuizelaar) → review+
Updated•7 years ago
|
Attachment #8876948 -
Flags: review?(jmuizelaar) → review+
Pushed by bdahl@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8cd5e6e5d0f7
Enable headless mode on windows. r=automatedtester, r=jrmuizel
Pushed by kwierso@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/37f2e9416b73
Followup to disable headless tests on windows asan a=bustage r=bdahl
(In reply to Pulsebot from comment #8)
> Pushed by kwierso@gmail.com:
> https://hg.mozilla.org/integration/mozilla-inbound/rev/37f2e9416b73
> Followup to disable headless tests on windows asan a=bustage r=bdahl
17:22:38 <KWierso> bdahl: looks like your patch has failing tests
17:24:12 <bdahl> KWierso: windows asan?
17:24:17 <KWierso> yeah
17:26:27 <bdahl> KWierso: dang, forgot that one in my try run
17:26:43 <KWierso> it's tier2 so I could just file a bug for it
17:26:50 <KWierso> maybe hide it for now until you can sort it out
17:26:55 <bdahl> KWierso: actually that shouldn't be enabled, i don't think regular marionette tests are running on windows asan
17:27:10 <KWierso> I don't see any
17:27:39 <KWierso> so... drop https://hg.mozilla.org/integration/mozilla-inbound/rev/8cd5e6e5d0f71c18d928f76cf4312961145bb5af#l1.65 ?
17:29:47 <KWierso> bdahl: I can push that right now
17:31:48 <bdahl> KWierso: actually looks like marionette should be running on asan, but we could turn off headless for now on asan
17:32:24 <KWierso> bdahl: r=you? to drop it for now?
17:32:49 <bdahl> KWierso: yeah
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8cd5e6e5d0f7
https://hg.mozilla.org/mozilla-central/rev/37f2e9416b73
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Updated•7 years ago
|
Keywords: dev-doc-needed
Updated•7 years ago
|
Assignee: nobody → bdahl
Comment 11•7 years ago
|
||
See https://bugzilla.mozilla.org/show_bug.cgi?id=1338004#c39 for docs.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•