Support headless mode on Windows

RESOLVED FIXED in Firefox 56

Status

()

Firefox
Headless
RESOLVED FIXED
4 months ago
a month ago

People

(Reporter: bdahl, Assigned: bdahl)

Tracking

(Depends on: 1 bug, Blocks: 2 bugs, {dev-doc-needed})

unspecified
Firefox 56
dev-doc-needed
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(6 attachments)

Comment hidden (empty)
(Assignee)

Updated

4 months ago
Blocks: 1355036
Blocks: 1355047
Depends on: 1357381
(Assignee)

Updated

2 months ago
Component: General → Headless
(Assignee)

Comment 1

2 months ago
Created attachment 8876943 [details] [diff] [review]
Part 1 - Enable headless windows marionette tests.

Try run (with all patches applied) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c868bfc33b070e8e2312b7a696fd6dc07178cbc4
Attachment #8876943 - Flags: review?(dburns)
(Assignee)

Comment 2

2 months ago
Created attachment 8876945 [details] [diff] [review]
Part 2 - Allow headless to run on windows.

This is the first part of the actual work. Overall, most of the patches are really small as most of the work was done already for linux.
Attachment #8876945 - Flags: review?(jmuizelaar)
(Assignee)

Comment 3

2 months ago
Created attachment 8876946 [details] [diff] [review]
Part 3 - Make headless windows active so they paint.
Attachment #8876946 - Flags: review?(jmuizelaar)
(Assignee)

Comment 4

2 months ago
Created attachment 8876947 [details] [diff] [review]
Part 4 - Set window z level so getting most recent window works.
Attachment #8876947 - Flags: review?(jmuizelaar)
(Assignee)

Comment 5

2 months ago
Created attachment 8876948 [details] [diff] [review]
Part 5 - Use headless clipboard on windows.
Attachment #8876948 - Flags: review?(jmuizelaar)
(Assignee)

Comment 6

2 months ago
Created attachment 8876949 [details] [diff] [review]
Part 6 - Disable switch chrome windows tests on headless.

This test is inconsistent across platforms, so I'm going to disable for now on headless. I filed bug 1356681 to re-enable and also see https://bugzilla.mozilla.org/show_bug.cgi?id=1335457#c1
Attachment #8876949 - Flags: review?(dburns)
Attachment #8876943 - Flags: review?(dburns) → review+
Attachment #8876949 - Flags: review?(dburns) → review+
Attachment #8876945 - Flags: review?(jmuizelaar) → review+
Attachment #8876946 - Flags: review?(jmuizelaar) → review+
Attachment #8876947 - Flags: review?(jmuizelaar) → review+
Attachment #8876948 - Flags: review?(jmuizelaar) → review+

Comment 7

a month ago
Pushed by bdahl@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8cd5e6e5d0f7
Enable headless mode on windows. r=automatedtester, r=jrmuizel

Comment 8

a month ago
Pushed by kwierso@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/37f2e9416b73
Followup to disable headless tests on windows asan a=bustage r=bdahl
(In reply to Pulsebot from comment #8)
> Pushed by kwierso@gmail.com:
> https://hg.mozilla.org/integration/mozilla-inbound/rev/37f2e9416b73
> Followup to disable headless tests on windows asan a=bustage r=bdahl

17:22:38 <KWierso> bdahl: looks like your patch has failing tests
17:24:12 <bdahl> KWierso: windows asan?
17:24:17 <KWierso> yeah
17:26:27 <bdahl> KWierso: dang, forgot that one in my try run
17:26:43 <KWierso> it's tier2 so I could just file a bug for it
17:26:50 <KWierso> maybe hide it for now until you can sort it out
17:26:55 <bdahl> KWierso: actually that shouldn't be enabled, i don't think regular marionette tests are running on windows asan
17:27:10 <KWierso> I don't see any
17:27:39 <KWierso> so... drop https://hg.mozilla.org/integration/mozilla-inbound/rev/8cd5e6e5d0f71c18d928f76cf4312961145bb5af#l1.65 ?
17:29:47 <KWierso> bdahl: I can push that right now
17:31:48 <bdahl> KWierso: actually looks like marionette should be running on asan, but we could turn off headless for now on asan
17:32:24 <KWierso> bdahl: r=you? to drop it for now?
17:32:49 <bdahl> KWierso: yeah

Comment 10

a month ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8cd5e6e5d0f7
https://hg.mozilla.org/mozilla-central/rev/37f2e9416b73
Status: NEW → RESOLVED
Last Resolved: a month ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Keywords: dev-doc-needed
Assignee: nobody → bdahl
You need to log in before you can comment on or make changes to this bug.