We'll use this bug to track the work to enable the work done in bug 1325467 by default.
Seems like maybe we should fix bug 1339909 before enabling this? Or are you not going to use that feature?
Andreas, can you take a look at ThrottleTrackingTimeoutsCallback bug 1339909? It looks like Ehsan posted a patch last month, but Ben asked for some changes.
Created attachment 8864124 [details] [diff] [review] 0001-Bug-1355311-Set-default-values-for-throttling-backgr.patch
I'd wish we had prefs for this and enable this also in foreground tabs in nightly. That way we'll see hopefully sooner whether this causes regressions.
A pref would be nice. It makes it a lot easier to handle problems in the wild since we can flip it via a system addon without cutting a new release.
Created attachment 8864142 [details] [diff] [review] 0001-Bug-1355311-Set-default-values-for-throttling-backgr.patch Accidentally almost turned on foreground throttling as well. Changed it to be on using an ifdef NIGHTLY_BUILD. With the current setup this is controlled by the hidden prefs and default values: * dom.timeout.tracking_throttling_delay: 30,000 (30 seconds) * dom.min_tracking_timeout_value: if nightly then 10,000 (10 seconds) else dom.min_timeout_value * dom.min_tracking_background_timeout_value: 10,000 (10 seconds)
Created attachment 8864225 [details] [diff] [review] 0001-Bug-1355311-Set-default-values-for-throttling-backgr.patch
Comment on attachment 8864225 [details] [diff] [review] 0001-Bug-1355311-Set-default-values-for-throttling-backgr.patch Review of attachment 8864225 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! Please make sure an intent to ship email is sent indicating that this is being turned on for Nightly... ::: modules/libpref/init/all.js @@ +1210,4 @@ > pref("dom.min_timeout_value", 4); > // And for background windows > pref("dom.min_background_timeout_value", 1000); > +// Timeout clamp in ms for tracking timeouts we clamp Please add a comment saying that the prefs below will only have an effect if the privacy.trackingprotection.annotate_channels pref is set to true. You can copy the comment that we have for the privacy.trackingprotection.lower_network_priority already.
Created attachment 8864508 [details] [diff] [review] 0001-Bug-1355311-Set-default-values-for-throttling-backgr.patch Added comment about privacy.trackingprotection.annotate_channels pref. Carrying over r+.
The throttling will potentially effect web developers, so this change needs to be covered by documentation. For document team: reference this email thread, which is full of very useful information: http://bit.ly/2qe9vhZ
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0542e8e2295b Set default values for throttling background timeouts. r=ehsan
sorry had to back this out for assertion failures in TimeoutManager.cpp like https://treeherder.mozilla.org/logviewer.html#?job_id=99078033&repo=mozilla-inbound&lineNumber=8458
Backout by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/9ff22abe5736 Backed out changeset 0542e8e2295b for assertion failure in TimeoutManager.cpp
Thanks :ihsiao, I'm on it.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6411a4abcc1a Set default values for throttling background timeouts. r=ehsan
I've added notes (and updated browser compat info) on: https://developer.mozilla.org/en-US/docs/Web/API/WindowOrWorkerGlobalScope/setTimeout#Throttling_of_tracking_timeout_scripts https://developer.mozilla.org/en-US/docs/Web/API/WindowOrWorkerGlobalScope/setInterval#Throttling_of_intervals I've also added a note to the Fx55 rel notes page: https://developer.mozilla.org/en-US/Firefox/Releases/55#DOM_HTML_DOM Let me know if this reads OK, or if you think anything else is required. Thanks!
Backed out for causing crash in mozilla::dom::TimeoutManager::MaybeStartThrottleTrackingTimout (bug 1366812): https://hg.mozilla.org/mozilla-central/rev/f9ca97a334296facd2e0ea5582e7f12d0fe70fe4
Relanding because bug 1367025 may have fixed the cause of the crashes.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/ecb5a09e6371 Set default values for throttling background timeouts. r=ehsan
3 months ago