1367025 - TimeoutManager::MaybeStartThrottleTrackingTimout is called when throttling already started

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andreas Farre [:farre]]

See Bug 1366812

Comment 1

[Andreas Farre [:farre]]

Attachment: 0001-Bug-1367025-Don-t-start-throttling-delay-timers-whil.patch

This fixes an invariant that was broken that _could_ be the reason for Bug 1366812, but it's hard to test.

Comment 2

[Andreas Farre [:farre]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f3738378148a3ae3f0fc33232dc59d71af9b52df

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8870417 [details] [diff] [review]
0001-Bug-1367025-Don-t-start-throttling-delay-timers-whil.patch

Review of attachment 8870417 [details] [diff] [review]:
-----------------------------------------------------------------

In the future we may want to make nsGlobalWindow::FreeInnerWindow() call Freeze() explicitly when its deleting its inner objects.  Then we could just use a IsSuspended() check here and all our other IsSuspended() checks would work too.  It would probably take some trial-and-error to get this right, though.

So this patch is good for now.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/826ecf00de0a
Don't start throttling delay timers while suspended. r=bkelly

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/826ecf00de0a