Closed Bug 1355394 Opened 3 years ago Closed 3 years ago

stylo: Implement access to CSSSupportsRule

Categories

(Core :: CSS Parsing and Computation, enhancement, P1)

53 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

Attachments

(4 files)

The CSSOM bit for @supports.
Assignee: nobody → xidorn+moz
Priority: -- → P1
Blocks: 1359217
Comment on attachment 8861886 [details]
Bug 1355394 part 1 - Add separate CSSSupportsRule base class.

https://reviewboard.mozilla.org/r/133908/#review137134
Attachment #8861886 - Flags: review?(cam) → review+
Comment on attachment 8861887 [details]
Bug 1355394 part 2 - Move GetRules function into macro.

https://reviewboard.mozilla.org/r/133910/#review137138
Attachment #8861887 - Flags: review?(cam) → review+
Comment on attachment 8861888 [details]
Bug 1355394 part 3 - Implement CSSOM support for @supports.

https://reviewboard.mozilla.org/r/133912/#review137142
Attachment #8861888 - Flags: review?(cam) → review+
Comment on attachment 8861889 [details]
Bug 1355394 part 4 - Adjust test expectations.

https://reviewboard.mozilla.org/r/133914/#review137144

::: layout/style/test/stylo-failures.md:66
(Diff revision 1)
>    * \@support bug 1355394
> -    * test_supports_rules.html [1]
> +    * test_supports_rules.html [6]

Since bug 1355394 will be resolved, maybe file a followup bug (and adjust the bug number here) for the underlying reason for these failures?
Attachment #8861889 - Flags: review?(cam) → review+
Comment on attachment 8861889 [details]
Bug 1355394 part 4 - Adjust test expectations.

https://reviewboard.mozilla.org/r/133914/#review137144

> Since bug 1355394 will be resolved, maybe file a followup bug (and adjust the bug number here) for the underlying reason for these failures?

I plan to revisit all failures in stylo-failures.md whose connected bug has been closed, and mark them with correct bug soonish. Probably next week. I'd like to leave it as-is for now, and my script would list all of them when I do re-triage.
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/29728643acd4
part 1 - Add separate CSSSupportsRule base class. r=heycam
https://hg.mozilla.org/integration/autoland/rev/19b3fcb74901
part 2 - Move GetRules function into macro. r=heycam
https://hg.mozilla.org/integration/autoland/rev/ffc4714cef39
part 3 - Implement CSSOM support for @supports. r=heycam
https://hg.mozilla.org/integration/autoland/rev/98fe3fc7f8e5
part 4 - Adjust test expectations. r=heycam
You need to log in before you can comment on or make changes to this bug.