1355394 - stylo: Implement access to CSSSupportsRule

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P1)

Description

[Xidorn Quan [:xidorn] UTC+10]

The CSSOM bit for @supports.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dbe84f28df343b0bc36f13cc788d7794b0dcc94f

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1355394 part 1 - Add separate CSSSupportsRule base class.

Review commit: https://reviewboard.mozilla.org/r/133908/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133908/

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1355394 part 2 - Move GetRules function into macro.

Review commit: https://reviewboard.mozilla.org/r/133910/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133910/

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1355394 part 3 - Implement CSSOM support for @supports.

Review commit: https://reviewboard.mozilla.org/r/133912/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133912/

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1355394 part 4 - Adjust test expectations.

Review commit: https://reviewboard.mozilla.org/r/133914/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133914/

Comment 6

[Cameron McCormack (:heycam)]

Comment on attachment 8861886 [details]
Bug 1355394 part 1 - Add separate CSSSupportsRule base class.

https://reviewboard.mozilla.org/r/133908/#review137134

Comment 7

[Cameron McCormack (:heycam)]

Comment on attachment 8861887 [details]
Bug 1355394 part 2 - Move GetRules function into macro.

https://reviewboard.mozilla.org/r/133910/#review137138

Comment 8

[Cameron McCormack (:heycam)]

Comment on attachment 8861888 [details]
Bug 1355394 part 3 - Implement CSSOM support for @supports.

https://reviewboard.mozilla.org/r/133912/#review137142

Comment 9

[Cameron McCormack (:heycam)]

Comment on attachment 8861889 [details]
Bug 1355394 part 4 - Adjust test expectations.

https://reviewboard.mozilla.org/r/133914/#review137144

::: layout/style/test/stylo-failures.md:66
(Diff revision 1)
>    * \@support bug 1355394
> -    * test_supports_rules.html [1]
> +    * test_supports_rules.html [6]

Since bug 1355394 will be resolved, maybe file a followup bug (and adjust the bug number here) for the underlying reason for these failures?

Comment 10

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8861889 [details]
Bug 1355394 part 4 - Adjust test expectations.

https://reviewboard.mozilla.org/r/133914/#review137144

> Since bug 1355394 will be resolved, maybe file a followup bug (and adjust the bug number here) for the underlying reason for these failures?

I plan to revisit all failures in stylo-failures.md whose connected bug has been closed, and mark them with correct bug soonish. Probably next week. I'd like to leave it as-is for now, and my script would list all of them when I do re-triage.

Comment 11

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8861886 [details]
Bug 1355394 part 1 - Add separate CSSSupportsRule base class.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/133908/diff/1-2/

Comment 12

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8861887 [details]
Bug 1355394 part 2 - Move GetRules function into macro.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/133910/diff/1-2/

Comment 13

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8861888 [details]
Bug 1355394 part 3 - Implement CSSOM support for @supports.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/133912/diff/1-2/

Comment 14

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8861889 [details]
Bug 1355394 part 4 - Adjust test expectations.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/133914/diff/1-2/

Comment 15

[Xidorn Quan [:xidorn] UTC+10]

https://github.com/servo/servo/pull/16642

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29728643acd4
part 1 - Add separate CSSSupportsRule base class. r=heycam
https://hg.mozilla.org/integration/autoland/rev/19b3fcb74901
part 2 - Move GetRules function into macro. r=heycam
https://hg.mozilla.org/integration/autoland/rev/ffc4714cef39
part 3 - Implement CSSOM support for @supports. r=heycam
https://hg.mozilla.org/integration/autoland/rev/98fe3fc7f8e5
part 4 - Adjust test expectations. r=heycam

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/29728643acd4
https://hg.mozilla.org/mozilla-central/rev/19b3fcb74901
https://hg.mozilla.org/mozilla-central/rev/ffc4714cef39
https://hg.mozilla.org/mozilla-central/rev/98fe3fc7f8e5