1355430 - [WebGL Mochitest] Add Mochitest to test Video Fast-path uploading

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, enhancement)

Description

[Michael Leu[:Lenzak](UTC+8)]

We should test fast-path video uploading to ensure our webGL performance

Comment 1

[Michael Leu[:Lenzak](UTC+8)]

Attachment: Bug 1355430 - Part1: s/MOZ_debug_get/MOZ_debug;

Review commit: https://reviewboard.mozilla.org/r/129212/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129212/

Comment 2

[Michael Leu[:Lenzak](UTC+8)]

Attachment: Bug 1355430 - Part2: Implement Require Fastpath for texture copy;

Review commit: https://reviewboard.mozilla.org/r/129214/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129214/

Comment 3

[Michael Leu[:Lenzak](UTC+8)]

Attachment: Bug 1355430 - Part3: Add Mochitest Implementation;

Review commit: https://reviewboard.mozilla.org/r/129362/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129362/

Comment 4

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8857276 [details]
Bug 1355430 - Part1: s/MOZ_debug_get/MOZ_debug;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129212/diff/1-2/

Comment 5

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8857277 [details]
Bug 1355430 - Part2: Implement Require Fastpath for texture copy;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129214/diff/1-2/

Comment 6

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8857377 [details]
Bug 1355430 - Part3: Add Mochitest Implementation;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129362/diff/1-2/

Comment 7

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8857276 [details]
Bug 1355430 - Part1: s/MOZ_debug_get/MOZ_debug;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129212/diff/2-3/

Comment 8

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8857277 [details]
Bug 1355430 - Part2: Implement Require Fastpath for texture copy;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129214/diff/2-3/

Comment 9

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8857377 [details]
Bug 1355430 - Part3: Add Mochitest Implementation;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129362/diff/2-3/

Comment 10

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8857276 [details]
Bug 1355430 - Part1: s/MOZ_debug_get/MOZ_debug;

https://reviewboard.mozilla.org/r/129212/#review132358

Comment 11

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8857277 [details]
Bug 1355430 - Part2: Implement Require Fastpath for texture copy;

https://reviewboard.mozilla.org/r/129214/#review132360

Comment 12

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8857377 [details]
Bug 1355430 - Part3: Add Mochitest Implementation;

https://reviewboard.mozilla.org/r/129362/#review132364

::: dom/canvas/test/webgl-mochitest/mochitest.ini:13
(Diff revision 3)
> +  npot-video.mp4
> +  npot-video.theora.ogv
> +  npot-video.webmvp8.webm

Skip the npot videos. We can assume those work.

Comment 13

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8857377 [details]
Bug 1355430 - Part3: Add Mochitest Implementation;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129362/diff/3-4/

Comment 14

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8857377 [details]
Bug 1355430 - Part3: Add Mochitest Implementation;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129362/diff/4-5/

Comment 15

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8857276 [details]
Bug 1355430 - Part1: s/MOZ_debug_get/MOZ_debug;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129212/diff/3-4/

Comment 16

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8857277 [details]
Bug 1355430 - Part2: Implement Require Fastpath for texture copy;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129214/diff/3-4/

Comment 17

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8857377 [details]
Bug 1355430 - Part3: Add Mochitest Implementation;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129362/diff/5-6/

Comment 18

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8857277 [details]
Bug 1355430 - Part2: Implement Require Fastpath for texture copy;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129214/diff/4-5/

Comment 19

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8857377 [details]
Bug 1355430 - Part3: Add Mochitest Implementation;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129362/diff/6-7/

Comment 20

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8857377 [details]
Bug 1355430 - Part3: Add Mochitest Implementation;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129362/diff/7-8/

Comment 21

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8857276 [details]
Bug 1355430 - Part1: s/MOZ_debug_get/MOZ_debug;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129212/diff/4-5/

Comment 22

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8857277 [details]
Bug 1355430 - Part2: Implement Require Fastpath for texture copy;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129214/diff/5-6/

Comment 23

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8857377 [details]
Bug 1355430 - Part3: Add Mochitest Implementation;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129362/diff/8-9/

Comment 24

[Andrea Marchesini [:baku]]

Comment on attachment 8857276 [details]
Bug 1355430 - Part1: s/MOZ_debug_get/MOZ_debug;

https://reviewboard.mozilla.org/r/129212/#review133716

Comment 25

[Andrea Marchesini [:baku]]

Comment on attachment 8857277 [details]
Bug 1355430 - Part2: Implement Require Fastpath for texture copy;

https://reviewboard.mozilla.org/r/129214/#review133718

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/773f5b2cb868
Part1: s/MOZ_debug_get/MOZ_debug; r=baku,jgilbert
https://hg.mozilla.org/integration/autoland/rev/661144609b7a
Part2: Implement Require Fastpath for texture copy; r=baku,jgilbert
https://hg.mozilla.org/integration/autoland/rev/98d3518db0a4
Part3: Add Mochitest Implementation; r=jgilbert

Comment 27

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for unexpectedly passing own test dom/canvas/test/webgl-mochitest/test_video_fastpath_mp4.html on Windows:

https://hg.mozilla.org/integration/autoland/rev/c1c6461c16051a2253747ac77427687802775f12
https://hg.mozilla.org/integration/autoland/rev/bdf510d5b0270a4d64b6a1da2516d1e8316ea489
https://hg.mozilla.org/integration/autoland/rev/09fd41bb16e4d1ba8bdd825c657f7afa8505cb07

Push which ran the tests: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=c5bdfc3ba44d4f42e568d4bb1df9414b8b5c4a7c&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=usercancel&filter-resultStatus=runnable
Test log: https://treeherder.mozilla.org/logviewer.html#?job_id=92437342&repo=autoland
> TEST-UNEXPECTED-PASS | dom/canvas/test/webgl-mochitest/test_video_fastpath_mp4.html | fail-if condition in manifest - We expected at least one failure

Comment 28

[Michael Leu[:Lenzak](UTC+8)]

It seems that the driver differences among different Windows versions result in different video uploading path.

Let's fix the mochitest-manifest and re-land.

Comment 29

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8857276 [details]
Bug 1355430 - Part1: s/MOZ_debug_get/MOZ_debug;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129212/diff/5-6/

Comment 30

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8857277 [details]
Bug 1355430 - Part2: Implement Require Fastpath for texture copy;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129214/diff/6-7/

Comment 31

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8857377 [details]
Bug 1355430 - Part3: Add Mochitest Implementation;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129362/diff/9-10/

Comment 32

[Michael Leu[:Lenzak](UTC+8)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd62b68b8ea806ba5812044ad7287a6a55f48a3f

I think this version should be good

Comment 33

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/956140f2af57
Part1: s/MOZ_debug_get/MOZ_debug; r=baku,jgilbert
https://hg.mozilla.org/integration/autoland/rev/7dc7ebfb6305
Part2: Implement Require Fastpath for texture copy; r=baku,jgilbert
https://hg.mozilla.org/integration/autoland/rev/eb0d4878a2e2
Part3: Add Mochitest Implementation; r=jgilbert

Comment 34

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/956140f2af57
https://hg.mozilla.org/mozilla-central/rev/7dc7ebfb6305
https://hg.mozilla.org/mozilla-central/rev/eb0d4878a2e2