1373702 - GLBlitHelper::BlitImageToFramebuffer broken for planar YUV buffer on mac

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Jean-Yves Avenard [:jya]]

GLBlitHelper::BlitImageToFramebuffer always returns false.

The error occurs in GLBlitHelper::InitTexQuadProgram.

The compilation of the shader appears to fail.

I'm assuming this is a regression

Comment 1

[Jean-Yves Avenard [:jya]]

It is difficult to identify when BlitImageToFramebuffer broke, because prior bug 1355430 it would always fallback to Image::GetAsSourceSurface

so you can't visually tell when it broke :(

Comment 2

[Vlad Bacia-Mociran [:VladB]]

Hello Jean. Is there any way to test this? This bug appeared in our regression lists and I would like to find the browser versions affected by this.

Comment 3

[Jean-Yves Avenard [:jya]]

I don't know if that code ever worked.

It appears as a regression that occurs once bug 1355430 landed. However this is only because that bug added a specific test making sure that code worked.

Comment 4

[Matt Woodrow (:mattwoodrow)]

The error for this is: ERROR: 0:1: '' :  version '100' is not supported

Looks like a regression from bug 1235299.

Comment 5

[Ethan Lin[:ethlin]]

I will check this issue.

Comment 6

[Peter Chang[:pchang]]

(In reply to Ethan Lin[:ethlin] from comment #5)
> I will check this issue.

Daosheng, could you take a look?

Comment 7

[Daosheng Mu[:daoshengmu]]

Here is a test case from https://threejs.org/examples/webgl_materials_video.html. After adjusting shader version from #version 100 to #version 120, it can go the fast path.

Besides that, we still have some work for color conversion in the fragment shader.

Comment 8

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1373702 - (wip) WebGL fast video patch for MacIOSSurface

Review commit: https://reviewboard.mozilla.org/r/151662/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151662/

Comment 9

[Daosheng Mu[:daoshengmu]]

It has been resolved at Bug 1322746.