convert uses of "defer" to "new Promise" in client/responsivedesign

RESOLVED FIXED in Firefox 55

Status

P3
normal
RESOLVED FIXED
2 years ago
9 months ago

People

(Reporter: friendlyrony2050, Assigned: stylizit)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 55
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

2 years ago
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36
(Reporter)

Updated

2 years ago
Component: Untriaged → Developer Tools: Responsive Design Mode
Priority: -- → P3

Updated

2 years ago
Assignee: nobody → friendlyrony2050
Blocks: 1283869
(Reporter)

Comment 1

2 years ago
I have done the necessary changes for responsivedesign directory. Please have a look at this and let me know whether its okay to push it.
Flags: needinfo?(jryans)
(In reply to Anirban Biswas from comment #1)
> Created attachment 8859272 [details] [diff] [review]
> patch for responsivedesign directory
> 
> I have done the necessary changes for responsivedesign directory. Please
> have a look at this and let me know whether its okay to push it.

Hmm, it seems like your patch contains many unrelated changes, perhaps from when you pulled in new changes?

If you are using Mercurial, perhaps the guide[1] can help here.  You can also ask for help on IRC in #devtools or #introduction.

[1]: https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial
Flags: needinfo?(jryans)

Comment 4

2 years ago
mozreview-review
Comment on attachment 8869810 [details]
Bug 1355473 - convert uses of 'defer' to 'new Promise' in client/responsivedesign;

https://reviewboard.mozilla.org/r/141362/#review146470

Thanks for the patch.  This looks good.
Attachment #8869810 - Flags: review?(ttromey) → review+

Updated

2 years ago
Attachment #8859272 - Attachment is obsolete: true

Updated

2 years ago
Assignee: friendlyrony2050 → matthieu.rigolot

Comment 5

2 years ago
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/79fcc56007c1
convert uses of 'defer' to 'new Promise' in client/responsivedesign; r=tromey

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/79fcc56007c1
Status: UNCONFIRMED → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55

Updated

9 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.