1355537 - [meta] Add Python 3 support to marionette driver

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, task, P3)

Description

[[:nickname] blackmonkmeme]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170329150444

Steps to reproduce:

Attemp to install marionette_driver 2.2.0. with either pip or pip3

52.0.2 (64-bit) for Ubuntu Linux, 16.04.2 LTS

Any of these commands produce the same result:

$ pip3 install marionette_driver
$ sudo pip3 install marionette_driver
$ sudo -H pip3 install marionette_driver

$ pip install marionette_driver
$ sudo pip install marionette_driver
$ sudo -H pip install marionette_driver



Actual results:

Collecting marionette_driver
  Downloading marionette_driver-2.2.0.tar.gz
Collecting mozrunner>=6.13 (from marionette_driver)
  Downloading mozrunner-6.13.tar.gz (67kB)
    100% |████████████████████████████████| 71kB 1.5MB/s
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-0829rk11/mozrunner/setup.py", line 24, in
<module>
        assert sys.version_info[0] == 2
    AssertionError
   
    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in
/tmp/pip-build-0829rk11/mozrunner/



Expected results:

It should have installed marionette_driver for use with Python / 3.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

marionette_driver depends on mozbase, which does not support Python 3. See bug 1093212.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I just checked the mozbase dependencies for bug 1093212 and as I can see all the packages as required by Marionette now have Python 3 support. That means we are no longer blocked on actually updating Marionette client to make it at least work with Python 3.

I talked to Rishi over IRC and he mentioned interest working on this bug.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Please note that the requirements file for the Marionette client package might still refer to older releases of some mozbase packages. So please make sure to update the versions to the latest releases of the specific packages. As best do it in a separate commit.

Comment 4

[Rishi Gupta (:rgpt)]

Attachment: Bug 1355537 - python 3 support for marionette driver r=whimboo

Comment 5

[Rishi Gupta (:rgpt)]

After locally taking the changes from 1595814 i tried running marionette test. There were no errors from harness or driver but from testing/mozbase/manifest. Error was in accessing dictionary items which works differently in python3. As i checked in mozilla-unified/testing/mozbase/manifestparser/setup.py. This is a python2 based library.

What should be done in this scenario as manifestparser is a mozbase package. Should i log a separate bug or enhancement on this as a dependency ?

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Indeed manifestparser is still Python2 only. See bug 1428705 which handles the upgrade to Python3. But is that actually used when you reference a single .py test file? If that is not the case it shouldn't be a hard blocker for the harness. Also the driver doesn't depend on it at all.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This is actually a meta bug now which cannot be assigned to someone. Lets get any work done in dependent bugs.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Nothing more left to do for this meta. I'm going and close it out now. Thanks to everyone who has contributed to make it happen!