1355579 - Get rid of the last dregs of the "spsProfile" terminology

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Mike Conley (:mconley) (:⚙️)]

http://searchfox.org/mozilla-central/search?q=spsprofile shows we're still using spsProfile in a few places, which is bad because that flag got changed to --gecko-profile in bug 1340267. We should fix these last bits.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1355579 - Remove last references to spsProfile in the tree.

Review commit: https://reviewboard.mozilla.org/r/129008/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129008/

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8857100 [details]
Bug 1355579 - Remove last references to spsProfile in the tree.

https://reviewboard.mozilla.org/r/129008/#review131566

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c01aaecd8cc
Remove last references to spsProfile in the tree. r=dustin

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing taskgraph's test_try_option_syntax.py:

https://hg.mozilla.org/integration/autoland/rev/e439dc056e81914bf14afc8165ff278d1c34a7f5

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=6c01aaecd8cc83b2428ca55f56e864e66d66732b&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=90644652&repo=autoland

[task 2017-04-11T21:53:27.251103Z] TEST-PASS | /home/worker/checkouts/gecko/taskcluster/taskgraph/test/test_try_option_syntax.py | TestTryOptionSyntax.test_p_linux_win32
[task 2017-04-11T21:53:27.255750Z] TEST-UNEXPECTED-FAIL | /home/worker/checkouts/gecko/taskcluster/taskgraph/test/test_try_option_syntax.py | TestTryOptionSyntax.test_profile, line 294: False is not true
[task 2017-04-11T21:53:27.255800Z] FAIL: --spsProfile sets profile to true
[task 2017-04-11T21:53:27.255862Z] Traceback (most recent call last):
[task 2017-04-11T21:53:27.255931Z]   File "/home/worker/checkouts/gecko/taskcluster/taskgraph/test/test_try_option_syntax.py", line 294, in test_profile
[task 2017-04-11T21:53:27.255965Z]     self.assertTrue(tos.profile)
[task 2017-04-11T21:53:27.255998Z] AssertionError: False is not true
[task 2017-04-11T21:53:27.256026Z]

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8857100 [details]
Bug 1355579 - Remove last references to spsProfile in the tree.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129008/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d086e6fc190a
Remove last references to spsProfile in the tree. r=dustin

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d086e6fc190a