Closed Bug 1355579 Opened 5 years ago Closed 5 years ago

Get rid of the last dregs of the "spsProfile" terminology

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla55

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(1 file)

http://searchfox.org/mozilla-central/search?q=spsprofile shows we're still using spsProfile in a few places, which is bad because that flag got changed to --gecko-profile in bug 1340267. We should fix these last bits.
Product: Testing → Taskcluster
Assignee: nobody → mconley
Comment on attachment 8857100 [details]
Bug 1355579 - Remove last references to spsProfile in the tree.

https://reviewboard.mozilla.org/r/129008/#review131566
Attachment #8857100 - Flags: review?(dustin) → review+
Component: General → Task Configuration
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6c01aaecd8cc
Remove last references to spsProfile in the tree. r=dustin
Backed out for failing taskgraph's test_try_option_syntax.py:

https://hg.mozilla.org/integration/autoland/rev/e439dc056e81914bf14afc8165ff278d1c34a7f5

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=6c01aaecd8cc83b2428ca55f56e864e66d66732b&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=90644652&repo=autoland

[task 2017-04-11T21:53:27.251103Z] TEST-PASS | /home/worker/checkouts/gecko/taskcluster/taskgraph/test/test_try_option_syntax.py | TestTryOptionSyntax.test_p_linux_win32
[task 2017-04-11T21:53:27.255750Z] TEST-UNEXPECTED-FAIL | /home/worker/checkouts/gecko/taskcluster/taskgraph/test/test_try_option_syntax.py | TestTryOptionSyntax.test_profile, line 294: False is not true
[task 2017-04-11T21:53:27.255800Z] FAIL: --spsProfile sets profile to true
[task 2017-04-11T21:53:27.255862Z] Traceback (most recent call last):
[task 2017-04-11T21:53:27.255931Z]   File "/home/worker/checkouts/gecko/taskcluster/taskgraph/test/test_try_option_syntax.py", line 294, in test_profile
[task 2017-04-11T21:53:27.255965Z]     self.assertTrue(tos.profile)
[task 2017-04-11T21:53:27.255998Z] AssertionError: False is not true
[task 2017-04-11T21:53:27.256026Z]
Flags: needinfo?(mconley)
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d086e6fc190a
Remove last references to spsProfile in the tree. r=dustin
Flags: needinfo?(mconley)
https://hg.mozilla.org/mozilla-central/rev/d086e6fc190a
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.