1355676 - Crash in java.lang.NullPointerException: Attempt to invoke virtual method ''android.graphics.Bitmap org.mozilla.gecko.icons.decoders.LoadFaviconResult.getBestBitmap(int)'' on a null object reference at org.mozilla.gecko.BrowserApp.handleMessage(Browser...

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)

Description

[Ting-Yu Chou [:ting] (away)]

This bug was filed from the Socorro interface and is 
report bp-2568070c-7f98-404b-b13d-07f912170410.
=============================================================
Top #2 of Nightly 20170409194153 on Android, 5 crashes from 1 installation. There are 17 reports from 5 installations in the past week.

Comment 1

[Ting-Yu Chou [:ting] (away)]

The first observation was from build 20170405074742. Do you know any recent changes could cause this?

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

This seems to be in our web app code:

>  final Bitmap icon = FaviconDecoder
>      .decodeDataURI(getContext(), message.getString("icon"))
>      .getBestBitmap(GeckoAppShell.getPreferredIconSize());

Android Studio actually warns that decodeDataURI() might return null.

Comment 3

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

[triage]
this is feature release blocker.

Comment 4

[Dale Harvey (:daleharvey)]

Cheers will take it

Comment 5

[Dale Harvey (:daleharvey)]

Attachment: Check for nulls when decoding icons

Changed both instances of the same code

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8860115 [details] [diff] [review]
Check for nulls when decoding icons

Review of attachment 8860115 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
@@ +2055,5 @@
> +                    final Bitmap icon = loadIconResult
> +                        .getBestBitmap(GeckoAppShell.getPreferredIconSize());
> +                    createAppShortcut(name, startUrl, manifestPath, icon);
> +                } else {
> +                    Log.e(LOGTAG, "Failed to load icon for: " + startUrl);

We try to avoid logging URLs as in earlier Android versions other apps can read our log.

Comment 7

[Dale Harvey (:daleharvey)]

Ah yeh apologies you mentioned that in a previous review, will take out the url

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/841fa5fb06a8
Check for nulls when decoding icons. r=sebastian

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/841fa5fb06a8

Comment 10

[Ryan VanderMeulen [:RyanVM]]

crash-stats shows a couple hits on 54.0a2 - is this something we should consider uplifting to Beta as well?

Comment 11

[Dale Harvey (:daleharvey)]

Nah we are aiming for 55, this is disabled in 54 so the only people that could hit it are testing so I dont think we need to worry about uplifts

Comment 12

[Oana Horvath [:ohorvath]]

Attachment: 1355676 log - 2017-27-04.txt

I initially reproduced this crash by installing snapdrop.net as a standalone web app on a Huawei 5X (Android 5.1) device.

The crash is now fixed, but I can't add the snapdrop.net page as a web app. It doesn't return any error/message, no response. This happens only on my Huawei and Xiamoi devices. On others, it works well.

note: The page can be added as a regular homescreen shortcut (with manifest.install.enabled false).

Comment 13

[Dale Harvey (:daleharvey)]

Thats quite confusing, yeh I can install snapdrop.net fine on my pixel, did you / could you file a bug about that? I couldnt get this reproduced. This fix is fine but yeh if there is another root cause would like to take a look at that

Comment 14

[Oana Horvath [:ohorvath]]

Logged Bug 1360455. Thanks!