Closed
Bug 1355716
Opened 6 years ago
Closed 6 years ago
stylo: Consider supporting color overriding pref
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: xidorn, Assigned: heycam)
References
Details
Attachments
(1 file, 1 obsolete file)
There is a feature in Options that allow user to override all page with colors they specify in "Contents / Fonts & Colors / Colors / Override the colors specified by the page with your selections above:". We may need to support it. It is controlled by pref "browser.display.document_color_use", and test_dont_use_document_colors.html checks it.
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Comment 1•6 years ago
|
||
This is where Gecko uses that: http://searchfox.org/mozilla-central/rev/2fc8c8d483d9ec9fd0ec319c6c53807f7fa8e8a2/layout/style/nsCSSDataBlock.cpp#44-50
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Attachment #8872518 -
Flags: review?(xidorn+moz)
Assignee | ||
Comment 4•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=83aaf84c957bd8e23573c248d58b4b7220d44e90
Reporter | ||
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8872518 [details] style: Add support for disabled document colors. https://reviewboard.mozilla.org/r/144056/#review147760 ::: servo/components/style/properties/properties.mako.rs:595 (Diff revision 1) > + /// Returns true if the property is one that is ignored when document > + /// colors are disabled. > + fn is_ignored_when_document_colors_disabled(&self) -> bool { > + matches!(*self, > + ${" | ".join([("LonghandId::" + p.camel_case) > + for p in data.longhands if p.ignored_when_colors_disabled])} > + ) > + } I wonder whether it is better to reuse `PropertyFlags`... Probably not here.
Attachment #8872518 -
Flags: review?(xidorn+moz) → review+
Reporter | ||
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8872519 [details] Bug 1355716 - Update test expectations. https://reviewboard.mozilla.org/r/144058/#review147762
Attachment #8872519 -
Flags: review?(xidorn+moz) → review+
Assignee | ||
Comment 7•6 years ago
|
||
https://github.com/servo/servo/pull/17092
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Attachment #8872518 -
Attachment is obsolete: true
Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b3f99cbb2328 Update test expectations. r=xidorn
Comment 10•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b3f99cbb2328
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → cam
You need to log in
before you can comment on or make changes to this bug.
Description
•