stylo: Consider supporting color overriding pref

RESOLVED FIXED in Firefox 55

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: xidorn, Assigned: heycam)

Tracking

53 Branch
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

There is a feature in Options that allow user to override all page with colors they specify in "Contents / Fonts & Colors / Colors / Override the colors specified by the page with your selections above:".

We may need to support it.

It is controlled by pref "browser.display.document_color_use", and test_dont_use_document_colors.html checks it.
Priority: -- → P3
Attachment #8872518 - Flags: review?(xidorn+moz)
Comment on attachment 8872518 [details]
style: Add support for disabled document colors.

https://reviewboard.mozilla.org/r/144056/#review147760

::: servo/components/style/properties/properties.mako.rs:595
(Diff revision 1)
> +    /// Returns true if the property is one that is ignored when document
> +    /// colors are disabled.
> +    fn is_ignored_when_document_colors_disabled(&self) -> bool {
> +        matches!(*self,
> +            ${" | ".join([("LonghandId::" + p.camel_case)
> +                          for p in data.longhands if p.ignored_when_colors_disabled])}
> +        )
> +    }

I wonder whether it is better to reuse `PropertyFlags`... Probably not here.
Attachment #8872518 - Flags: review?(xidorn+moz) → review+
Comment on attachment 8872519 [details]
Bug 1355716 - Update test expectations.

https://reviewboard.mozilla.org/r/144058/#review147762
Attachment #8872519 - Flags: review?(xidorn+moz) → review+
Attachment #8872518 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/b3f99cbb2328
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Assignee: nobody → cam
You need to log in before you can comment on or make changes to this bug.