Closed Bug 1355716 Opened 8 years ago Closed 8 years ago

stylo: Consider supporting color overriding pref

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

53 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: xidorn, Assigned: heycam)

References

Details

Attachments

(1 file, 1 obsolete file)

There is a feature in Options that allow user to override all page with colors they specify in "Contents / Fonts & Colors / Colors / Override the colors specified by the page with your selections above:". We may need to support it. It is controlled by pref "browser.display.document_color_use", and test_dont_use_document_colors.html checks it.
Priority: -- → P3
Attachment #8872518 - Flags: review?(xidorn+moz)
Comment on attachment 8872518 [details] style: Add support for disabled document colors. https://reviewboard.mozilla.org/r/144056/#review147760 ::: servo/components/style/properties/properties.mako.rs:595 (Diff revision 1) > + /// Returns true if the property is one that is ignored when document > + /// colors are disabled. > + fn is_ignored_when_document_colors_disabled(&self) -> bool { > + matches!(*self, > + ${" | ".join([("LonghandId::" + p.camel_case) > + for p in data.longhands if p.ignored_when_colors_disabled])} > + ) > + } I wonder whether it is better to reuse `PropertyFlags`... Probably not here.
Attachment #8872518 - Flags: review?(xidorn+moz) → review+
Attachment #8872519 - Flags: review?(xidorn+moz) → review+
Attachment #8872518 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Assignee: nobody → cam
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: