1355716 - stylo: Consider supporting color overriding pref

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Xidorn Quan [:xidorn] UTC+10]

There is a feature in Options that allow user to override all page with colors they specify in "Contents / Fonts & Colors / Colors / Override the colors specified by the page with your selections above:".

We may need to support it.

It is controlled by pref "browser.display.document_color_use", and test_dont_use_document_colors.html checks it.

Comment 1

[Cameron McCormack (:heycam)]

This is where Gecko uses that: http://searchfox.org/mozilla-central/rev/2fc8c8d483d9ec9fd0ec319c6c53807f7fa8e8a2/layout/style/nsCSSDataBlock.cpp#44-50

Comment 2

[Cameron McCormack (:heycam)]

Attachment: style: Add support for disabled document colors.

Review commit: https://reviewboard.mozilla.org/r/144056/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/144056/

Comment 3

[Cameron McCormack (:heycam)]

Attachment: Bug 1355716 - Update test expectations.

Review commit: https://reviewboard.mozilla.org/r/144058/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/144058/

Comment 4

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=83aaf84c957bd8e23573c248d58b4b7220d44e90

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8872518 [details]
style: Add support for disabled document colors.

https://reviewboard.mozilla.org/r/144056/#review147760

::: servo/components/style/properties/properties.mako.rs:595
(Diff revision 1)
> +    /// Returns true if the property is one that is ignored when document
> +    /// colors are disabled.
> +    fn is_ignored_when_document_colors_disabled(&self) -> bool {
> +        matches!(*self,
> +            ${" | ".join([("LonghandId::" + p.camel_case)
> +                          for p in data.longhands if p.ignored_when_colors_disabled])}
> +        )
> +    }

I wonder whether it is better to reuse `PropertyFlags`... Probably not here.

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8872519 [details]
Bug 1355716 - Update test expectations.

https://reviewboard.mozilla.org/r/144058/#review147762

Comment 7

[Cameron McCormack (:heycam)]

https://github.com/servo/servo/pull/17092

Comment 8

[Cameron McCormack (:heycam)]

Comment on attachment 8872519 [details]
Bug 1355716 - Update test expectations.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/144058/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3f99cbb2328
Update test expectations. r=xidorn

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b3f99cbb2328