Closed Bug 1355734 Opened 2 years ago Closed 2 years ago

Consider removing -moz-anchor-decoration magic keyword

Categories

(Core :: CSS Parsing and Computation, enhancement)

53 Branch
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

(Keywords: dev-doc-complete, Whiteboard: [stylo])

Attachments

(1 file)

We have a magic keyword -moz-anchor-decoration for text-decoration-line that, it would reset text-decoration-line to none if user sets the preference to not underline links.

This was added in bug 57757, but it is not clear why it is still needed, since it seems user pref stylesheet is enabled everywhere.
Whiteboard: [stylo]
Blocks: 1356087
Comment on attachment 8857829 [details]
Bug 1355734 - Remove text-decoration-line: -moz-anchor-decoration.

https://reviewboard.mozilla.org/r/129848/#review132418

::: commit-message-5e37b:1
(Diff revision 1)
> +Bug 1355734 - Remove text-decoration-line: -moz-anchor-deciration. r?masayuki,heycam

-moz-anchor-decoration
Attachment #8857829 - Flags: review?(cam) → review+
Comment on attachment 8857829 [details]
Bug 1355734 - Remove text-decoration-line: -moz-anchor-decoration.

https://reviewboard.mozilla.org/r/129848/#review132456

This isn't enough to remove the feature entirely.

You need to remove nsPresContext::mUnderlineLinks and kPresContext_UnderlineLinks. Additionally, you need to remove the pref from all.js and setting UI in color.xul.

I wonder, did you talk about this to Thunderbird and SeaMonkey people? At least, you should notify them of this bug.
Attachment #8857829 - Flags: review?(masayuki) → review-
CCing :jaws who manages preference UI.

And I'd be happy if you'd add example of the user stylesheet into the commit message.
I'm not removing the underline link feature. I'm only removing the magic keyword, which, I believe, is no longer necessary for that feature.
And the reason it's not necessary is that we take it into account when building the pref style sheet:

http://searchfox.org/mozilla-central/rev/944f87c575e8a0bcefc1ed8efff10b34cf7a5169/layout/style/nsLayoutStylesheetCache.cpp#924-929
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 889991bbb65c -d 2df7d0984161: rebasing 389599:889991bbb65c "Bug 1355734 - Remove text-decoration-line: -moz-anchor-decoration. r=heycam,masayuki" (tip)
merging layout/style/test/stylo-failures.md
warning: conflicts while merging layout/style/test/stylo-failures.md! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Assignee: nobody → xidorn+moz
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/52ba40a2c133
Remove text-decoration-line: -moz-anchor-decoration. r=heycam,masayuki
https://hg.mozilla.org/mozilla-central/rev/52ba40a2c133
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.