135589 - win32 gmake builds require --srcdir

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[hacker formerly known as [e-mail]]

Comment 1

[hacker formerly known as [e-mail]]

The win32 gmake build has a known problem with absolute paths.  Specifically,
win32 native tools get confused by /cygdrive/ paths unless you've made a symlink
and some cygwin tools appear to be confused by dos-drive paths.  Because of
this, we've always (for the past 3 months) required that a developer manually
pass --srcdir to the build so that it always uses relative paths.  Here's a
patch to automate the setting of --srcdir.  

Here's a few of issues that make me question the effectiveness of the patch:
1) I haven't tried it on any drives that are not cygwin mounted (see bug 135391)
2) There's no way to override the autogenerated --srcdir as it's given on the
cmdline, which overrides mozconfig settings
3) I really don't have a good win32 test for client.mk and I don't want to make
that change for everyone.

Comment 2

[hacker formerly known as [e-mail]]

Attachment: Automatically use --srcdir if objdir != topsrcdir on win32

Comment 3

[hacker formerly known as [e-mail]]

Attachment: Use CONFIGURE_ARGS for --srcdir instead of CONFIGURE

Comment 4

[Brian Ryner (not reading)]

Comment on attachment 77798 [details] [diff] [review]
Use CONFIGURE_ARGS for --srcdir instead of CONFIGURE

r=bryner

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 77798 [details] [diff] [review]
Use CONFIGURE_ARGS for --srcdir instead of CONFIGURE

a=[e-mail] for drivers

Comment 6

[cls]

Patch has been checked in.

Comment 7

[hacker formerly known as [e-mail]]

Kai noticed a problem that relative links in the MOZ_OBJDIR were not being
correctly resolved.   Apparently, abs2rel takes the easy way out and doesn't do
any canonpath() or no_upwards() on its args.  Which is probably a good thing
since no_upwards seems to be broken.  I had to write my own.

Comment 8

[hacker formerly known as [e-mail]]

Attachment: Roll our own version of abs2rel

Comment 9

[Kai Engert [:KaiE:]]

Thanks for the patch!
Using it, doing an objdir build with gmake on win32, where objdir has .. in it,
does now work for me.

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 78518 [details] [diff] [review]
Roll our own version of abs2rel

a=[e-mail]

Comment 11

[hacker formerly known as [e-mail]]

Patch has been checked in on the 1.0 branch & the trunk.

Comment 12

[Daniel Bratell]

Did you check in client.mk? I don't see a 1.178 version of it. Was that part of 
patch 78518 only a mistake?

Comment 13

[Daniel Bratell]

On the other hand, with that part I still fail to build but in another way:

J:\moz\rmp\mozilla>make -f client.mk build_all
Adding client.mk options from j:\moz\rmp\profile_options:
    MOZ_OBJDIR=../prof_obj
cd ../prof_obj
/cygdrive/j/moz/rmp/mozilla/configure --srcdir=Usage: /cygdrive/j/moz/rmp/mozill
a/build/unix/abs2rel.pl dest_path start_path
Adding configure options from j:\moz\rmp\profile_options:
  --enable-crypto
  --srcdir=../mozilla
  --disable-debug
  --disable-dtd-debug
  --disable-logging
  --enable-optimize=-O2
configure: warning: /cygdrive/j/moz/rmp/mozilla/build/unix/abs2rel.pl: invalid h
ost type
configure: warning: dest_path: invalid host type
configure: error: can only configure for one host and one target at a time
*** Fix above errors and then restart with "make -f client.mk build"
make: *** [../prof_obj/Makefile] Error 1

It doesn't matter if I specify a srcdir in my MOZCONFIG file or not.

Comment 14

[hacker formerly known as [e-mail]]

Nope, looks like that checkin didn't take for the trunk.  Just checked it in. 
Thanks for the catch.

> /cygdrive/j/moz/rmp/mozilla/configure --srcdir=Usage: /cygdrive/j/moz/rmp/mozill
a/build/unix/abs2rel.pl dest_path start_path

The abs2rel.pl script is being called with incorrect args.  Try:
make -f client.mk SHELL='sh -x' 
to see what it's actually doing.

Comment 15

[Daniel Bratell]

I must have hand applied it wrongly beacuse now, after updating I no longer see 
that error. 

Instead I get another error. I have my src in ../mozilla. Before the client.mk 
update Mozilla set srcdir to ../.. and now it seems to set it to ..

The only way I have managed to get further is by hardcode the path in client.mk. 

+ pwd
+ dirname /cygdrive/j/moz/rmp/mozilla
+ echo /cygdrive/j/moz/rmp/mozilla
+ sed -e s%//%/%
+ echo /cygdrive/j/moz/rmp
+ sed -e s/^.://
+ cat /cygdrive/j/moz/rmp/mozilla/CVS/Root
+ echo /cygdrive/j/moz/rmp/cvsco.log
+ sed s%//%/%
+ cd /cygdrive/j/moz/rmp
+ test
+ true
+ mozilla/build/autoconf/mozconfig2client-mk /cygdrive/j/moz/rmp/mozilla mozilla
/.mozconfig.mk
+ cygpath -u ../prof_obj
+ /cygdrive/j/moz/rmp/mozilla/build/unix/abs2rel.pl /cygdrive/j/moz/rmp/mozilla
../prof_obj
+ test -f .mozconfig.out
+ cat .mozconfig.out
Adding client.mk options from j:\moz\rmp\profile_options:
    MOZ_OBJDIR=../prof_obj
+ rm -f .mozconfig.out
+ test ! -d ../prof_obj
+ true
+ echo cd ../prof_obj
cd ../prof_obj
+ echo /cygdrive/j/moz/rmp/mozilla/configure --srcdir=..
/cygdrive/j/moz/rmp/mozilla/configure --srcdir=..
+ cd ../prof_obj
+ /cygdrive/j/moz/rmp/mozilla/configure --srcdir=..
Adding configure options from j:\moz\rmp\profile_options:
  --enable-crypto
  --disable-debug
  --disable-dtd-debug
  --disable-logging
  --enable-optimize=-O2
configure: error: can not find sources in ..
+ echo *** Fix above errors and then restart with "make -f client.mk build"
*** Fix above errors and then restart with "make -f client.mk build"
+ exit 1
make: *** [../prof_obj/Makefile] Error 1

Comment 16

[hacker formerly known as [e-mail]]

Now that I'm awake....your MOZ_OBJDIR should be set to an absolute path.  You
want to set it to @TOPSRCDIR@/../prof_obj .

Comment 17

[Asa Dotzler [:asa]]

adding fixed1.0.0 keyword (branch resolution). This bug has comments saying it
was fixed on the 1.0 branch and a bonsai checkin comment that agrees. To verify
the bug has been fixed on the 1.0 branch please replace the fixed1.0.0 keyword
with verified1.0.0.