String Changes to about:preferences#sync

VERIFIED FIXED in Firefox 55

Status

()

Firefox
Preferences
VERIFIED FIXED
4 months ago
3 months ago

People

(Reporter: JW_SoftvisionQA, Assigned: jaws)

Tracking

(Blocks: 1 bug)

55 Branch
Firefox 55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 verified)

Details

(URL)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

4 months ago
Per Specs: https://mozilla.invisionapp.com/share/P4ACQT1E3#/screens/217167554

Remove Ellipsis:

Firefox Account Section:
Disconnect Button

Section Name Change:
Sync Across All Devices to Sync Settings

Update Description:

Sync Settings Section:
Choose what to synchronize on your devices using Firefox
(Assignee)

Updated

4 months ago
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
Spec for Sync pane: https://mozilla.invisionapp.com/share/P4ACQT1E3#/screens/217167554
(Assignee)

Updated

4 months ago
Blocks: 1324168
No longer blocks: 1335907

Comment 3

4 months ago
mozreview-review
Comment on attachment 8858222 [details]
Bug 1356009 - Fix inconsistencies with strings in about:preferences#sync.

https://reviewboard.mozilla.org/r/130186/#review132974

::: browser/locales/en-US/chrome/browser/preferences/sync.dtd:71
(Diff revision 1)
>  <!ENTITY signedOut.accountBox.create.accesskey  "C">
>  <!ENTITY signedOut.accountBox.signin  "Sign In">
>  <!ENTITY signedOut.accountBox.signin.accesskey  "I">
>  
> -<!ENTITY signedIn.engines.label       "Sync Across All Devices">
> +<!ENTITY signedIn.settings.label       "Sync Settings">
> +<!ENTITY signedIn.settings.description "Choose what to synchronize on your devices using &brandShortName;.">

Technically, the mock has no period. All our other descriptions do, so I think this is correct.
Attachment #8858222 - Flags: review?(gijskruitbosch+bugs) → review+
(In reply to :Gijs (away until Tuesday 18) from comment #3)
> Technically, the mock has no period. All our other descriptions do, so I
> think this is correct.

Yeah, that's why I put it there.

Comment 5

4 months ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cafd98a87987
Fix inconsistencies with strings in about:preferences#sync. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/cafd98a87987
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55

Updated

4 months ago
Depends on: 1359907
Verified fixed on Windows 7 x64, Windows 10 x86, Mac OSX 10.12.4 and Ubuntu 16.04 x64 using latest Nightly 55.0a1 (2017-05-10).
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
You need to log in before you can comment on or make changes to this bug.