1356009 - String Changes to about:preferences#sync

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Justin [:JW_SoftvisionQA]]

Per Specs: https://mozilla.invisionapp.com/share/P4ACQT1E3#/screens/217167554

Remove Ellipsis:

Firefox Account Section:
Disconnect Button

Section Name Change:
Sync Across All Devices to Sync Settings

Update Description:

Sync Settings Section:
Choose what to synchronize on your devices using Firefox

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1356009 - Fix inconsistencies with strings in about:preferences#sync.

Review commit: https://reviewboard.mozilla.org/r/130186/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/130186/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Spec for Sync pane: https://mozilla.invisionapp.com/share/P4ACQT1E3#/screens/217167554

Comment 3

[:Gijs (he/him)]

Comment on attachment 8858222 [details]
Bug 1356009 - Fix inconsistencies with strings in about:preferences#sync.

https://reviewboard.mozilla.org/r/130186/#review132974

::: browser/locales/en-US/chrome/browser/preferences/sync.dtd:71
(Diff revision 1)
>  <!ENTITY signedOut.accountBox.create.accesskey  "C">
>  <!ENTITY signedOut.accountBox.signin  "Sign In">
>  <!ENTITY signedOut.accountBox.signin.accesskey  "I">
>  
> -<!ENTITY signedIn.engines.label       "Sync Across All Devices">
> +<!ENTITY signedIn.settings.label       "Sync Settings">
> +<!ENTITY signedIn.settings.description "Choose what to synchronize on your devices using &brandShortName;.">

Technically, the mock has no period. All our other descriptions do, so I think this is correct.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to :Gijs (away until Tuesday 18) from comment #3)
> Technically, the mock has no period. All our other descriptions do, so I
> think this is correct.

Yeah, that's why I put it there.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cafd98a87987
Fix inconsistencies with strings in about:preferences#sync. r=Gijs

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/cafd98a87987

Comment 7

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on Windows 7 x64, Windows 10 x86, Mac OSX 10.12.4 and Ubuntu 16.04 x64 using latest Nightly 55.0a1 (2017-05-10).