Closed Bug 1356267 Opened 7 years ago Closed 7 years ago

heap write hazard reported in nsStyleImage::SetNull()

Categories

(Core :: CSS Parsing and Computation, defect, P1)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: sfink, Assigned: manishearth)

References

Details

(Keywords: stale-bug, Whiteboard: [Stylo]) 

[24.14s] #85 Analyzing Gecko_SetNullImageValue ...
Error: AddRef/Release on nsISupports
Location: _ZN12nsStyleImage7SetNullEv$void nsStyleImage::SetNull() @ https://searchfox.org/mozilla-central/source/layout/style/nsStyleStruct.cpp#2209 ### SafeArguments: <this>
Stack Trace:
Gecko_SetNullImageValue @ https://searchfox.org/mozilla-central/source/layout/style/ServoBindings.cpp#974 ### SafeArguments: <arg0>
Assignee: nobody → manishearth
Priority: -- → P1
Blocks: 1356458
Summary: stylo: heap write hazard reported in nsStyleImage::SetNull() → heap write hazard reported in nsStyleImage::SetNull()
Whiteboard: [Stylo]
At least right now, this appears to be complaining about NS_RELEASE(mElementId), which is an nsIAtom and so should already be whitelisted. But that might be because of the if/else if chaining or something, and this is actually from NS_RELEASE(mImage), and it sounds like that's more complicated.
This seems to have been fixed at some point. The current analysis doesn't seem complain about this if I remove the whitelist entry.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.