Closed Bug 1356347 Opened 7 years ago Closed 6 years ago

Intermittent browser/base/content/test/tabs/browser_opened_file_tab_navigated_to_web.js | Check that new file:// page has navigated successfully to web content - Got about:blank, expected http://example.org/

Categories

(Core :: Security: Process Sandboxing, defect)

Product:
Core
Component:
Security: Process Sandboxing
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox-esr60 --- fixed
firefox63 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: mconley)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure, Whiteboard: sb+[stockwell fixed])

Attachments

(2 files)

Skipped test on mac and linux
812 bytes, patch
jmaher
: review+
mconley
: checkin+
Details | Diff | Splinter Review
bug1356347.diff
2.79 KB, patch
bobowen
: review+
Details | Diff | Splinter Review
Whiteboard: sb+
Blocks: sb-test
There have been 30 failures in the last 7 days, 29 failures on osx 10.10 debug and 1 on linux x64 pgo.

Recent failure log:
https://treeherder.mozilla.org/logviewer.html#?job_id=189756154&repo=autoland&lineNumber=8932


05:04:41     INFO - TEST-START | browser/base/content/test/tabs/browser_opened_file_tab_navigated_to_web.js
05:04:41     INFO - GECKO(804) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /var/folders/r7/35rbn4j97_j83m52vtf57r4400000x/T/tmp98LMN4.mozrunner/runtests_leaks_tab_pid827.log
05:04:41     INFO - GECKO(804) | ++DOCSHELL 0x113bd2000 == 1 [pid = 827] [id = {f927fe9f-0eca-dc46-91ad-bda2d540e992}]
05:04:41     INFO - GECKO(804) | ++DOMWINDOW == 1 (0x10c83ae00) [pid = 827] [serial = 1] [outer = 0x0]
05:04:41     INFO - GECKO(804) | --DOCSHELL 0x125edf000 == 10 [pid = 804] [id = {f9cd56ec-caf4-a946-8797-8918acb41b54}]
05:04:41     INFO - GECKO(804) | ++DOMWINDOW == 2 (0x11b51d800) [pid = 827] [serial = 2] [outer = 0x10c83ae00]
05:04:41     INFO - GECKO(804) | --DOMWINDOW == 14 (0x12591b400) [pid = 823] [serial = 39] [outer = 0x0] [url = about:blank]
05:04:41     INFO - GECKO(804) | --DOMWINDOW == 13 (0x125918000) [pid = 823] [serial = 38] [outer = 0x0] [url = about:blank]
05:04:41     INFO - GECKO(804) | --DOMWINDOW == 12 (0x12618c400) [pid = 823] [serial = 36] [outer = 0x0] [url = http://mochi.test:8888/#0]
05:04:41     INFO - GECKO(804) | --DOMWINDOW == 11 (0x126191c00) [pid = 823] [serial = 40] [outer = 0x0] [url = http://mochi.test:8888/#4]
05:04:41     INFO - GECKO(804) | --DOCSHELL 0x11ced4800 == 3 [pid = 823] [id = {00a79b28-6bbd-e042-b0e5-bdd515b92b37}]
05:04:41     INFO - GECKO(804) | --DOCSHELL 0x11ced7000 == 2 [pid = 823] [id = {b1d11bf2-92b7-cb45-98a8-55889601b945}]
05:04:41     INFO - GECKO(804) | --DOCSHELL 0x129691800 == 9 [pid = 804] [id = {524d0a2b-04ee-564e-bb8c-451d71eeaf79}]
05:04:41     INFO - GECKO(804) | ++DOMWINDOW == 3 (0x11c111000) [pid = 827] [serial = 3] [outer = 0x10c83ae00]
05:04:41     INFO - GECKO(804) | 2018-07-24 05:04:26.903 plugin-container[827:8873] *** CFMessagePort: bootstrap_register(): failed 1100 (0x44c) 'Permission denied', port = 0x964b, name = 'com.apple.tsm.portname'
05:04:41     INFO - GECKO(804) | See /usr/include/servers/bootstrap_defs.h for the error codes.
05:04:41     INFO - GECKO(804) | [Parent 804, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x804B000A: file /builds/worker/workspace/build/src/obj-firefox/dist/include/nsIURIMutator.h, line 450
05:04:41     INFO - GECKO(804) | [Parent 804, Main Thread] WARNING: NS_ENSURE_SUCCESS(mStatus, *this) failed with result 0x804B000A: file /builds/worker/workspace/build/src/obj-firefox/dist/include/nsIURIMutator.h, line 605
05:04:41     INFO - GECKO(804) | [Parent 804, Main Thread] WARNING: NS_ENSURE_SUCCESS(mStatus, mStatus) failed with result 0x804B000A: file /builds/worker/workspace/build/src/obj-firefox/dist/include/nsIURIMutator.h, line 644
05:04:41     INFO - GECKO(804) | ++DOCSHELL 0x11c18e000 == 2 [pid = 827] [id = {deed154e-f08f-914e-9e6c-a3cdf4c701b6}]
05:04:41     INFO - GECKO(804) | ++DOMWINDOW == 4 (0x11c12ee00) [pid = 827] [serial = 4] [outer = 0x0]
05:04:41     INFO - GECKO(804) | --DOMWINDOW == 20 (0x11b812c00) [pid = 807] [serial = 185] [outer = 0x0] [url = about:blank]
05:04:41     INFO - GECKO(804) | --DOMWINDOW == 19 (0x11c7a9c00) [pid = 807] [serial = 189] [outer = 0x0] [url = http://mochi.test:8888/#1]
05:04:41     INFO - GECKO(804) | --DOMWINDOW == 18 (0x122eeac00) [pid = 807] [serial = 191] [outer = 0x0] [url = about:blank]
05:04:41     INFO - GECKO(804) | --DOMWINDOW == 17 (0x11c13e000) [pid = 807] [serial = 192] [outer = 0x0] [url = http://mochi.test:8888/#8]
05:04:41     INFO - GECKO(804) | --DOMWINDOW == 16 (0x11c7a6c00) [pid = 807] [serial = 188] [outer = 0x0] [url = about:blank]
05:04:41     INFO - GECKO(804) | --DOMWINDOW == 15 (0x11c7a5c00) [pid = 807] [serial = 187] [outer = 0x0] [url = about:blank]
05:04:41     INFO - GECKO(804) | --DOMWINDOW == 14 (0x11b811400) [pid = 807] [serial = 183] [outer = 0x0] [url = http://example.com/browser/browser/base/content/test/tabs/file_new_tab_page.html]
05:04:41     INFO - GECKO(804) | --DOCSHELL 0x11c76e000 == 3 [pid = 807] [id = {3866dda2-0942-9d48-9003-3d33f4c79c42}]
05:04:42     INFO - GECKO(804) | --DOCSHELL 0x11c1c3800 == 2 [pid = 807] [id = {b23dacd9-264a-f442-a918-abc26665765a}]
05:04:42     INFO - GECKO(804) | ++DOMWINDOW == 5 (0x11c11b400) [pid = 827] [serial = 5] [outer = 0x11c12ee00]
05:04:42     INFO - GECKO(804) | ++DOMWINDOW == 6 (0x11c11b000) [pid = 827] [serial = 6] [outer = 0x11c12ee00]
05:04:42     INFO - GECKO(804) | [Parent 804, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x804B000A: file /builds/worker/workspace/build/src/obj-firefox/dist/include/nsIURIMutator.h, line 450
05:04:42     INFO - GECKO(804) | [Parent 804, Main Thread] WARNING: NS_ENSURE_SUCCESS(mStatus, *this) failed with result 0x804B000A: file /builds/worker/workspace/build/src/obj-firefox/dist/include/nsIURIMutator.h, line 605
05:04:42     INFO - GECKO(804) | [Parent 804, Main Thread] WARNING: NS_ENSURE_SUCCESS(mStatus, mStatus) failed with result 0x804B000A: file /builds/worker/workspace/build/src/obj-firefox/dist/include/nsIURIMutator.h, line 644
05:04:42     INFO - GECKO(804) | ++DOCSHELL 0x11ceda800 == 3 [pid = 823] [id = {fa3d719f-8b9a-bc47-86cd-b948bdf20e14}]
05:04:42     INFO - GECKO(804) | ++DOMWINDOW == 12 (0x125931a00) [pid = 823] [serial = 52] [outer = 0x0]
05:04:42     INFO - GECKO(804) | ++DOMWINDOW == 13 (0x12591b400) [pid = 823] [serial = 53] [outer = 0x125931a00]
05:04:42     INFO - GECKO(804) | ++DOMWINDOW == 14 (0x126186800) [pid = 823] [serial = 54] [outer = 0x125931a00]
05:04:42     INFO - TEST-INFO | started process screencapture
05:04:42     INFO - TEST-INFO | screencapture: exit 0
05:04:42     INFO - Buffered messages logged at 05:04:25
05:04:42     INFO - Entering test bound 
05:04:42     INFO - Buffered messages logged at 05:04:26
05:04:42     INFO - Console message: [JavaScript Warning: "Use of nsIFile in content process is deprecated." {file: "resource://gre/modules/FileUtils.jsm" line: 170}]
05:04:42     INFO - Buffered messages finished
05:04:42     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/tabs/browser_opened_file_tab_navigated_to_web.js | Check that new file:// page has navigated successfully to web content - Got about:blank, expected http://example.org/
05:04:42     INFO - Stack trace:
05:04:42     INFO - chrome://mochikit/content/browser-test.js:test_is:1305
05:04:42     INFO - chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_opened_file_tab_navigated_to_web.js:null:40
05:04:42     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1103
05:04:42     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1094
05:04:42     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:996
05:04:42     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
05:04:42     INFO - Leaving test bound 
05:04:42     INFO - GECKO(804) | --DOMWINDOW == 13 (0x11c7dc400) [pid = 807] [serial = 186] [outer = 0x0] [url = about:blank]
05:04:42     INFO - GECKO(804) | MEMORY STAT | vsize 4525MB | residentFast 525MB | heapAllocated 124MB
05:04:42     INFO - TEST-OK | browser/base/content/test/tabs/browser_opened_file_tab_navigated_to_web.js | took 2604ms
Flags: needinfo?(jmathies)
Whiteboard: sb+ → sb+[stockwell needswork:owner]
added to my stockwell list
Flags: needinfo?(jmathies)
Flags: needinfo?(mconley)
Mike, can you direct this to anybody to investigate, please? This got frequent around last Friday? Thank you.
Attachment #9003737 - Flags: review?(jmaher) → review+
Keywords: checkin-needed, leave-open
Whiteboard: sb+[stockwell disable-recommended] → sb+[stockwell disabled]
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6e4959e6606
Disable browser_opened_file_tab_navigated_to_web.js on linux and mac for frequent failures. r=jmaher
Keywords: checkin-needed
I think we're seeing the load event for the initial about:blank after the process flip. That's probably gotten worse because we're making content process start-up faster lately, and so we have less of a chance of interrupting the initial about:blank load with the request for the next page.

I have a try push up that'll wait until the example.com page loads as expected: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c4af7c5f167bf57467e10a85890eab9137bba721
Flags: needinfo?(mconley)
Assignee: nobody → mconley
Attached patch bug1356347.diff — — Splinter Review 
This seems to do the trick, at least according to try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a18d26c98db34ff9bde19faa864e1bd0c4bc4371

That other orange (bug 1366137) can probably be solved in a similar way.
Attachment #9005027 - Flags: review?(bobowencode)
See Also: → 1366137
Comment on attachment 9005027 [details] [diff] [review]
bug1356347.diff

Review of attachment 9005027 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks mconley, I'll try this on the other bug.
Attachment #9005027 - Flags: review?(bobowencode) → review+
Comment on attachment 9003737 [details] [diff] [review]
Skipped test on mac and linux

This one is already checked in.
Attachment #9003737 - Flags: checkin+
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7db77bd81f0f
Handle race in browser_opened_file_tab_navigated_to_web.js due to process flip. r=bobowen
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7db77bd81f0f
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Whiteboard: sb+[stockwell disabled] → sb+
Whiteboard: sb+ → sb+[stockwell fixed]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: