Note: There are a few cases of duplicates in user autocompletion which are being worked on.

For Vive controllers the hand attribute is not always available

RESOLVED FIXED in Firefox 55

Status

()

Core
WebVR
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: dmarcos, Assigned: daoshengmu)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(5 attachments, 1 obsolete attachment)

(Reporter)

Description

3 months ago
OpenVR probably reports a controller before knowing the handedness because it's calculated based on the relative position to the user's head. This results in the Gamepad API returning a gamepad without a hand attribute. Gecko should probably wait until the hand is defined by OpenVR before reporting the controller through the GamepadAPI.
(Assignee)

Updated

3 months ago
Assignee: nobody → dmu
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 6

3 months ago
OpenVR can change the hand property of controllers when the controller turns to be available, but for switching controller from hands at runtime. (left <--->right). It does not have new changes at the current OpenVR SDK. But, it makes sense for me still do this check at runtime rather than waiting it until it is available.

Comment 7

3 months ago
mozreview-review
Comment on attachment 8859048 [details]
Bug 1356452 - Part 3: Support changing gamepad hand property in GamepadManager;

https://reviewboard.mozilla.org/r/131072/#review133644

Looks nice!
Attachment #8859048 - Flags: review?(cleu) → review+
Comment on attachment 8859049 [details]
Bug 1356452 - Part 4: Add gamepad set hand function in Gamepad;

https://reviewboard.mozilla.org/r/131074/#review133900
Attachment #8859049 - Flags: review?(kyle) → review+

Comment 9

3 months ago
mozreview-review
Comment on attachment 8859046 [details]
Bug 1356452 - Part 1: Remove assertion for checking VRManager::Get();

https://reviewboard.mozilla.org/r/131068/#review133986

LGTM, these were redundant.
Attachment #8859046 - Flags: review?(kgilbert) → review+

Comment 10

3 months ago
mozreview-review
Comment on attachment 8859047 [details]
Bug 1356452 - Part 2: Replace vr:: namespace with ::vr:: in OpenVR;

https://reviewboard.mozilla.org/r/131070/#review133994

LGTM, Thanks!
Attachment #8859047 - Flags: review?(kgilbert) → review+

Comment 11

3 months ago
mozreview-review
Comment on attachment 8859050 [details]
Bug 1356452 - Part 5: Detect hand changing at runtime for OpenVR controllers;

https://reviewboard.mozilla.org/r/131076/#review133996

Thanks!
Attachment #8859050 - Flags: review?(kgilbert) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 15

3 months ago
After some discussion with Lenzak, I decide to drop my part 6 patch and move it to Bug 1358064.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

3 months ago
Attachment #8859827 - Attachment is obsolete: true
Attachment #8859827 - Flags: review?(cleu)

Comment 21

3 months ago
Pushed by dmu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/45597054d4e8
Part 1: Remove assertion for checking VRManager::Get(); r=kip
https://hg.mozilla.org/integration/autoland/rev/b425dbaf9394
Part 2: Replace vr:: namespace with ::vr:: in OpenVR; r=kip
https://hg.mozilla.org/integration/autoland/rev/fed55d5486d0
Part 3: Support changing gamepad hand property in GamepadManager; r=Lenzak
https://hg.mozilla.org/integration/autoland/rev/2e29632323c9
Part 4: Add gamepad set hand function in Gamepad; r=qdot
https://hg.mozilla.org/integration/autoland/rev/ecc42c31cc28
Part 5: Detect hand changing at runtime for OpenVR controllers; r=kip

Comment 22

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/45597054d4e8
https://hg.mozilla.org/mozilla-central/rev/b425dbaf9394
https://hg.mozilla.org/mozilla-central/rev/fed55d5486d0
https://hg.mozilla.org/mozilla-central/rev/2e29632323c9
https://hg.mozilla.org/mozilla-central/rev/ecc42c31cc28
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Blocks: 1358064
You need to log in before you can comment on or make changes to this bug.