Closed Bug 1356452 Opened 8 years ago Closed 8 years ago

For Vive controllers the hand attribute is not always available

Categories

(Core :: WebVR, defect)

Product:
Core
Component:
WebVR
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: dmarcos, Assigned: daoshengmu)

References

Details

Attachments

(5 files, 1 obsolete file)

Bug 1356452 - Part 1: Remove assertion for checking VRManager::Get();
59 bytes, text/x-review-board-request
kip
: review+
Details
Bug 1356452 - Part 2: Replace vr:: namespace with ::vr:: in OpenVR;
59 bytes, text/x-review-board-request
kip
: review+
Details
Bug 1356452 - Part 3: Support changing gamepad hand property in GamepadManager;
59 bytes, text/x-review-board-request
cleu
: review+
Details
Bug 1356452 - Part 4: Add gamepad set hand function in Gamepad;
59 bytes, text/x-review-board-request
qdot
: review+
Details
Bug 1356452 - Part 5: Detect hand changing at runtime for OpenVR controllers;
59 bytes, text/x-review-board-request
kip
: review+
Details
OpenVR probably reports a controller before knowing the handedness because it's calculated based on the relative position to the user's head. This results in the Gamepad API returning a gamepad without a hand attribute. Gecko should probably wait until the hand is defined by OpenVR before reporting the controller through the GamepadAPI.
Assignee: nobody → dmu
OpenVR can change the hand property of controllers when the controller turns to be available, but for switching controller from hands at runtime. (left <--->right). It does not have new changes at the current OpenVR SDK. But, it makes sense for me still do this check at runtime rather than waiting it until it is available.
Comment on attachment 8859048 [details] Bug 1356452 - Part 3: Support changing gamepad hand property in GamepadManager; https://reviewboard.mozilla.org/r/131072/#review133644 Looks nice!
Attachment #8859048 - Flags: review?(cleu) → review+
Comment on attachment 8859049 [details] Bug 1356452 - Part 4: Add gamepad set hand function in Gamepad; https://reviewboard.mozilla.org/r/131074/#review133900
Attachment #8859049 - Flags: review?(kyle) → review+
Comment on attachment 8859046 [details] Bug 1356452 - Part 1: Remove assertion for checking VRManager::Get(); https://reviewboard.mozilla.org/r/131068/#review133986 LGTM, these were redundant.
Attachment #8859046 - Flags: review?(kgilbert) → review+
Comment on attachment 8859047 [details] Bug 1356452 - Part 2: Replace vr:: namespace with ::vr:: in OpenVR; https://reviewboard.mozilla.org/r/131070/#review133994 LGTM, Thanks!
Attachment #8859047 - Flags: review?(kgilbert) → review+
Comment on attachment 8859050 [details] Bug 1356452 - Part 5: Detect hand changing at runtime for OpenVR controllers; https://reviewboard.mozilla.org/r/131076/#review133996 Thanks!
Attachment #8859050 - Flags: review?(kgilbert) → review+
After some discussion with Lenzak, I decide to drop my part 6 patch and move it to Bug 1358064.
Attachment #8859827 - Attachment is obsolete: true
Attachment #8859827 - Flags: review?(cleu)
Pushed by dmu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/45597054d4e8 Part 1: Remove assertion for checking VRManager::Get(); r=kip https://hg.mozilla.org/integration/autoland/rev/b425dbaf9394 Part 2: Replace vr:: namespace with ::vr:: in OpenVR; r=kip https://hg.mozilla.org/integration/autoland/rev/fed55d5486d0 Part 3: Support changing gamepad hand property in GamepadManager; r=Lenzak https://hg.mozilla.org/integration/autoland/rev/2e29632323c9 Part 4: Add gamepad set hand function in Gamepad; r=qdot https://hg.mozilla.org/integration/autoland/rev/ecc42c31cc28 Part 5: Detect hand changing at runtime for OpenVR controllers; r=kip
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: