46 bytes, text/x-phabricator-request
|Details | Review|
When extending byte-check to imported scripts before launching a service worker, there comes a corner case that an imported script might be no longer available after its hosting site revises it. Thus, when practising byte-check on imported scripts, we tolerate network failures of imported scripts, as suggested by the Patch 3.2 for bug 1290951 (https://bug1290951.bmoattachments.org/attachment.cgi?id=8841928). Since this behaviour should be shared among different browsers, the testcase should be moved to web-plateform-tests. Also, it would be great that we give the testcase a more understandable name :)
Hi Eden, could you please put this into your queue and help this? Ho-Pang has some ideas that you might want to discuss with him. Thank you.
Assignee: bhsu → nobody
Priority: P3 → P2
OK, I will discuss with him.
Assignee: nobody → echuang
Status: NEW → ASSIGNED
Assignee: echuang → nobody
Status: ASSIGNED → NEW
Priority: P2 → P3
Eden, would you be able to review this?
Sure, send a review request to me.
Attachment #9010789 - Attachment description: Bug 1357290 - move test_update_missing_imported_script.html to WPT r?asuth → Bug 1357290 - move test_update_missing_imported_script.html to WPT r?edenchuang
Hi, when trying to land this bug I received this: Error: We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, 'applying /tmp/tmpMSD_J4\npatching file testing/web-platform/meta/MANIFEST.json\nHunk #3 FAILED at 578416\nHunk #4 FAILED at 578808\nHunk #5 FAILED at 579220\nHunk #8 FAILED at 656480\nHunk #9 FAILED at 656516\nHunk #10 FAILED at 656616\n6 out of 10 hunks FAILED -- saving rejects to file testing/web-platform/meta/MANIFEST.json.rej\nabort: patch failed to apply', '') Please take a look.
My bad, just updated the changes to be rebaseable. Removed the MANIFEST.json changes due to bug 1473915.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/9f3a74845bdb move test_update_missing_imported_script.html to WPT r=edenchuang
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13728 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Upstream PR merged
You need to log in before you can comment on or make changes to this bug.