1357311 - Reuse image key for nsDisplayBullet with same path style

Status: RESOLVED WONTFIX

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Ethan Lin[:ethlin]]

This is a following bug of bug 1349500. Currently we generate image key for each path type bullet item. We should reuse the image key so that we don't need to render/upload some many images.

Comment 1

[Sotaro Ikeda [:sotaro]]

:ethlin, how are you going to implement a fix? Is it conflict to Bug 1355702 work?

Comment 2

[Ethan Lin[:ethlin]]

(In reply to Sotaro Ikeda [:sotaro] from comment #1)
> :ethlin, how are you going to implement a fix? Is it conflict to Bug 1355702
> work?

I think it's not conflict to Bug 1355702. I will reuse the image key based on display item info since two display items with the same style will generate the same image. According to the patch in bug 1355702, it looks like reusing the image key based on the ImageClient's counter. The two bugs should be different approaches to deduce WrImageKey allocation.

Comment 3

[Sotaro Ikeda [:sotaro]]

Thanks!

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Is this related to the recent 'reusing the keys' work?

Comment 5

[Nicolas Silva [:nical]]

(In reply to Milan Sreckovic [:milan] from comment #4)
> Is this related to the recent 'reusing the keys' work?

I think that this one is about using the same image key within a frame when several bullet points have the same style and size. In addition to that we should reuse these image keys across frames (the latter is what you are referring to).

Comment 6

[Ethan Lin[:ethlin]]

This bug should have low priority for now. I won't look into this bug in a short time. Change to priority to P2 and remove the assignee.

Comment 7

[Jeff Muizelaar [:jrmuizel]]

I don't think this needs to block