Remove media/webrtc/trunk/webrtc/modules/audio_device/gonk

RESOLVED WORKSFORME

Status

()

P3
normal
Rank:
25
RESOLVED WORKSFORME
2 years ago
a year ago

People

(Reporter: glandium, Assigned: dminor)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
As per bug 1355752 comment 25, gonk widget support can go away now.
Rank: 25
Priority: -- → P2
(Assignee)

Updated

2 years ago
Assignee: nobody → dminor
(Assignee)

Comment 1

2 years ago
Created attachment 8859142 [details] [diff] [review]
Remove gonk audio device

Can probably just import this into the patch queue for the branch 57 update.
Attachment #8859142 - Flags: review?(rjesup)
(Reporter)

Comment 2

2 years ago
There are gyp files that reference those.
(Assignee)

Comment 3

2 years ago
(In reply to Mike Hommey [:glandium] (VAC: Apr 20-May 4) from comment #2)
> There are gyp files that reference those.

Thanks! It built ok, but I should have searched for references to the files anyway.
(Assignee)

Comment 4

2 years ago
Hmm, the only references to "audio_manager.cc" I'm seeing are to android/audio_manager.cc, which presumably we want to keep.

I filed Bug 1357368 to handle removing the rest of the references to gonk from the webrtc code base. I'm guessing :jesup would prefer to wait until after the branch 57 update lands before we clean that stuff up, rather than having to do a rebase.
Comment on attachment 8859142 [details] [diff] [review]
Remove gonk audio device

Review of attachment 8859142 [details] [diff] [review]:
-----------------------------------------------------------------

Yes = making it clear I'm holding off until the v57 update lands later this week, probably
Attachment #8859142 - Flags: review?(rjesup)
Flags: needinfo?(rjesup)
No longer blocks: 1369194
Mass change P2->P3 to align with new Mozilla triage process.
Priority: P2 → P3
(Assignee)

Comment 7

a year ago
Looks like all references are now gone.
Status: NEW → RESOLVED
Last Resolved: a year ago
Flags: needinfo?(rjesup)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.