1357350 - stylo: setting border shorthands should reset longhands of border-image to their initial value

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Jeremy Chen ([e-mail])]

Setting border and border-[side] shorthands should reset longhands of border-image to their initial value. There're ~70 test failures related to this. Let's fix it.


Spec: https://drafts.csswg.org/css-backgrounds-3/#the-border-shorthands
Servo issue: https://github.com/servo/servo/issues/15202

Comment 1

[Jeremy Chen ([e-mail])]

Attachment: Bug 1357350 - reset longhands of border-image to their initial value while parsing border shorthand.

To do so, we need to declare the border-image longhands as part of border and
border-[side] shorthands, and always reset them.

Spec link: https://drafts.csswg.org/css-backgrounds-3/#the-border-shorthands

Review commit: https://reviewboard.mozilla.org/r/131274/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131274/

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 8859257 [details]
Bug 1357350 - reset longhands of border-image to their initial value while parsing border shorthand.

https://reviewboard.mozilla.org/r/131274/#review134014

Do you need to some test expectation adjustments in this bug too?

::: servo/components/style/properties/shorthand/border.mako.rs:113
(Diff revision 1)
> +            // The ‘border-[side]’ shorthand resets ‘border-image’ to its initial value.
> +            // See https://drafts.csswg.org/css-backgrounds-3/#the-border-shorthands
> +            % for name in "outset repeat slice source width".split():
> +                border_image_${name}: border_image_${name}::get_initial_specified_value(),
> +            % endfor

I don't think the spec says to reset the border-image properties when the border-{top,right,bottom,left} shorthands are used.

Comment 3

[Jeremy Chen ([e-mail])]

Comment on attachment 8859257 [details]
Bug 1357350 - reset longhands of border-image to their initial value while parsing border shorthand.

https://reviewboard.mozilla.org/r/131274/#review134014

Yes, I'll upload this part once I get the try result.

> I don't think the spec says to reset the border-image properties when the border-{top,right,bottom,left} shorthands are used.

Yeah, you're right. I guess I misunderstood the words in the spec...

Comment 4

[Jeremy Chen ([e-mail])]

Comment on attachment 8859257 [details]
Bug 1357350 - reset longhands of border-image to their initial value while parsing border shorthand.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131274/diff/1-2/

Comment 5

[Cameron McCormack (:heycam)]

Comment on attachment 8859257 [details]
Bug 1357350 - reset longhands of border-image to their initial value while parsing border shorthand.

https://reviewboard.mozilla.org/r/131274/#review134116

Looks good, thanks!

Comment 6

[Jeremy Chen ([e-mail])]

Attachment: Bug 1357350 - update test expectations for reseting longhands of border-image while parsing border shorthand.

Review commit: https://reviewboard.mozilla.org/r/131468/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131468/

Comment 7

[Jeremy Chen ([e-mail])]

Comment on attachment 8859257 [details]
Bug 1357350 - reset longhands of border-image to their initial value while parsing border shorthand.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131274/diff/2-3/

Comment 8

[Jeremy Chen ([e-mail])]

Update test expectations based on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e37e49d4b27738c7f7dd11d6844271613ed0c2ba&selectedJob=92549661

Comment 9

[Jeremy Chen ([e-mail])]

servo PR: https://github.com/servo/servo/pull/16522
try with test expectations update: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b60ef8e6024d2134891d090d37647dcb8ff72755

Comment 10

[Jeremy Chen ([e-mail])]

Comment on attachment 8859434 [details]
Bug 1357350 - update test expectations for reseting longhands of border-image while parsing border shorthand.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131468/diff/1-2/

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8859434 [details]
Bug 1357350 - update test expectations for reseting longhands of border-image while parsing border shorthand.

https://reviewboard.mozilla.org/r/131468/#review135514

\o/, thanks for doing this Jeremy!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47061b2e66cb
update test expectations for reseting longhands of border-image while parsing border shorthand. r=emilio

Comment 13

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/47061b2e66cb